Skip to content

Commit 2d550ad

Browse files
authored
Merge pull request #85 from BertvanHoekelen/remove-sleep-and-wakeup
Remove __sleep & __wakeup from ActionJob
2 parents 35741b4 + 1f62dce commit 2d550ad

File tree

2 files changed

+2
-22
lines changed

2 files changed

+2
-22
lines changed

src/ActionJob.php

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ class ActionJob implements ShouldQueue
1515
use Dispatchable, InteractsWithQueue, Queueable, Batchable;
1616

1717
use SerializesModels {
18-
__sleep as serializesModelsSleep;
19-
__wakeup as serializesModelsWakeup;
2018
__serialize as serializesModelsSerialize;
2119
__unserialize as serializesModelsUnserialize;
2220
}
@@ -94,24 +92,6 @@ public function handle()
9492
$action->{$action->queueMethod()}(...$this->parameters);
9593
}
9694

97-
public function __sleep()
98-
{
99-
foreach ($this->parameters as $index => $parameter) {
100-
$this->parameters[$index] = $this->getSerializedPropertyValue($parameter);
101-
}
102-
103-
return $this->serializesModelsSleep();
104-
}
105-
106-
public function __wakeup()
107-
{
108-
$this->serializesModelsWakeup();
109-
110-
foreach ($this->parameters as $index => $parameter) {
111-
$this->parameters[$index] = $this->getRestoredPropertyValue($parameter);
112-
}
113-
}
114-
11595
public function __serialize()
11696
{
11797
foreach ($this->parameters as $index => $parameter) {

tests/ActionMakeCommandTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public function it_generates_queueable_actions(): void
1414

1515
$this->artisan('make:action', [
1616
'name' => 'TestAction',
17-
])->expectsOutput('Action created successfully.')->assertExitCode(0);
17+
])->expectsOutputToContain('Action [app/Actions/TestAction.php] created successfully.')->assertExitCode(0);
1818
}
1919

2020
/** @test */
@@ -25,7 +25,7 @@ public function it_generates_synchronous_actions(): void
2525
$this->artisan('make:action', [
2626
'name' => 'TestAction',
2727
'--sync' => true,
28-
])->expectsOutput('Action created successfully.')->assertExitCode(0);
28+
])->expectsOutputToContain('Action [app/Actions/TestAction.php] created successfully.')->assertExitCode(0);
2929
}
3030

3131
private function expectsGeneratedClass(string $filename, string $contents): void

0 commit comments

Comments
 (0)