Merge pull request #132 from lukasleitsch/stream-download-with-delimiter

freekmurze · web-flow · commit bbef9873a018 · 2023-01-20T17:52:54.000+01:00
Allow delimiter in streamDownload()
diff --git a/src/SimpleExcelWriter.php b/src/SimpleExcelWriter.php
@@ -56,9 +56,9 @@ public static function createWithoutBom(string $file, string $type = ''): static
         );
     }
 
-    public static function streamDownload(string $downloadName, string $type = '', callable $writerCallback = null): static
+    public static function streamDownload(string $downloadName, string $type = '', callable $writerCallback = null, ?string $delimiter = null): static
     {
-        $simpleExcelWriter = new static($downloadName, $type);
+        $simpleExcelWriter = new static($downloadName, $type, $delimiter);
 
         $writer = $simpleExcelWriter->getWriter();
 

Original file line number	Diff line number	Diff line change
`@@ -56,9 +56,9 @@ public static function createWithoutBom(string $file, string $type = ''): static`
`56`	`56`	`);`
`57`	`57`	`}`
`58`	`58`
`59`		`- public static function streamDownload(string $downloadName, string $type = '', callable $writerCallback = null): static`
	`59`	`+ public static function streamDownload(string $downloadName, string $type = '', callable $writerCallback = null, ?string $delimiter = null): static`
`60`	`60`	`{`
`61`		`- $simpleExcelWriter = new static($downloadName, $type);`
	`61`	`+ $simpleExcelWriter = new static($downloadName, $type, $delimiter);`
`62`	`62`
`63`	`63`	`$writer = $simpleExcelWriter->getWriter();`
`64`	`64`