Skip to content

Commit 9b8e39f

Browse files
authored
Update test case files & README.md (#195)
* Update DownloaderTest.php Remove unused var. * Remove unused var. * Update SslCertificateTest.php Remove useless semicolon * Update README.md Fix typo for SslCertificate::getPublicKeySize()
1 parent 2a138e8 commit 9b8e39f

File tree

4 files changed

+3
-4
lines changed

4 files changed

+3
-4
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ $certificate->lifespanInDays(); // return the amount of days between validFromDa
3030
$certificate->getIssuer(); // returns "Let's Encrypt Authority X3"
3131
$certificate->getOrganization(); // returns the organization name when available
3232
$certificate->getPublicKeyAlgorithm(); // returns the public key algorithm
33-
$certificate->getPublicKeySize(); // returns the public key algorithm
33+
$certificate->getPublicKeySize(); // returns the public key size
3434
$certificate->getSignatureAlgorithm(); // returns the signature algorithm
3535
```
3636

tests/DownloaderTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
->throws(UnknownError::class);
9797

9898
it('throws an exception when downloading a certificate for a missing host name from an ip address', function () {
99-
$sslCertificate = SslCertificate::download()
99+
SslCertificate::download()
100100
->fromIpAddress('138.197.187.74')
101101
->forHost('fake.subdomain.spatie.be');
102102
})->throws(UnknownError::class);

tests/SslCertificateSerializationTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
});
1212

1313
it('can json encode serialized certificate', function () {
14-
$json = json_encode(
14+
json_encode(
1515
serialize(SslCertificate::createFromFile(__DIR__ . '/stubs/spatieCertificate.pem'))
1616
);
1717

tests/SslCertificateTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060
it('can determine the valid from date')
6161
->expect(fn () => $this->certificate->validFromDate())->toBeInstanceOf(Carbon::class)
6262
->and(fn () => $this->certificate->validFromDate()->format('Y-m-d H:i:s'))->toEqual('2016-05-19 16:50:00');
63-
;
6463

6564
it('can determine the lifespan in days')
6665
->expect(fn () => $this->certificate->lifespanInDays())->toEqual(90);

0 commit comments

Comments
 (0)