Skip to content

Commit ce70b62

Browse files
authored
Fix implicitly marking parameter deprecation (#193)
1 parent 17b2382 commit ce70b62

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/SslCertificate.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ public function isExpired(): bool
170170
return $this->expirationDate()->isPast();
171171
}
172172

173-
public function isValid(string $url = null): bool
173+
public function isValid(?string $url = null): bool
174174
{
175175
if (! Carbon::now()->between($this->validFromDate(), $this->expirationDate())) {
176176
return false;
@@ -203,7 +203,7 @@ public function usesSha1Hash(): bool
203203
return false;
204204
}
205205

206-
public function isValidUntil(Carbon $carbon, string $url = null): bool
206+
public function isValidUntil(Carbon $carbon, ?string $url = null): bool
207207
{
208208
if ($this->expirationDate()->lte($carbon)) {
209209
return false;

0 commit comments

Comments
 (0)