feat: review-mode workflow and fix review gate edge cases (#26)

* docs: review mode plan

* feat: add review mode workflow and fix review gate edge cases

* fix: clippy warnings

* feat: add review mode workflow and release notes

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: danielkov

.boop/changelogs/minor-01kk44gh4hy49mssbgmpxvvh2p.md

@@ -0,0 +1,29 @@
+### Review mode workflow
+
+Granary now supports an optional review gate in the task and project lifecycle. When enabled, completed work transitions to `in_review` instead of going straight to `done`/`completed`, giving a reviewer (human or agent) the chance to approve or reject it before it's finalized.
+
+**Two scopes:**
+
+- **`task` mode** — `granary work done` moves the task to `in_review` and emits a `task.review` event. A reviewer approves or rejects individual tasks.
+- **`project` mode** — Tasks still complete normally, but when all tasks are done, the project enters `in_review` instead of `completed`. Reviewers approve the project as a whole, or reject it by creating follow-up tasks and reopening the project.
+
+**New `granary review` command:**
+
+- `granary review <id>` — displays reviewer context (task/project details, comments, suggested actions)
+- `granary review <id> approve ["comment"]` — approves and completes the entity
+- `granary review <id> reject "feedback"` — rejects with feedback; tasks return to `todo`, projects reopen to `active` with draft tasks promoted to `todo`
+
+Review comments use a new `review` comment kind, and review events (`task.review`, `project.review`) are emitted so downstream agents or integrations can react.
+
+### Review mode configuration
+
+Review mode is stored in the workspace database (`config` table) under the key `workflow.review_mode`. Enable it with:
+
+```
+granary config set workflow.review_mode task    # or 'project'
+granary config unset workflow.review_mode       # disable
+```
+
+### Updated SQL triggers
+
+The `trg_project_auto_complete` trigger is now config-aware — when `workflow.review_mode` is set to `project`, it transitions the project to `in_review` instead of `completed`. New triggers emit `task.review` and `project.review` events on status transitions.

AGENTS.md

@@ -1,5 +1,9 @@
 # Agent Instructions
 
+## Formatting
+
+After implementation is complete, use `cargo fmt` to format files. Always run `cargo clippy` before committing to ensure there are no warnings or errors.
+
 ## SQL Migrations
 
 - Always create migrations via SQLx CLI from the repo root:

CLAUDE.md

@@ -1,15 +1,19 @@
-After implementation is complete, use `cargo fmt` to format files.
+# Agent Instructions
 
-IMPORTANT: when user requests to "use granary", run `granary` command before performing any other task.
+## Formatting
+
+After implementation is complete, use `cargo fmt` to format files. Always run `cargo clippy` before committing to ensure there are no warnings or errors.
+
+## SQL Migrations
 
-## Iced GUI Development
+- Always create migrations via SQLx CLI from the repo root:
+  - `sqlx migrate add <name>`
+- Do not hand-write timestamp/version prefixes in migration filenames.
+- If you hit a duplicate migration version error, regenerate one migration with `sqlx migrate add <name>` and move the SQL into the newly generated file.
 
-The `crates/silo/` crate uses the Iced GUI library. When working on files in this crate, the `.claude/skills/iced-development.md` skill is automatically applied. It contains best practices for:
+## Build Guard
 
-- Application architecture (Elm Architecture / MVU)
-- Message enum patterns
-- State management
-- Styling and theming
-- Component composition
-- Async operations with Tasks
-- Subscriptions for background events
+- This repo has a build-time check in `build.rs` that fails compilation when two migration files share the same numeric version prefix.
+- Treat that failure as a naming/version collision and regenerate one of the conflicting migrations.
+
+IMPORTANT: when user requests to "use granary", run `granary` command before performing any other task.

crates/granary-types/src/comment.rs

@@ -15,6 +15,7 @@ pub enum CommentKind {
     Handoff,
     Incident,
     Context,
+    Review,
 }
 
 impl CommentKind {
@@ -27,6 +28,7 @@ impl CommentKind {
             CommentKind::Handoff => "handoff",
             CommentKind::Incident => "incident",
             CommentKind::Context => "context",
+            CommentKind::Review => "review",
         }
     }
 
@@ -39,6 +41,7 @@ impl CommentKind {
             CommentKind::Handoff,
             CommentKind::Incident,
             CommentKind::Context,
+            CommentKind::Review,
         ]
     }
 }
@@ -61,6 +64,7 @@ impl std::str::FromStr for CommentKind {
             "handoff" => Ok(CommentKind::Handoff),
             "incident" => Ok(CommentKind::Incident),
             "context" => Ok(CommentKind::Context),
+            "review" => Ok(CommentKind::Review),
             _ => Err(()),
         }
     }

crates/granary-types/src/event.rs

@@ -13,12 +13,14 @@ pub enum EventType {
     ProjectCompleted,
     ProjectArchived,
     ProjectUnarchived,
+    ProjectReview,
 
     // Task events
     TaskCreated,
     TaskUpdated,
     TaskStarted,
     TaskCompleted,
+    TaskReview,
     TaskBlocked,
     TaskUnblocked,
     TaskClaimed,
@@ -60,10 +62,12 @@ impl EventType {
             EventType::ProjectCompleted => "project.completed".to_string(),
             EventType::ProjectArchived => "project.archived".to_string(),
             EventType::ProjectUnarchived => "project.unarchived".to_string(),
+            EventType::ProjectReview => "project.review".to_string(),
             EventType::TaskCreated => "task.created".to_string(),
             EventType::TaskUpdated => "task.updated".to_string(),
             EventType::TaskStarted => "task.started".to_string(),
             EventType::TaskCompleted => "task.completed".to_string(),
+            EventType::TaskReview => "task.review".to_string(),
             EventType::TaskBlocked => "task.blocked".to_string(),
             EventType::TaskUnblocked => "task.unblocked".to_string(),
             EventType::TaskClaimed => "task.claimed".to_string(),
@@ -97,10 +101,12 @@ impl std::str::FromStr for EventType {
             "project.completed" => EventType::ProjectCompleted,
             "project.archived" => EventType::ProjectArchived,
             "project.unarchived" => EventType::ProjectUnarchived,
+            "project.review" => EventType::ProjectReview,
             "task.created" => EventType::TaskCreated,
             "task.updated" => EventType::TaskUpdated,
             "task.started" => EventType::TaskStarted,
             "task.completed" => EventType::TaskCompleted,
+            "task.review" => EventType::TaskReview,
             "task.blocked" => EventType::TaskBlocked,
             "task.unblocked" => EventType::TaskUnblocked,
             "task.claimed" => EventType::TaskClaimed,

crates/granary-types/src/project.rs

@@ -9,6 +9,7 @@ use sqlx::FromRow;
 pub enum ProjectStatus {
     #[default]
     Active,
+    InReview,
     Completed,
     Archived,
 }
@@ -17,6 +18,7 @@ impl ProjectStatus {
     pub fn as_str(&self) -> &'static str {
         match self {
             ProjectStatus::Active => "active",
+            ProjectStatus::InReview => "in_review",
             ProjectStatus::Completed => "completed",
             ProjectStatus::Archived => "archived",
         }
@@ -26,6 +28,10 @@ impl ProjectStatus {
         matches!(self, ProjectStatus::Active)
     }
 
+    pub fn is_in_review(&self) -> bool {
+        matches!(self, ProjectStatus::InReview)
+    }
+
     pub fn is_completed(&self) -> bool {
         matches!(self, ProjectStatus::Completed)
     }
@@ -43,6 +49,7 @@ impl std::str::FromStr for ProjectStatus {
     fn from_str(s: &str) -> Result<Self, Self::Err> {
         match s.to_lowercase().as_str() {
             "active" => Ok(ProjectStatus::Active),
+            "in_review" | "in-review" | "inreview" => Ok(ProjectStatus::InReview),
             "completed" => Ok(ProjectStatus::Completed),
             "archived" => Ok(ProjectStatus::Archived),
             _ => Err(()),

crates/granary-types/src/task.rs

@@ -115,6 +115,7 @@ pub enum TaskStatus {
     Draft,
     Todo,
     InProgress,
+    InReview,
     Done,
     Blocked,
 }
@@ -125,6 +126,7 @@ impl TaskStatus {
             TaskStatus::Draft => "draft",
             TaskStatus::Todo => "todo",
             TaskStatus::InProgress => "in_progress",
+            TaskStatus::InReview => "in_review",
             TaskStatus::Done => "done",
             TaskStatus::Blocked => "blocked",
         }
@@ -142,6 +144,10 @@ impl TaskStatus {
         matches!(self, TaskStatus::InProgress)
     }
 
+    pub fn is_in_review(&self) -> bool {
+        matches!(self, TaskStatus::InReview)
+    }
+
     pub fn is_draft(&self) -> bool {
         matches!(self, TaskStatus::Draft)
     }
@@ -161,6 +167,7 @@ impl std::str::FromStr for TaskStatus {
             "draft" => Ok(TaskStatus::Draft),
             "todo" => Ok(TaskStatus::Todo),
             "in_progress" | "in-progress" | "inprogress" => Ok(TaskStatus::InProgress),
+            "in_review" | "in-review" | "inreview" => Ok(TaskStatus::InReview),
             "done" | "completed" => Ok(TaskStatus::Done),
             "blocked" => Ok(TaskStatus::Blocked),
             _ => Err(()),

crates/silo/src/screen/edit_task.rs

@@ -168,6 +168,7 @@ fn view_form<'a>(state: &EditTaskScreenState<'a>, palette: &'a Palette) -> Eleme
         TaskStatus::Draft,
         TaskStatus::Todo,
         TaskStatus::InProgress,
+        TaskStatus::InReview,
         TaskStatus::Done,
         TaskStatus::Blocked,
     ];

crates/silo/src/screen/main_screen.rs

@@ -737,6 +737,9 @@ fn view_task_row<'a>(
                     palette,
                 ));
             }
+            TaskStatus::InReview => {
+                // In review - no quick actions from GUI
+            }
             TaskStatus::Blocked => {
                 action_btns.push(widget::action_button(
                     "Unblock",
@@ -790,6 +793,10 @@ fn view_task_row<'a>(
             TaskStatus::InProgress => {
                 widget::action_button("Done", Message::CompleteTask(task_id.clone()), palette)
             }
+            TaskStatus::InReview => text("in review")
+                .size(11)
+                .color(palette.status_progress)
+                .into(),
             TaskStatus::Done => {
                 widget::action_button("Re-open", Message::ReopenTask(task_id.clone()), palette)
             }

crates/silo/src/screen/project_detail.rs

@@ -486,6 +486,7 @@ fn view_task_row<'a>(
     let (status_color, status_label): (Color, &'static str) = match status {
         TaskStatus::Done => (palette.status_done, "done"),
         TaskStatus::InProgress => (palette.status_progress, "in progress"),
+        TaskStatus::InReview => (palette.status_progress, "in review"),
         TaskStatus::Blocked => (palette.status_blocked, "blocked"),
         TaskStatus::Draft => (palette.text_muted, "draft"),
         TaskStatus::Todo => (palette.status_todo, "todo"),