fix: convert references to absolute paths for proper parent directory handling and deduplication (#58)

Author: TristanSpeakEasy

.mise.toml

@@ -7,7 +7,8 @@ gotestsum = "latest"
 description = "Create VSCode symlinks for tools not automatically handled by mise-vscode"
 run = [
   "mkdir -p .vscode/mise-tools",
-  "ln -sf $(mise exec [email protected] -- which golangci-lint) .vscode/mise-tools/golangci-lint",
+  "ln -sf $(mise exec -- which golangci-lint-v2) $(dirname $(mise exec -- which golangci-lint-v2))/golangci-lint || true",
+  "ln -sf $(mise exec -- which golangci-lint) .vscode/mise-tools/golangci-lint",
 ]
 
 [hooks]

internal/utils/references.go

@@ -148,7 +148,8 @@ func (rc *ReferenceClassification) JoinWith(relative string) (string, error) {
 	}
 
 	if rc.IsFile {
-		return rc.joinFilePath(relative)
+		joined := rc.joinFilePath(relative)
+		return joined, nil
 	}
 
 	// If base is a fragment, treat relative as the new reference
@@ -157,7 +158,8 @@ func (rc *ReferenceClassification) JoinWith(relative string) (string, error) {
 	}
 
 	// Fallback: treat as file path
-	return rc.joinFilePath(relative)
+	joined := rc.joinFilePath(relative)
+	return joined, nil
 }
 
 // joinURL joins this URL reference with a relative reference using the cached ParsedURL
@@ -185,11 +187,11 @@ func (rc *ReferenceClassification) joinURL(relative string) (string, error) {
 }
 
 // joinFilePath joins this file path reference with a relative path using cross-platform path handling
-func (rc *ReferenceClassification) joinFilePath(relative string) (string, error) {
+func (rc *ReferenceClassification) joinFilePath(relative string) string {
 	// If relative path is absolute, return it as-is
 	// Check for both OS-specific absolute paths and Unix-style absolute paths (for cross-platform compatibility)
 	if filepath.IsAbs(relative) || strings.HasPrefix(relative, "/") || rc.isWindowsAbsolutePath(relative) {
-		return relative, nil
+		return relative
 	}
 
 	// Determine the path separator style from the original path
@@ -217,7 +219,7 @@ func (rc *ReferenceClassification) joinFilePath(relative string) (string, error)
 		joined = strings.ReplaceAll(joined, "\\", "/")
 	}
 
-	return joined, nil
+	return joined
 }
 
 // getWindowsDir extracts the directory part from a Windows-style path

internal/utils/references_windows_test.go

@@ -10,6 +10,8 @@ import (
 )
 
 func TestWindowsPathClassification_Success(t *testing.T) {
+	t.Parallel()
+
 	tests := []struct {
 		name               string
 		windowsPath        string
@@ -46,6 +48,7 @@ func TestWindowsPathClassification_Success(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			classification, err := ClassifyReference(tt.windowsPath)
 			require.NoError(t, err)
 			require.NotNil(t, classification)
@@ -60,6 +63,8 @@ func TestWindowsPathClassification_Success(t *testing.T) {
 }
 
 func TestWindowsPathJoining_Success(t *testing.T) {
+	t.Parallel()
+
 	tests := []struct {
 		name     string
 		base     string
@@ -87,8 +92,8 @@ func TestWindowsPathJoining_Success(t *testing.T) {
 		{
 			name:     "windows path with absolute relative path",
 			base:     "C:\\path\\to\\schemas\\user.json",
-			relative: "D:\\other\\path\\schema.json",
-			expected: "D:\\other\\path\\schema.json",
+			relative: "D:\\some\\path\\schema.json",
+			expected: "D:\\some\\path\\schema.json",
 		},
 		{
 			name:     "windows path with fragment",
@@ -100,6 +105,7 @@ func TestWindowsPathJoining_Success(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			classification, err := ClassifyReference(tt.base)
 			require.NoError(t, err)
 			require.NotNil(t, classification)
@@ -113,6 +119,8 @@ func TestWindowsPathJoining_Success(t *testing.T) {
 }
 
 func TestWindowsPathJoinReference_Success(t *testing.T) {
+	t.Parallel()
+
 	tests := []struct {
 		name     string
 		base     string
@@ -135,6 +143,7 @@ func TestWindowsPathJoinReference_Success(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			result, err := JoinReference(tt.base, tt.relative)
 			require.NoError(t, err)
 			assert.Equal(t, tt.expected, result)