fix: passing no options to jsonpointer.GetTarget()

TristanSpeakEasy · TristanSpeakEasy · commit 9d7acca1cb01 · 2025-02-28T09:35:07.000+10:00
diff --git a/jsonpointer/jsonpointer.go b/jsonpointer/jsonpointer.go
@@ -37,7 +37,7 @@ func WithStructTags(structTags ...string) option {
 	}
 }
 
-func getOptions(opts ...option) *options {
+func getOptions(opts []option) *options {
 	o := &options{
 		StructTags: []string{DefaultStructTag},
 	}
@@ -63,7 +63,7 @@ func (j JSONPointer) Validate() error {
 // WithStructTags can be used to set the type of struct tags to use when navigating structs.
 // If the struct implements any of the Navigable interfaces it will be used to navigate the source.
 func GetTarget(source any, pointer JSONPointer, opts ...option) (any, error) {
-	o := getOptions(opts...)
+	o := getOptions(opts)
 
 	stack, err := pointer.getNavigationStack()
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ func WithStructTags(structTags ...string) option {`
`37`	`37`	`}`
`38`	`38`	`}`
`39`	`39`
`40`		`-func getOptions(opts ...option) *options {`
	`40`	`+func getOptions(opts []option) *options {`
`41`	`41`	`o := &options{`
`42`	`42`	`StructTags: []string{DefaultStructTag},`
`43`	`43`	`}`
`@@ -63,7 +63,7 @@ func (j JSONPointer) Validate() error {`
`63`	`63`	`// WithStructTags can be used to set the type of struct tags to use when navigating structs.`
`64`	`64`	`// If the struct implements any of the Navigable interfaces it will be used to navigate the source.`
`65`	`65`	`func GetTarget(source any, pointer JSONPointer, opts ...option) (any, error) {`
`66`		`- o := getOptions(opts...)`
	`66`	`+ o := getOptions(opts)`
`67`	`67`
`68`	`68`	`stack, err := pointer.getNavigationStack()`
`69`	`69`	`if err != nil {`