Skip to content

Commit f8324c1

Browse files
committed
Always surface ui_error alerts, including in fullscreen
ui_error_specific swallowed every error when settings_current.full_screen was set, returning 0 without ever calling aqua_verror. That made runtime errors during fullscreen play invisible: RZX desync, disk read failures on a mounted image, tape malformed-block during playback of a tape mounted before fullscreen, Spectranet socket failures, sound device hot-unplug — all silently dropped. macOS native fullscreen overlays alerts on the fullscreen Space the way it handles any other fullscreen app, so the original concern (panel hidden under the borderless overlay) no longer applies. Distraction-free is the OS's job via the menu-bar auto-hide; a malfunction is not the happy path.
1 parent bca1c5e commit f8324c1

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

ui/cocoa/cocoaerror.m

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737

3838
#include "fuse.h"
3939
#include "ui/ui.h"
40-
#include "settings.h"
4140

4241
static int
4342
aqua_verror( ui_error_level severity, const char *message )
@@ -66,8 +65,5 @@
6665
int
6766
ui_error_specific( ui_error_level severity, const char *message )
6867
{
69-
if ( !settings_current.full_screen ) {
70-
return aqua_verror( severity, message );
71-
}
72-
return 0;
68+
return aqua_verror( severity, message );
7369
}

0 commit comments

Comments
 (0)