Extract GetAllFiltered helper into BaseTool to reduce duplication

Agent-Logs-Url: https://github.com/spech66/lifelogbb/sessions/7b1fa04c-5ab2-4714-a060-adcc15f7ffc7

Co-authored-by: spech66 <22615238+spech66@users.noreply.github.com>

Author: Copilot

LifelogBb/McpControllers/BaseTool.cs

@@ -6,13 +6,21 @@
 namespace LifelogBb.McpControllers
 {
     [McpServerToolType]
-    public class BaseTool<S, INP, OUTP>
+    public class BaseTool<S, INP, OUTP> where S : IBaseCRUDService<INP, OUTP>
     {
         protected readonly S _service;
 
         public BaseTool(S service)
         {
             _service = service;
         }
+
+        protected async Task<IEnumerable<OUTP>> GetAllFiltered(string? filter)
+        {
+            var result = filter != null
+                ? await _service.GetAll(filter)
+                : await _service.GetAll();
+            return result.Value ?? [];
+        }
     }
 }

LifelogBb/McpControllers/EnduranceTrainingsTool.cs

@@ -15,10 +15,7 @@ public EnduranceTrainingsTool(EnduranceTrainingsService service) : base(service)
         [McpServerTool(Name = "GetAllEnduranceTrainings", Title = "Get All Endurance Trainings"), Description("Get all endurance training data. Optionally filter by providing a JSON filter expression.")]
         public async Task<IEnumerable<EnduranceTrainingOutput>> McpGetAll([Description("Optional JSON filter expression")] string? filter = null)
         {
-            var result = filter != null
-                ? await _service.GetAll(filter)
-                : await _service.GetAll();
-            return result.Value ?? [];
+            return await GetAllFiltered(filter);
         }
     }
 }

LifelogBb/McpControllers/GoalsTool.cs

@@ -15,10 +15,7 @@ public GoalsTool(GoalsService service) : base(service)
         [McpServerTool(Name = "GetAllGoals", Title = "Get All Goals"), Description("Get all goal data. Optionally filter by providing a JSON filter expression.")]
         public async Task<IEnumerable<GoalOutput>> McpGetAll([Description("Optional JSON filter expression")] string? filter = null)
         {
-            var result = filter != null
-                ? await _service.GetAll(filter)
-                : await _service.GetAll();
-            return result.Value ?? [];
+            return await GetAllFiltered(filter);
         }
     }
 }

LifelogBb/McpControllers/HabitsTool.cs

@@ -15,10 +15,7 @@ public HabitsTool(HabitsService service) : base(service)
         [McpServerTool(Name = "GetAllHabits", Title = "Get All Habits"), Description("Get all habit data. Optionally filter by providing a JSON filter expression.")]
         public async Task<IEnumerable<HabitOutput>> McpGetAll([Description("Optional JSON filter expression")] string? filter = null)
         {
-            var result = filter != null
-                ? await _service.GetAll(filter)
-                : await _service.GetAll();
-            return result.Value ?? [];
+            return await GetAllFiltered(filter);
         }
     }
 }

LifelogBb/McpControllers/JournalsTool.cs

@@ -15,10 +15,7 @@ public JournalsTool(JournalsService service) : base(service)
         [McpServerTool(Name = "GetAllJournals", Title = "Get All Journals"), Description("Get all journal data. Optionally filter by providing a JSON filter expression.")]
         public async Task<IEnumerable<JournalOutput>> McpGetAll([Description("Optional JSON filter expression")] string? filter = null)
         {
-            var result = filter != null
-                ? await _service.GetAll(filter)
-                : await _service.GetAll();
-            return result.Value ?? [];
+            return await GetAllFiltered(filter);
         }
     }
 }

LifelogBb/McpControllers/QuotesTool.cs

@@ -15,10 +15,7 @@ public QuotesTool(QuotesService service) : base(service)
         [McpServerTool(Name = "GetAllQuotes", Title = "Get All Quotes"), Description("Get all quote data. Optionally filter by providing a JSON filter expression.")]
         public async Task<IEnumerable<QuoteOutput>> McpGetAll([Description("Optional JSON filter expression")] string? filter = null)
         {
-            var result = filter != null
-                ? await _service.GetAll(filter)
-                : await _service.GetAll();
-            return result.Value ?? [];
+            return await GetAllFiltered(filter);
         }
     }
 }

LifelogBb/McpControllers/StrengthTrainingsTool.cs

@@ -15,10 +15,7 @@ public StrengthTrainingsTool(StrengthTrainingsService service) : base(service)
         [McpServerTool(Name = "GetAllStrengthTrainings", Title = "Get All Strength Trainings"), Description("Get all strength training data. Optionally filter by providing a JSON filter expression.")]
         public async Task<IEnumerable<StrengthTrainingOutput>> McpGetAll([Description("Optional JSON filter expression")] string? filter = null)
         {
-            var result = filter != null
-                ? await _service.GetAll(filter)
-                : await _service.GetAll();
-            return result.Value ?? [];
+            return await GetAllFiltered(filter);
         }
     }
 }

LifelogBb/McpControllers/TodosTool.cs

@@ -15,10 +15,7 @@ public TodosTool(TodosService service) : base(service)
         [McpServerTool(Name = "GetAllTodos", Title = "Get All Todos"), Description("Get all todo data. Optionally filter by providing a JSON filter expression.")]
         public async Task<IEnumerable<TodoOutput>> McpGetAll([Description("Optional JSON filter expression")] string? filter = null)
         {
-            var result = filter != null
-                ? await _service.GetAll(filter)
-                : await _service.GetAll();
-            return result.Value ?? [];
+            return await GetAllFiltered(filter);
         }
     }
 }

LifelogBb/McpControllers/WeightsTool.cs

@@ -15,10 +15,7 @@ public WeightsTool(WeightsService service) : base(service)
         [McpServerTool(Name = "GetAllWeights", Title = "Get All Weights"), Description("Get all weight data. Optionally filter by providing a JSON filter expression.")]
         public async Task<IEnumerable<WeightOutput>> McpGetAll([Description("Optional JSON filter expression")] string? filter = null)
         {
-            var result = filter != null
-                ? await _service.GetAll(filter)
-                : await _service.GetAll();
-            return result.Value ?? [];
+            return await GetAllFiltered(filter);
         }
 
         [McpServerTool(Name = "CreateWeight", Title = "Create weight entry"), Description("Create a new weight entry")]