Skip to content

Bring configuration files from maxpatiiuk's dotfiles into Specify respository #7402

@mark-pitblado

Description

@mark-pitblado

I think it would make sense to bring the current configuration settings for tools such as prettier, pre-commit, jscpd into the Specify orgnaization/repo. I have a huge amount of respect for Max, I hope that this would also make his life easier by reducing things he has to worry about if he changes his dotfiles.

For example, the current prettier.config.js imports the following lines via

import base from '@maxpatiiuk/prettier-config';
/**
 * @see https://prettier.io/docs/en/configuration.html
 * @type {import("prettier").Config}
 */
const config = {
  // Single quote is more popular among JS libraries
  singleQuote: true,
  // GitHub renders Markdown in whitespace-insensitive way, so we should wrap prose
  proseWrap: 'always',
  plugins: [
    '@prettier/plugin-xml',
    'prettier-plugin-package',
    'prettier-plugin-sh',
    'prettier-plugin-tailwindcss',
  ],
};

export default config;

To see that the singleQuotes: true are part of the configuration, a developer has to do some digging. Instead, we could just move these lines into the config file already in the repository to reduce the number of places the code is. I don't see Specify needing to change anything about the files themselves, however, if a change is made, that only highlights why it would be beneficial here so the diffs can be better tracked.

Open to objections if there is a reason these should stay the way they are!

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions