Inconsistent preserving of trailing period in help descriptions

[TheTonttu]

Information

• OS: Windows 10 22H2 (build 19045.5247)
• Version: 0.49.1
• Terminal: Windows Terminal

Describe the bug
When IConfigurator.TrimTrailingPeriods(false), trailing periods in the command descriptions are preserved but not in the argument or option descriptions.

To Reproduce
Run the below application dotnet run -- example --help and see the output.

Application

using Spectre.Console.Cli;
using System.ComponentModel;

internal sealed class Program
{
    private static int Main(string[] args)
    {
        var app = new CommandApp();

        app.Configure(cfg =>
        {
            cfg.TrimTrailingPeriods(false);
            cfg.AddCommand<ExampleCommand>("example");
        });

        return app.Run(args);
    }
}

[Description("Example command description with trailing period. Trailing period is preserved as expected.")]
internal sealed class ExampleCommand : Command<ExampleCommandSettings>
{
    public override int Execute(CommandContext context, ExampleCommandSettings settings)
    {
        return 0;
    }
}

internal sealed class ExampleCommandSettings : CommandSettings
{
    [CommandArgument(0, "<EXAMPLE>")]
    [Description("Example argument description with trailing period. Looks silly when trailing period is removed from description with multiple sentences.")]
    public string ExampleArgument { get; set; } = string.Empty;

    [CommandOption("-e|--example <VALUE>")]
    [Description("""
        Example option description with trailing period.
        
        Looks silly when trailing period is removed from multiline description.
        """)]
    public string ExampleOption { get; set; } = string.Empty;
}

Output

DESCRIPTION:
Example command description with trailing period. Trailing period is preserved as expected.

USAGE:
    TrailingPeriodTrimming.dll example <EXAMPLE> [OPTIONS]

ARGUMENTS:
    <EXAMPLE>    Example argument description with trailing period. Looks silly when trailing period is removed from
                 description with multiple sentences

OPTIONS:
    -h, --help               Prints help information
    -e, --example <VALUE>    Example option description with trailing period.

                             Looks silly when trailing period is removed from multiline description

Expected behavior
Trailing period is preserved in all descriptions when IConfigurator.TrimTrailingPeriods(false).

---

Please upvote 👍 this issue if you are interested in it.

[TheTonttu]

If you don't mind I could take a look at this? It seems to be a minor oversight in the HelpProvider implementation.

[FrankRay78]

Hello @TheTonttu, I would be happy to review/merge any PR you submit for this issue. I ported the old help provider into the current format and it wasn't exactly how I wanted it at the time.

[TheTonttu]

Thanks @FrankRay78, I'll try to submit a PR sometime this week.