PCP-4653: Node pool customization not working without specifying AMI ID (#970)

AmitSahastra · web-flow · commit c3dfe72b6bea · 2025-06-05T16:10:57.000+05:30
diff --git a/pkg/cloud/services/eks/nodegroup.go b/pkg/cloud/services/eks/nodegroup.go
@@ -222,7 +222,10 @@ func (s *NodegroupService) createNodegroup() (*eks.Nodegroup, error) {
 		RemoteAccess:  remoteAccess,
 		UpdateConfig:  s.updateConfig(),
 	}
-	if managedPool.AMIType != nil && (managedPool.AWSLaunchTemplate == nil || managedPool.AWSLaunchTemplate.AMI.ID == nil) {
+
+	// Palette have all input for nodepool customization as optionsl.
+	// Allow creating AWS launch templates without specifying an AMI ID. CAPA will do lookup for the AMI ID.
+	if managedPool.AMIType != nil && (managedPool.AWSLaunchTemplate == nil /*|| managedPool.AWSLaunchTemplate.AMI.ID == nil*/) {
 		input.AmiType = aws.String(string(*managedPool.AMIType))
 	}
 	if managedPool.DiskSize != nil {

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,10 @@ func (s NodegroupService) createNodegroup() (eks.Nodegroup, error) {`
`222`	`222`	`RemoteAccess: remoteAccess,`
`223`	`223`	`UpdateConfig: s.updateConfig(),`
`224`	`224`	`}`
`225`		`- if managedPool.AMIType != nil && (managedPool.AWSLaunchTemplate == nil \|\| managedPool.AWSLaunchTemplate.AMI.ID == nil) {`
	`225`	`+`
	`226`	`+ // Palette have all input for nodepool customization as optionsl.`
	`227`	`+ // Allow creating AWS launch templates without specifying an AMI ID. CAPA will do lookup for the AMI ID.`
	`228`	`+ if managedPool.AMIType != nil && (managedPool.AWSLaunchTemplate == nil /\|\| managedPool.AWSLaunchTemplate.AMI.ID == nil/) {`
`226`	`229`	`input.AmiType = aws.String(string(*managedPool.AMIType))`
`227`	`230`	`}`
`228`	`231`	`if managedPool.DiskSize != nil {`