combine: use instanceID for providerID comparision

pavansokkenagaraj · pavansokkenagaraj · commit 4d18d9d8bc7b · 2025-01-23T05:24:41.000Z
diff --git a/exp/internal/controllers/machinepool_controller_noderef.go b/exp/internal/controllers/machinepool_controller_noderef.go
@@ -184,7 +184,7 @@ func (r *MachinePoolReconciler) getNodeReferences(ctx context.Context, c client.
 				continue
 			}
 
-			nodeRefsMap[nodeProviderID.String()] = node
+			nodeRefsMap[nodeProviderID.ID()] = node
 		}
 
 		if nodeList.Continue == "" {
@@ -199,7 +199,7 @@ func (r *MachinePoolReconciler) getNodeReferences(ctx context.Context, c client.
 			log.V(2).Info("Failed to parse ProviderID, skipping", "err", err, "providerID", providerID)
 			continue
 		}
-		if node, ok := nodeRefsMap[pid.String()]; ok {
+		if node, ok := nodeRefsMap[pid.ID()]; ok {
 			available++
 			if nodeIsReady(&node) {
 				ready++

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ func (r *MachinePoolReconciler) getNodeReferences(ctx context.Context, c client.`
`184`	`184`	`continue`
`185`	`185`	`}`
`186`	`186`
`187`		`- nodeRefsMap[nodeProviderID.String()] = node`
	`187`	`+ nodeRefsMap[nodeProviderID.ID()] = node`
`188`	`188`	`}`
`189`	`189`
`190`	`190`	`if nodeList.Continue == "" {`
`@@ -199,7 +199,7 @@ func (r *MachinePoolReconciler) getNodeReferences(ctx context.Context, c client.`
`199`	`199`	`log.V(2).Info("Failed to parse ProviderID, skipping", "err", err, "providerID", providerID)`
`200`	`200`	`continue`
`201`	`201`	`}`
`202`		`- if node, ok := nodeRefsMap[pid.String()]; ok {`
	`202`	`+ if node, ok := nodeRefsMap[pid.ID()]; ok {`
`203`	`203`	`available++`
`204`	`204`	`if nodeIsReady(&node) {`
`205`	`205`	`ready++`