Skip to content

Commit c2cc9d4

Browse files
Merge pull request #5 from spectrocloud/env-bug
fix: updated bug related to REVERSE_PROXY env var
2 parents ff84911 + 622c72d commit c2cc9d4

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ Hello Universe is available as a Docker image.
1616
To run Hello Universe issue the following commands:
1717

1818
```shell
19-
docker pull ghcr.io/spectrocloud/hello-universe:1.0.5
20-
docker run -p 8080:8080 ghcr.io/spectrocloud/hello-universe:1.0.5
19+
docker pull ghcr.io/spectrocloud/hello-universe:1.0.6
20+
docker run -p 8080:8080 ghcr.io/spectrocloud/hello-universe:1.0.6
2121
```
2222

2323
## Non-Docker
@@ -54,7 +54,7 @@ API_URI=http://localhost:3000
5454
If you are using the Docker image then use the `-e` flag parameter.
5555

5656
```shell
57-
docker run -p 8080:8080 -e API_URI=http://localhost:3000 ghcr.io/spectrocloud/hello-universe:1.0.5
57+
docker run -p 8080:8080 -e API_URI=http://localhost:3000 ghcr.io/spectrocloud/hello-universe:1.0.6
5858
```
5959

6060
### Reverse Proxy
@@ -63,7 +63,7 @@ A Docker container with a reverse proxy for `http://0.0.0.0:3000` is available.
6363
hello universe application into a Kubernetes cluster or similar architectures and need the UI to route requests internal to the hosting platform. An example of such behavior is needing to to reach a private API inside the Kubernetes cluster. **The reverse proxy expects the API to be listening on port `3000`.**
6464

6565
```shell
66-
docker run -p 8080:8080 -p 3000:3000 -e API_URI="http://myprivate.api.address.example:3000" ghcr.io/spectrocloud/hello-universe:1.0.5-proxy
66+
docker run -p 8080:8080 -p 3000:3000 -e API_URI="http://myprivate.api.address.example:3000" ghcr.io/spectrocloud/hello-universe:1.0.6-proxy
6767
```
6868

6969
# Development

src/App.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ function App() {
2626
API_URI = ""
2727
}
2828

29-
if (REVERSE_PROXY) {
29+
if (REVERSE_PROXY === "true") {
3030
API_URI = "http://0.0.0.0:3000"
3131
}
3232

0 commit comments

Comments
 (0)