CloudCasa 1.3.0 #116
CloudCasa 1.3.0 #116
Conversation
|
Can someone approve? |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new pack for the CloudCasa Agent 1.3.0, including configuration settings, pack metadata, and documentation for usage.
- Introduces a YAML configuration file with deployment parameters.
- Adds pack metadata in a JSON file with relevant versioning and chart information.
- Provides a README that details prerequisites, usage instructions, and parameter descriptions.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packs/cloudcasa-3.1.0/values.yaml | Adds configuration for namespace and chart parameters. |
| packs/cloudcasa-3.1.0/pack.json | Provides metadata including version, contributor, and chart reference. |
| packs/cloudcasa-3.1.0/README.md | Documents prerequisites, parameters, and setup instructions. |
| "layer": "addon", | ||
| "addonType": "system app", | ||
| "cloudTypes": [ "all" ], | ||
| "charts": [ "charts/cloudcasa-3.4.4.tgz" ] |
There was a problem hiding this comment.
The chart file name 'cloudcasa-3.4.4.tgz' does not match the pack version '3.1.0'. Please verify and update the chart reference to ensure consistency.
| "charts": [ "charts/cloudcasa-3.4.4.tgz" ] | |
| "charts": [ "charts/cloudcasa-3.1.0.tgz" ] |
There was a problem hiding this comment.
Should these versions match?
There was a problem hiding this comment.
No, our agent and our Helm chart are versioned separately.
packs/cloudcasa-3.1.0/README.md
Outdated
| ## Parameters | ||
|
|
||
| To deploy the CloudCasa agent, you **must** set the `clusterID` parameter to the Cluster ID provided by CloudCasa. | ||
| All other parmeters are optional or can be left at their default values. |
There was a problem hiding this comment.
The word 'parmeters' appears to be misspelled. Consider changing it to 'parameters'.
| All other parmeters are optional or can be left at their default values. | |
| All other parameters are optional or can be left at their default values. |
3pings
left a comment
3pings
left a comment
There was a problem hiding this comment.
Reviewed. Please check the comments.
packs/cloudcasa-3.1.0/README.md
Outdated
|
|
||
| This will install the CloudCasa agent and complete registration of the cluster with the CloudCasa service. | ||
|
|
||
| ###Using an alternate image repository |
There was a problem hiding this comment.
Adjust the spacing for Markdown
| pack: | ||
| # The namespace (on the target cluster) in which the pack will be deployed. | ||
| # When the namespace is not found, a new namespace will be created with the name specified. | ||
| # Note this namespace MUST NOT BE CHANGED from "cloudcasa-io". |
There was a problem hiding this comment.
Include the content.images in the pack. Check other packs for examples. This should be the image or images needed for the pack to functions. This is how we use packs in airgap to bundle the images listed here.
https://github.com/spectrocloud/pack-central/blob/main/packs/kyverno-1.12.2/values.yaml
| "layer": "addon", | ||
| "addonType": "system app", | ||
| "cloudTypes": [ "all" ], | ||
| "charts": [ "charts/cloudcasa-3.4.4.tgz" ] |
There was a problem hiding this comment.
Should these versions match?
| | image.repository | string | `"docker.io/catalogicsoftware/amds-kagent"` | Yes | | ||
| | image.tag | string | `"3.1.0-prod"` | Yes | | ||
| | imagePullSecret | string | `null` | No | | ||
|
|
There was a problem hiding this comment.
Are there any "Upgrade" specific notes? Add them as a section here.
There was a problem hiding this comment.
No, there are really no additional notes necessary for upgrade.
Thanks for your comments, @3pings. I think I've addressed them all. |
This reverts commit 3b345d2.
4 participants
Adds pack for CloudCasa Agent 1.3.0.
Validated profile creation and cluster deployment on Palette using a private ACR repo.