-
Notifications
You must be signed in to change notification settings - Fork 3
Expand file tree
/
Copy pathwriter_cii_test.go
More file actions
1092 lines (966 loc) · 32.6 KB
/
Copy pathwriter_cii_test.go
File metadata and controls
1092 lines (966 loc) · 32.6 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
package einvoice
import (
"bytes"
"os"
"strings"
"testing"
"time"
"github.com/shopspring/decimal"
)
// TestWrite_PayeeTradeParty tests that PayeeTradeParty is written with correct XML structure
// This test verifies the fix for the critical bug where PayeeTradeParty element was missing
func TestWrite_PayeeTradeParty(t *testing.T) {
t.Parallel()
fixedDate, _ := time.Parse("02.01.2006", "31.12.2025")
inv := Invoice{
InvoiceNumber: "TEST-001",
InvoiceTypeCode: 380,
GuidelineSpecifiedDocumentContextParameter: SpecEN16931,
InvoiceDate: fixedDate,
InvoiceCurrencyCode: "EUR",
Seller: Party{
Name: "Seller Company",
VATaxRegistration: "DE123456",
PostalAddress: &PostalAddress{
Line1: "Seller Street 1",
City: "Berlin",
PostcodeCode: "10115",
CountryID: "DE",
},
},
Buyer: Party{
Name: "Buyer Company",
PostalAddress: &PostalAddress{
Line1: "Buyer Street 1",
City: "Paris",
PostcodeCode: "75001",
CountryID: "FR",
},
},
// BG-10: PayeeTradeParty - different from seller
PayeeTradeParty: &Party{
Name: "Payment Receiver Inc",
VATaxRegistration: "DE789012",
PostalAddress: &PostalAddress{
Line1: "Payee Street 1",
City: "Munich",
PostcodeCode: "80331",
CountryID: "DE",
},
},
InvoiceLines: []InvoiceLine{
{
LineID: "1",
ItemName: "Test Item",
BilledQuantity: decimal.NewFromInt(1),
BilledQuantityUnit: "C62",
NetPrice: decimal.NewFromInt(100),
TaxRateApplicablePercent: decimal.NewFromInt(19),
Total: decimal.NewFromInt(100),
TaxTypeCode: "VAT",
TaxCategoryCode: "S",
},
},
}
inv.UpdateApplicableTradeTax(nil)
inv.UpdateTotals()
var buf bytes.Buffer
if err := inv.Write(&buf); err != nil {
t.Fatalf("Write() failed: %v", err)
}
xmlOutput := buf.String()
// Verify that PayeeTradeParty element exists
if !strings.Contains(xmlOutput, "<ram:PayeeTradeParty>") {
t.Error("Expected <ram:PayeeTradeParty> element to be present")
}
// Verify PayeeTradeParty contains the correct name
if !strings.Contains(xmlOutput, "<ram:Name>Payment Receiver Inc</ram:Name>") {
t.Error("Expected PayeeTradeParty to contain correct name")
}
// Verify PayeeTradeParty contains postal address
if !strings.Contains(xmlOutput, "<ram:PostcodeCode>80331</ram:PostcodeCode>") {
t.Error("Expected PayeeTradeParty to contain postal address")
}
// Verify PayeeTradeParty contains VAT registration
if !strings.Contains(xmlOutput, "DE789012") {
t.Error("Expected PayeeTradeParty to contain VAT registration")
}
// Verify the structure: PayeeTradeParty should be inside ApplicableHeaderTradeSettlement
// and should have proper child elements, not be a sibling
payeeStartIdx := strings.Index(xmlOutput, "<ram:PayeeTradeParty>")
payeeEndIdx := strings.Index(xmlOutput, "</ram:PayeeTradeParty>")
if payeeStartIdx == -1 || payeeEndIdx == -1 {
t.Fatal("PayeeTradeParty tags not found")
}
// Extract the PayeeTradeParty section
payeeSection := xmlOutput[payeeStartIdx:payeeEndIdx]
// Verify it contains child elements (not just closing tag)
if !strings.Contains(payeeSection, "<ram:Name>") {
t.Error("PayeeTradeParty should contain child elements like <ram:Name>")
}
}
func TestWrite_RoundTrip(t *testing.T) {
original := &Invoice{
SchemaType: CII,
GuidelineSpecifiedDocumentContextParameter: SpecEN16931,
InvoiceNumber: "INV-RoundTrip",
InvoiceTypeCode: 380,
InvoiceDate: time.Date(2024, 1, 15, 0, 0, 0, 0, time.UTC),
InvoiceCurrencyCode: "EUR",
BuyerReference: "REF-123",
Seller: Party{
Name: "Test Seller",
PostalAddress: &PostalAddress{
CountryID: "DE",
PostcodeCode: "10115",
City: "Berlin",
},
VATaxRegistration: "DE123456789",
},
Buyer: Party{
Name: "Test Buyer",
PostalAddress: &PostalAddress{
CountryID: "FR",
PostcodeCode: "75001",
City: "Paris",
},
VATaxRegistration: "FR987654321",
},
LineTotal: decimal.NewFromInt(200),
TaxBasisTotal: decimal.NewFromInt(200),
TaxTotal: decimal.NewFromInt(38),
GrandTotal: decimal.NewFromInt(238),
DuePayableAmount: decimal.NewFromInt(238),
InvoiceLines: []InvoiceLine{
{
LineID: "1",
ItemName: "Test Product",
BilledQuantity: decimal.NewFromInt(2),
BilledQuantityUnit: "C62",
NetPrice: decimal.NewFromInt(100),
Total: decimal.NewFromInt(200),
TaxCategoryCode: "S",
TaxTypeCode: "VAT",
TaxRateApplicablePercent: decimal.NewFromInt(19),
},
{
TaxCategoryCode: "O",
},
},
TradeTaxes: []TradeTax{
{
CalculatedAmount: decimal.NewFromInt(38),
BasisAmount: decimal.NewFromInt(200),
TypeCode: "VAT",
CategoryCode: "S",
Percent: decimal.NewFromInt(19),
},
},
}
// Write to buffer
var buf bytes.Buffer
err := original.Write(&buf)
if err != nil {
t.Fatalf("Failed to write invoice: %v", err)
}
// Parse back
parsed, err := ParseReader(&buf)
if err != nil {
t.Fatalf("Failed to parse written invoice: %v", err)
}
// Verify key fields
if parsed.SchemaType != CII {
t.Errorf("Expected SchemaType CII, got %v", parsed.SchemaType)
}
if parsed.InvoiceNumber != original.InvoiceNumber {
t.Errorf("InvoiceNumber mismatch: got %s, want %s", parsed.InvoiceNumber, original.InvoiceNumber)
}
if parsed.InvoiceTypeCode != original.InvoiceTypeCode {
t.Errorf("InvoiceTypeCode mismatch: got %d, want %d", parsed.InvoiceTypeCode, original.InvoiceTypeCode)
}
if parsed.InvoiceCurrencyCode != original.InvoiceCurrencyCode {
t.Errorf("InvoiceCurrencyCode mismatch: got %s, want %s", parsed.InvoiceCurrencyCode, original.InvoiceCurrencyCode)
}
if !parsed.GrandTotal.Equal(original.GrandTotal) {
t.Errorf("GrandTotal mismatch: got %s, want %s", parsed.GrandTotal, original.GrandTotal)
}
if len(parsed.InvoiceLines) != len(original.InvoiceLines) {
t.Errorf("InvoiceLines count mismatch: got %d, want %d", len(parsed.InvoiceLines), len(original.InvoiceLines))
}
if len(parsed.InvoiceLines) > 0 {
if parsed.InvoiceLines[0].ItemName != original.InvoiceLines[0].ItemName {
t.Errorf("Line ItemName mismatch: got %s, want %s", parsed.InvoiceLines[0].ItemName, original.InvoiceLines[0].ItemName)
}
if parsed.InvoiceLines[1].hasTaxRateApplicablePercent {
t.Errorf("Line hasTaxRateApplicablePercent is true, should've been false")
}
}
}
// TestWrite_MultiCurrencyTaxTotal tests that BT-111 (TaxTotalAmount in accounting currency)
// is written when TaxCurrencyCode differs from InvoiceCurrencyCode
func TestWrite_MultiCurrencyTaxTotal(t *testing.T) {
t.Parallel()
fixedDate, _ := time.Parse("02.01.2006", "31.12.2025")
inv := Invoice{
InvoiceNumber: "MULTI-CURR-001",
InvoiceTypeCode: 380,
GuidelineSpecifiedDocumentContextParameter: SpecEN16931,
InvoiceDate: fixedDate,
InvoiceCurrencyCode: "USD", // BT-5: Invoice in USD
TaxCurrencyCode: "EUR", // BT-6: Tax accounting in EUR
Seller: Party{
Name: "Seller Company",
VATaxRegistration: "DE123456",
PostalAddress: &PostalAddress{
Line1: "Seller Street 1",
City: "Berlin",
PostcodeCode: "10115",
CountryID: "DE",
},
},
Buyer: Party{
Name: "Buyer Company",
PostalAddress: &PostalAddress{
Line1: "Buyer Street 1",
City: "New York",
PostcodeCode: "10001",
CountryID: "US",
},
},
InvoiceLines: []InvoiceLine{
{
LineID: "1",
ItemName: "Test Item",
BilledQuantity: decimal.NewFromInt(1),
BilledQuantityUnit: "C62",
NetPrice: decimal.NewFromInt(100),
TaxRateApplicablePercent: decimal.NewFromInt(19),
Total: decimal.NewFromInt(100),
TaxTypeCode: "VAT",
TaxCategoryCode: "S",
},
},
// BT-110: Tax total in invoice currency (USD)
TaxTotal: decimal.NewFromInt(19),
TaxTotalCurrency: "USD",
// BT-111: Tax total in accounting currency (EUR) - at exchange rate
TaxTotalAccounting: decimal.NewFromFloat(17.50),
TaxTotalAccountingCurrency: "EUR",
}
inv.UpdateApplicableTradeTax(nil)
inv.UpdateTotals()
var buf bytes.Buffer
if err := inv.Write(&buf); err != nil {
t.Fatalf("Write() failed: %v", err)
}
xmlOutput := buf.String()
// Count TaxTotalAmount elements
taxTotalCount := strings.Count(xmlOutput, "<ram:TaxTotalAmount")
if taxTotalCount != 2 {
t.Errorf("Expected 2 TaxTotalAmount elements (BT-110 and BT-111), got %d", taxTotalCount)
}
// Verify BT-110: TaxTotalAmount in invoice currency (USD)
if !strings.Contains(xmlOutput, `currencyID="USD"`) {
t.Error("Expected TaxTotalAmount with currencyID='USD' (BT-110)")
}
if !strings.Contains(xmlOutput, `currencyID="USD">19.00<`) {
t.Error("Expected TaxTotalAmount in USD to be 19.00")
}
// Verify BT-111: TaxTotalAmount in accounting currency (EUR)
if !strings.Contains(xmlOutput, `currencyID="EUR"`) {
t.Error("Expected TaxTotalAmount with currencyID='EUR' (BT-111)")
}
if !strings.Contains(xmlOutput, `currencyID="EUR">17.50<`) {
t.Error("Expected TaxTotalAmount in EUR to be 17.50")
}
}
// TestWrite_SingleCurrencyTaxTotal tests that only ONE TaxTotalAmount is written
// when invoice and tax currencies are the same
func TestWrite_SingleCurrencyTaxTotal(t *testing.T) {
t.Parallel()
fixedDate, _ := time.Parse("02.01.2006", "31.12.2025")
inv := Invoice{
InvoiceNumber: "SINGLE-CURR-001",
InvoiceTypeCode: 380,
GuidelineSpecifiedDocumentContextParameter: SpecEN16931,
InvoiceDate: fixedDate,
InvoiceCurrencyCode: "EUR", // BT-5
TaxCurrencyCode: "EUR", // BT-6: Same as invoice currency
Seller: Party{
Name: "Seller Company",
VATaxRegistration: "DE123456",
PostalAddress: &PostalAddress{
Line1: "Seller Street 1",
City: "Berlin",
PostcodeCode: "10115",
CountryID: "DE",
},
},
Buyer: Party{
Name: "Buyer Company",
PostalAddress: &PostalAddress{
Line1: "Buyer Street 1",
City: "Paris",
PostcodeCode: "75001",
CountryID: "FR",
},
},
InvoiceLines: []InvoiceLine{
{
LineID: "1",
ItemName: "Test Item",
BilledQuantity: decimal.NewFromInt(1),
BilledQuantityUnit: "C62",
NetPrice: decimal.NewFromInt(100),
TaxRateApplicablePercent: decimal.NewFromInt(19),
Total: decimal.NewFromInt(100),
TaxTypeCode: "VAT",
TaxCategoryCode: "S",
},
},
TaxTotal: decimal.NewFromInt(19),
}
inv.UpdateApplicableTradeTax(nil)
inv.UpdateTotals()
var buf bytes.Buffer
if err := inv.Write(&buf); err != nil {
t.Fatalf("Write() failed: %v", err)
}
xmlOutput := buf.String()
// Count TaxTotalAmount elements - should be only 1 when currencies match
taxTotalCount := strings.Count(xmlOutput, "<ram:TaxTotalAmount")
if taxTotalCount != 1 {
t.Errorf("Expected 1 TaxTotalAmount element when currencies match, got %d", taxTotalCount)
}
// Verify it has EUR currency
if !strings.Contains(xmlOutput, `currencyID="EUR">19.00<`) {
t.Error("Expected single TaxTotalAmount in EUR to be 19.00")
}
}
// TestWrite_NoTaxCurrencyCode tests backward compatibility when TaxCurrencyCode is not set
func TestWrite_NoTaxCurrencyCode(t *testing.T) {
t.Parallel()
fixedDate, _ := time.Parse("02.01.2006", "31.12.2025")
inv := Invoice{
InvoiceNumber: "NO-TAX-CURR-001",
InvoiceTypeCode: 380,
GuidelineSpecifiedDocumentContextParameter: SpecEN16931,
InvoiceDate: fixedDate,
InvoiceCurrencyCode: "EUR",
// TaxCurrencyCode not set (empty string)
Seller: Party{
Name: "Seller Company",
VATaxRegistration: "DE123456",
PostalAddress: &PostalAddress{
Line1: "Seller Street 1",
City: "Berlin",
PostcodeCode: "10115",
CountryID: "DE",
},
},
Buyer: Party{
Name: "Buyer Company",
PostalAddress: &PostalAddress{
Line1: "Buyer Street 1",
City: "Paris",
PostcodeCode: "75001",
CountryID: "FR",
},
},
InvoiceLines: []InvoiceLine{
{
LineID: "1",
ItemName: "Test Item",
BilledQuantity: decimal.NewFromInt(1),
BilledQuantityUnit: "C62",
NetPrice: decimal.NewFromInt(100),
TaxRateApplicablePercent: decimal.NewFromInt(19),
Total: decimal.NewFromInt(100),
TaxTypeCode: "VAT",
TaxCategoryCode: "S",
},
},
TaxTotal: decimal.NewFromInt(19),
}
inv.UpdateApplicableTradeTax(nil)
inv.UpdateTotals()
var buf bytes.Buffer
if err := inv.Write(&buf); err != nil {
t.Fatalf("Write() failed: %v", err)
}
xmlOutput := buf.String()
// Should have only 1 TaxTotalAmount
taxTotalCount := strings.Count(xmlOutput, "<ram:TaxTotalAmount")
if taxTotalCount != 1 {
t.Errorf("Expected 1 TaxTotalAmount element when TaxCurrencyCode not set, got %d", taxTotalCount)
}
}
// TestWrite_BillingPeriod_OnlyEndDate tests that document-level billing period
// is written correctly when only end date is provided (Bug #3)
// BR-CO-19 states: "either start date OR end date OR both must be filled"
func TestWrite_BillingPeriod_OnlyEndDate(t *testing.T) {
t.Parallel()
invoiceDate, _ := time.Parse("02.01.2006", "31.12.2025")
periodEnd, _ := time.Parse("02.01.2006", "31.12.2025")
inv := Invoice{
InvoiceNumber: "PERIOD-001",
InvoiceTypeCode: 380,
GuidelineSpecifiedDocumentContextParameter: SpecEN16931,
InvoiceDate: invoiceDate,
InvoiceCurrencyCode: "EUR",
// BG-14: Billing period with ONLY end date (no start date)
BillingSpecifiedPeriodStart: time.Time{}, // Zero value
BillingSpecifiedPeriodEnd: periodEnd,
Seller: Party{
Name: "Seller Company",
VATaxRegistration: "DE123456",
PostalAddress: &PostalAddress{
Line1: "Seller Street 1",
City: "Berlin",
PostcodeCode: "10115",
CountryID: "DE",
},
},
Buyer: Party{
Name: "Buyer Company",
PostalAddress: &PostalAddress{
Line1: "Buyer Street 1",
City: "Paris",
PostcodeCode: "75001",
CountryID: "FR",
},
},
InvoiceLines: []InvoiceLine{
{
LineID: "1",
ItemName: "Test Item",
BilledQuantity: decimal.NewFromInt(1),
BilledQuantityUnit: "C62",
NetPrice: decimal.NewFromInt(100),
TaxRateApplicablePercent: decimal.NewFromInt(19),
Total: decimal.NewFromInt(100),
TaxTypeCode: "VAT",
TaxCategoryCode: "S",
},
},
}
inv.UpdateApplicableTradeTax(nil)
inv.UpdateTotals()
var buf bytes.Buffer
if err := inv.Write(&buf); err != nil {
t.Fatalf("Write() failed: %v", err)
}
xmlOutput := buf.String()
// BUG: The billing period should be written even with only end date
// The current code only writes if start date is non-zero
if !strings.Contains(xmlOutput, "<ram:BillingSpecifiedPeriod>") {
t.Error("BillingSpecifiedPeriod element should be written when end date is provided (BR-CO-19)")
}
// Should have EndDateTime element
if !strings.Contains(xmlOutput, "<ram:EndDateTime>") {
t.Error("EndDateTime should be present in BillingSpecifiedPeriod")
}
// Should NOT write "00010101" for zero start date
if strings.Contains(xmlOutput, "00010101") {
t.Error("Should not write zero date value (00010101) for missing start date")
}
// Should NOT have StartDateTime element when start date is zero
periodStartIdx := strings.Index(xmlOutput, "<ram:BillingSpecifiedPeriod>")
periodEndIdx := strings.Index(xmlOutput, "</ram:BillingSpecifiedPeriod>")
if periodStartIdx != -1 && periodEndIdx != -1 {
periodSection := xmlOutput[periodStartIdx:periodEndIdx]
if strings.Contains(periodSection, "<ram:StartDateTime>") {
t.Error("StartDateTime should NOT be written when start date is zero")
}
}
}
// TestWrite_BillingPeriod_OnlyStartDate tests that document-level billing period
// is written correctly when only start date is provided (Bug #3)
func TestWrite_BillingPeriod_OnlyStartDate(t *testing.T) {
t.Parallel()
invoiceDate, _ := time.Parse("02.01.2006", "31.12.2025")
periodStart, _ := time.Parse("02.01.2006", "01.12.2025")
inv := Invoice{
InvoiceNumber: "PERIOD-002",
InvoiceTypeCode: 380,
GuidelineSpecifiedDocumentContextParameter: SpecEN16931,
InvoiceDate: invoiceDate,
InvoiceCurrencyCode: "EUR",
// BG-14: Billing period with ONLY start date (no end date)
BillingSpecifiedPeriodStart: periodStart,
BillingSpecifiedPeriodEnd: time.Time{}, // Zero value
Seller: Party{
Name: "Seller Company",
VATaxRegistration: "DE123456",
PostalAddress: &PostalAddress{
Line1: "Seller Street 1",
City: "Berlin",
PostcodeCode: "10115",
CountryID: "DE",
},
},
Buyer: Party{
Name: "Buyer Company",
PostalAddress: &PostalAddress{
Line1: "Buyer Street 1",
City: "Paris",
PostcodeCode: "75001",
CountryID: "FR",
},
},
InvoiceLines: []InvoiceLine{
{
LineID: "1",
ItemName: "Test Item",
BilledQuantity: decimal.NewFromInt(1),
BilledQuantityUnit: "C62",
NetPrice: decimal.NewFromInt(100),
TaxRateApplicablePercent: decimal.NewFromInt(19),
Total: decimal.NewFromInt(100),
TaxTypeCode: "VAT",
TaxCategoryCode: "S",
},
},
}
inv.UpdateApplicableTradeTax(nil)
inv.UpdateTotals()
var buf bytes.Buffer
if err := inv.Write(&buf); err != nil {
t.Fatalf("Write() failed: %v", err)
}
xmlOutput := buf.String()
// Should have BillingSpecifiedPeriod element
if !strings.Contains(xmlOutput, "<ram:BillingSpecifiedPeriod>") {
t.Error("BillingSpecifiedPeriod element should be written when start date is provided")
}
// Should have StartDateTime element
if !strings.Contains(xmlOutput, "<ram:StartDateTime>") {
t.Error("StartDateTime should be present in BillingSpecifiedPeriod")
}
// Should NOT write "00010101" for zero end date
if strings.Contains(xmlOutput, "00010101") {
t.Error("Should not write zero date value (00010101) for missing end date")
}
// Should NOT have EndDateTime element when end date is zero
periodStartIdx := strings.Index(xmlOutput, "<ram:BillingSpecifiedPeriod>")
periodEndIdx := strings.Index(xmlOutput, "</ram:BillingSpecifiedPeriod>")
if periodStartIdx != -1 && periodEndIdx != -1 {
periodSection := xmlOutput[periodStartIdx:periodEndIdx]
if strings.Contains(periodSection, "<ram:EndDateTime>") {
t.Error("EndDateTime should NOT be written when end date is zero")
}
}
}
// TestWrite_BillingPeriod_BothDates tests that document-level billing period
// is written correctly when both start and end dates are provided
func TestWrite_BillingPeriod_BothDates(t *testing.T) {
t.Parallel()
invoiceDate, _ := time.Parse("02.01.2006", "31.12.2025")
periodStart, _ := time.Parse("02.01.2006", "01.12.2025")
periodEnd, _ := time.Parse("02.01.2006", "31.12.2025")
inv := Invoice{
InvoiceNumber: "PERIOD-003",
InvoiceTypeCode: 380,
GuidelineSpecifiedDocumentContextParameter: SpecEN16931,
InvoiceDate: invoiceDate,
InvoiceCurrencyCode: "EUR",
// BG-14: Billing period with both dates
BillingSpecifiedPeriodStart: periodStart,
BillingSpecifiedPeriodEnd: periodEnd,
Seller: Party{
Name: "Seller Company",
VATaxRegistration: "DE123456",
PostalAddress: &PostalAddress{
Line1: "Seller Street 1",
City: "Berlin",
PostcodeCode: "10115",
CountryID: "DE",
},
},
Buyer: Party{
Name: "Buyer Company",
PostalAddress: &PostalAddress{
Line1: "Buyer Street 1",
City: "Paris",
PostcodeCode: "75001",
CountryID: "FR",
},
},
InvoiceLines: []InvoiceLine{
{
LineID: "1",
ItemName: "Test Item",
BilledQuantity: decimal.NewFromInt(1),
BilledQuantityUnit: "C62",
NetPrice: decimal.NewFromInt(100),
TaxRateApplicablePercent: decimal.NewFromInt(19),
Total: decimal.NewFromInt(100),
TaxTypeCode: "VAT",
TaxCategoryCode: "S",
},
},
}
inv.UpdateApplicableTradeTax(nil)
inv.UpdateTotals()
var buf bytes.Buffer
if err := inv.Write(&buf); err != nil {
t.Fatalf("Write() failed: %v", err)
}
xmlOutput := buf.String()
// Should have BillingSpecifiedPeriod element
if !strings.Contains(xmlOutput, "<ram:BillingSpecifiedPeriod>") {
t.Error("BillingSpecifiedPeriod element should be written when both dates are provided")
}
// Should have both StartDateTime and EndDateTime elements
if !strings.Contains(xmlOutput, "<ram:StartDateTime>") {
t.Error("StartDateTime should be present in BillingSpecifiedPeriod")
}
if !strings.Contains(xmlOutput, "<ram:EndDateTime>") {
t.Error("EndDateTime should be present in BillingSpecifiedPeriod")
}
// Extract the dates and verify they're correct
if !strings.Contains(xmlOutput, "20251201") { // Start date: 01.12.2025
t.Error("StartDateTime should contain correct date value (20251201)")
}
if !strings.Contains(xmlOutput, "20251231") { // End date: 31.12.2025
t.Error("EndDateTime should contain correct date value (20251231)")
}
}
// TestWrite_InvoiceLineAllowances tests that invoice line allowances (BG-27)
// are written correctly (Bug #1)
func TestWrite_InvoiceLineAllowances(t *testing.T) {
t.Parallel()
invoiceDate, _ := time.Parse("02.01.2006", "31.12.2025")
inv := Invoice{
InvoiceNumber: "LINE-ALLOW-001",
InvoiceTypeCode: 380,
GuidelineSpecifiedDocumentContextParameter: SpecEN16931,
InvoiceDate: invoiceDate,
InvoiceCurrencyCode: "EUR",
Seller: Party{
Name: "Seller Company",
VATaxRegistration: "DE123456",
PostalAddress: &PostalAddress{
Line1: "Seller Street 1",
City: "Berlin",
PostcodeCode: "10115",
CountryID: "DE",
},
},
Buyer: Party{
Name: "Buyer Company",
PostalAddress: &PostalAddress{
Line1: "Buyer Street 1",
City: "Paris",
PostcodeCode: "75001",
CountryID: "FR",
},
},
InvoiceLines: []InvoiceLine{
{
LineID: "1",
ItemName: "Test Item",
BilledQuantity: decimal.NewFromInt(1),
BilledQuantityUnit: "C62",
NetPrice: decimal.NewFromInt(90),
TaxRateApplicablePercent: decimal.NewFromInt(19),
Total: decimal.NewFromInt(90),
TaxTypeCode: "VAT",
TaxCategoryCode: "S",
// BG-27: Invoice line allowances
InvoiceLineAllowances: []AllowanceCharge{
{
ChargeIndicator: false,
BasisAmount: decimal.NewFromInt(100),
ActualAmount: decimal.NewFromInt(10),
Reason: "Volume discount",
CategoryTradeTaxType: "VAT",
CategoryTradeTaxCategoryCode: "S",
CategoryTradeTaxRateApplicablePercent: decimal.NewFromInt(19),
},
},
},
},
}
inv.UpdateApplicableTradeTax(nil)
inv.UpdateTotals()
var buf bytes.Buffer
if err := inv.Write(&buf); err != nil {
t.Fatalf("Write() failed: %v", err)
}
xmlOutput := buf.String()
// BUG: Invoice line allowances should be written as SpecifiedTradeAllowanceCharge
// under SpecifiedLineTradeSettlement
if !strings.Contains(xmlOutput, "<ram:SpecifiedLineTradeSettlement>") {
t.Error("SpecifiedLineTradeSettlement should be present")
}
// Should contain SpecifiedTradeAllowanceCharge within SpecifiedLineTradeSettlement
settlementStart := strings.Index(xmlOutput, "<ram:SpecifiedLineTradeSettlement>")
settlementEnd := strings.Index(xmlOutput, "</ram:SpecifiedLineTradeSettlement>")
if settlementStart == -1 || settlementEnd == -1 {
t.Fatal("Could not find SpecifiedLineTradeSettlement section")
}
settlementSection := xmlOutput[settlementStart:settlementEnd]
if !strings.Contains(settlementSection, "<ram:SpecifiedTradeAllowanceCharge>") {
t.Error("SpecifiedTradeAllowanceCharge should be present in SpecifiedLineTradeSettlement for invoice line allowances (BG-27)")
}
// Should have ChargeIndicator = false for allowance
if !strings.Contains(settlementSection, "<ram:ChargeIndicator>") {
t.Error("ChargeIndicator should be present in line allowance")
}
if !strings.Contains(settlementSection, "false") {
t.Error("ChargeIndicator should be false for allowance")
}
// Should have ActualAmount
if !strings.Contains(settlementSection, "<ram:ActualAmount>10") {
t.Error("ActualAmount should be 10 for the allowance")
}
// Should have Reason
if !strings.Contains(settlementSection, "Volume discount") {
t.Error("Allowance reason should be present")
}
}
// TestWrite_InvoiceLineCharges tests that invoice line charges (BG-28)
// are written correctly (Bug #1)
func TestWrite_InvoiceLineCharges(t *testing.T) {
t.Parallel()
invoiceDate, _ := time.Parse("02.01.2006", "31.12.2025")
inv := Invoice{
InvoiceNumber: "LINE-CHARGE-001",
InvoiceTypeCode: 380,
GuidelineSpecifiedDocumentContextParameter: SpecEN16931,
InvoiceDate: invoiceDate,
InvoiceCurrencyCode: "EUR",
Seller: Party{
Name: "Seller Company",
VATaxRegistration: "DE123456",
PostalAddress: &PostalAddress{
Line1: "Seller Street 1",
City: "Berlin",
PostcodeCode: "10115",
CountryID: "DE",
},
},
Buyer: Party{
Name: "Buyer Company",
PostalAddress: &PostalAddress{
Line1: "Buyer Street 1",
City: "Paris",
PostcodeCode: "75001",
CountryID: "FR",
},
},
InvoiceLines: []InvoiceLine{
{
LineID: "1",
ItemName: "Test Item",
BilledQuantity: decimal.NewFromInt(1),
BilledQuantityUnit: "C62",
NetPrice: decimal.NewFromInt(105),
TaxRateApplicablePercent: decimal.NewFromInt(19),
Total: decimal.NewFromInt(105),
TaxTypeCode: "VAT",
TaxCategoryCode: "S",
// BG-28: Invoice line charges
InvoiceLineCharges: []AllowanceCharge{
{
ChargeIndicator: true,
ActualAmount: decimal.NewFromInt(5),
Reason: "Handling fee",
CategoryTradeTaxType: "VAT",
CategoryTradeTaxCategoryCode: "S",
CategoryTradeTaxRateApplicablePercent: decimal.NewFromInt(19),
},
},
},
},
}
inv.UpdateApplicableTradeTax(nil)
inv.UpdateTotals()
var buf bytes.Buffer
if err := inv.Write(&buf); err != nil {
t.Fatalf("Write() failed: %v", err)
}
xmlOutput := buf.String()
// Extract SpecifiedLineTradeSettlement section
settlementStart := strings.Index(xmlOutput, "<ram:SpecifiedLineTradeSettlement>")
settlementEnd := strings.Index(xmlOutput, "</ram:SpecifiedLineTradeSettlement>")
if settlementStart == -1 || settlementEnd == -1 {
t.Fatal("Could not find SpecifiedLineTradeSettlement section")
}
settlementSection := xmlOutput[settlementStart:settlementEnd]
if !strings.Contains(settlementSection, "<ram:SpecifiedTradeAllowanceCharge>") {
t.Error("SpecifiedTradeAllowanceCharge should be present in SpecifiedLineTradeSettlement for invoice line charges (BG-28)")
}
// Should have ChargeIndicator = true for charge
if !strings.Contains(settlementSection, "true") {
t.Error("ChargeIndicator should be true for charge")
}
// Should have ActualAmount
if !strings.Contains(settlementSection, "<ram:ActualAmount>5") {
t.Error("ActualAmount should be 5 for the charge")
}
// Should have Reason
if !strings.Contains(settlementSection, "Handling fee") {
t.Error("Charge reason should be present")
}
}
// TestWrite_InvoiceLineBillingPeriod tests that invoice line billing period
// is written correctly (Bug #2)
func TestWrite_InvoiceLineBillingPeriod(t *testing.T) {
t.Parallel()
invoiceDate, _ := time.Parse("02.01.2006", "31.12.2025")
linePeriodStart, _ := time.Parse("02.01.2006", "01.11.2025")
linePeriodEnd, _ := time.Parse("02.01.2006", "30.11.2025")
inv := Invoice{
InvoiceNumber: "LINE-PERIOD-001",
InvoiceTypeCode: 380,
GuidelineSpecifiedDocumentContextParameter: SpecEN16931,
InvoiceDate: invoiceDate,
InvoiceCurrencyCode: "EUR",
Seller: Party{
Name: "Seller Company",
VATaxRegistration: "DE123456",
PostalAddress: &PostalAddress{
Line1: "Seller Street 1",
City: "Berlin",
PostcodeCode: "10115",
CountryID: "DE",
},
},
Buyer: Party{
Name: "Buyer Company",
PostalAddress: &PostalAddress{
Line1: "Buyer Street 1",
City: "Paris",
PostcodeCode: "75001",
CountryID: "FR",
},
},
InvoiceLines: []InvoiceLine{
{
LineID: "1",
ItemName: "Monthly Service",
BilledQuantity: decimal.NewFromInt(1),
BilledQuantityUnit: "C62",
NetPrice: decimal.NewFromInt(100),
TaxRateApplicablePercent: decimal.NewFromInt(19),
Total: decimal.NewFromInt(100),
TaxTypeCode: "VAT",
TaxCategoryCode: "S",
// BT-134, BT-135: Invoice line billing period
BillingSpecifiedPeriodStart: linePeriodStart,
BillingSpecifiedPeriodEnd: linePeriodEnd,
},
},
}
inv.UpdateApplicableTradeTax(nil)
inv.UpdateTotals()
var buf bytes.Buffer
if err := inv.Write(&buf); err != nil {
t.Fatalf("Write() failed: %v", err)
}
xmlOutput := buf.String()
// BUG: Invoice line billing period should be written
// Extract SpecifiedLineTradeSettlement section
settlementStart := strings.Index(xmlOutput, "<ram:SpecifiedLineTradeSettlement>")
settlementEnd := strings.Index(xmlOutput, "</ram:SpecifiedLineTradeSettlement>")
if settlementStart == -1 || settlementEnd == -1 {
t.Fatal("Could not find SpecifiedLineTradeSettlement section")
}
settlementSection := xmlOutput[settlementStart:settlementEnd]
if !strings.Contains(settlementSection, "<ram:BillingSpecifiedPeriod>") {
t.Error("BillingSpecifiedPeriod should be present in invoice line (BG-26)")
}
// Should have both StartDateTime and EndDateTime
if !strings.Contains(settlementSection, "<ram:StartDateTime>") {
t.Error("StartDateTime should be present in line billing period")
}
if !strings.Contains(settlementSection, "<ram:EndDateTime>") {
t.Error("EndDateTime should be present in line billing period")
}
// Verify dates are correct