@@ -67,15 +67,15 @@ def _patch_lightning_jsonargparse():
6767 function = _patch_einsum_strategies , patched_package = 'torch' ,
6868 description = 'Address trivial tp submesh limitation until PyTorch provides upstream fix' )
6969
70- # TODO: remove if lightning fixes `2.5 .0` with a post or `2.6.0` is minimum
70+ # TODO: remove when min jsonargparse is `4.35 .0` or another `2.5.0.postN` lightning release fixes
7171lightning_jsonargparse_patch = DependencyPatch (
72- condition = (lwt_compare_version ( "lightning" , operator . eq , "2.5.0" ), sys .version_info >= (3 , 12 , 8 ),
73- lwt_compare_version ( "jsonargparse" , operator . ge , "4.35.0" ), _JSONARGPARSE_SIGNATURES_AVAILABLE ),
72+ condition = (sys .version_info >= (3 , 12 , 8 ), lwt_compare_version ( "jsonargparse" , operator . lt , "4.35.0" ),
73+ _JSONARGPARSE_SIGNATURES_AVAILABLE ),
7474 env_flag = OSEnvToggle ("ENABLE_FTS_LIGHTNING_JSONARGPARSE_PATCH" , default = "1" ),
7575 function = _patch_lightning_jsonargparse ,
7676 patched_package = 'lightning' ,
77- description = (' For the edge case where `lightning` patches `jsonargparse` in a manner that breaks '
78- 'certain versions of `jsonargparse`' )
77+ description = (" For the edge case where `lightning` allows a `jsonargparse` version that doesn't support"
78+ " python versions >= `3.12.8`." )
7979)
8080
8181# TODO: remove once `datasets==2.21.0` is minimum
0 commit comments