Skip to content

Commit 59e0494

Browse files
committed
cleanup normalized CI script option references, remove old CI script doc references
1 parent e0333b3 commit 59e0494

File tree

10 files changed

+107
-105
lines changed

10 files changed

+107
-105
lines changed

.github/CONTRIBUTING.md

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ To setup a local development environment, install both local and test dependenci
177177

178178
```bash
179179
cd ~/repos/finetuning-scheduler
180-
./scripts/build_fts_env.sh --repo_home=${PWD} --target_env_name=fts_latest
180+
./scripts/build_fts_env.sh --repo-home=${PWD} --target-env-name=fts_latest
181181

182182
# Activate (use your venv base path)
183183
export FTS_VENV_BASE=~/.venvs
@@ -198,17 +198,16 @@ uv pip install pre-commit
198198
pre-commit install
199199
```
200200

201-
**Manual installation with PyTorch nightly:**
201+
**Manual installation with a PyTorch prerelease (nightly/test):**
202202

203-
When testing against PyTorch nightly builds, use a two-step installation approach:
203+
When testing against a PyTorch prerelease (nightly or test), use a two-step installation approach:
204204

205205
```bash
206206
cd ~/repos/finetuning-scheduler
207207

208-
# Step 1: Install PyTorch nightly (adjust version and CUDA target as needed)
209-
# Check requirements/ci/torch-nightly.txt for the current nightly version
210-
uv pip install --prerelease=if-necessary-or-explicit torch==2.10.0.dev20251124 \
211-
--index-url https://download.pytorch.org/whl/nightly/cu128
208+
# Step 1: Install a PyTorch prerelease (adjust version and CUDA target as needed; see configuration in requirements/ci/torch-pre.txt)
209+
# Example (nightly):
210+
uv pip install --prerelease=if-necessary-or-explicit torch==2.10.0.dev20251124 --index-url https://download.pytorch.org/whl/nightly/cu128
212211

213212
# Step 2: Install FTS with Lightning commit pin (torch already installed, will be skipped)
214213
export UV_OVERRIDE=${PWD}/requirements/ci/overrides.txt

.github/copilot-instructions.md

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ FTS supports both standalone and unified Lightning packages:
2323

2424
- When set, installs Lightning from a git commit (specified in `requirements/ci/overrides.txt`)
2525
- Default in dev/CI builds for consistent testing against latest Lightning changes
26-
- Can be disabled with `--no_commit_pin` flag in build scripts
26+
- Can be disabled with `--no-commit-pin` flag in build scripts
2727

2828
## Code Standards
2929

@@ -65,7 +65,7 @@ curl -LsSf https://astral.sh/uv/install.sh | sh
6565

6666
# Create development environment (creates traditional venv)
6767
# The build script handles Lightning commit pinning and optional PyTorch nightly automatically
68-
./scripts/build_fts_env.sh --repo_home=${PWD} --target_env_name=fts_latest
68+
./scripts/build_fts_env.sh --repo-home=${PWD} --target-env-name=fts_latest
6969

7070
# Activate the environment
7171
cd ${FTS_REPO_DIR} && \
@@ -86,44 +86,53 @@ export UV_OVERRIDE=${PWD}/requirements/ci/overrides.txt
8686
uv pip install -e ".[all]"
8787
```
8888

89-
**Manual installation with PyTorch nightly:**
89+
**Manual installation with a PyTorch prerelease (nightly/test):**
9090

9191
```bash
9292
cd ${FTS_REPO_DIR}
9393

94-
# Install PyTorch nightly first (adjust version and CUDA target as needed, see any specified metadata in requirements/ci/torch-nightly.txt or use your preferred one)
95-
uv pip install torch==2.10.0.dev20251124 --index-url https://download.pytorch.org/whl/nightly/cu128
94+
# Install a PyTorch prerelease first (adjust version and CUDA target as needed; see configuration in requirements/ci/torch-pre.txt)
95+
# Example (nightly):
96+
uv pip install --prerelease=allow torch==2.10.0.dev20251124 --index-url https://download.pytorch.org/whl/nightly/cu128
9697

9798
# Then install FTS with Lightning commit pin
9899
export UV_OVERRIDE=${PWD}/requirements/ci/overrides.txt
99100
uv pip install -e ".[all]"
100101
```
101102

103+
# To configure PyTorch prerelease used by the build scripts and azure pipelines, edit `requirements/ci/torch-pre.txt`:
104+
105+
# Line 1: torch version (e.g., 2.10.0 for test/RC or 2.10.0.dev20251203 for nightly)
106+
107+
# Line 2: CUDA target for local builds (e.g., cu128) — CI uses cpu
108+
109+
# Line 3: channel type: "test" or "nightly"
110+
102111
### Development Environment Scripts
103112

104113
Use the provided build script for automated setup:
105114

106115
```bash
107116
# Standard development build (uses FTS_VENV_BASE or default ~/.venvs)
108-
./scripts/build_fts_env.sh --repo_home=${PWD} --target_env_name=fts_latest
117+
./scripts/build_fts_env.sh --repo-home=${PWD} --target-env-name=fts_latest
109118

110119
# Build with explicit venv directory (recommended for hardlink performance)
111-
./scripts/build_fts_env.sh --repo_home=${HOME}/repos/finetuning-scheduler --target_env_name=fts_latest --venv-dir=/mnt/cache/${USER}/.venvs
120+
./scripts/build_fts_env.sh --repo-home=${HOME}/repos/finetuning-scheduler --target-env-name=fts_latest --venv-dir=/mnt/cache/${USER}/.venvs
112121

113122
# Build without Lightning commit pinning (use PyPI release)
114-
./scripts/build_fts_env.sh --repo_home=${PWD} --target_env_name=fts_latest --no_commit_pin
123+
./scripts/build_fts_env.sh --repo-home=${PWD} --target-env-name=fts_latest --no-commit-pin
115124

116125
# Build with specific PyTorch nightly version
117-
./scripts/build_fts_env.sh --repo_home=${PWD} --target_env_name=fts_latest --torch_dev_ver=dev20240201
126+
./scripts/build_fts_env.sh --repo-home=${PWD} --target-env-name=fts_latest --torch_dev_ver=dev20240201
118127

119128
# Build with PyTorch test channel
120-
./scripts/build_fts_env.sh --repo_home=${PWD} --target_env_name=fts_latest --torch_test_channel
129+
./scripts/build_fts_env.sh --repo-home=${PWD} --target-env-name=fts_latest --torch_test_channel
121130

122131
# Build from Lightning source
123-
./scripts/build_fts_env.sh --repo_home=${HOME}/repos/finetuning-scheduler --target_env_name=fts_latest --from-source="lightning:${HOME}/repos/lightning"
132+
./scripts/build_fts_env.sh --repo-home=${HOME}/repos/finetuning-scheduler --target-env-name=fts_latest --from-source="lightning:${HOME}/repos/lightning"
124133

125134
# Build with oldest compatible dependencies (Python 3.10, mirrors CI oldest matrix)
126-
./scripts/build_fts_env.sh --repo_home=${HOME}/repos/finetuning-scheduler --target_env_name=fts_oldest --oldest
135+
./scripts/build_fts_env.sh --repo-home=${HOME}/repos/finetuning-scheduler --target-env-name=fts_oldest --oldest
127136
```
128137

129138
**Venv Location Options:**

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ All notable changes to this project will be documented in this file.
44

55
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
66

7-
## [2.10.0] - 2025-XX-XX
7+
## [2.10.0] - 2025-01-25
88

99
### Added
1010

README.md

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,15 @@ The `build_fts_env.sh` script automatically handles Lightning commit pinning and
8080
git clone https://github.com/speediedan/finetuning-scheduler.git
8181
cd finetuning-scheduler
8282

83-
# Standard development build (handles Lightning pin automatically and builds with PyTorch nightly (if configured in requirements/ci/torch-nightly.txt)
84-
./scripts/build_fts_env.sh --repo_home=${PWD} --target_env_name=fts_latest --venv-dir=/path/to/.venvs
83+
# Standard development build (handles Lightning pin automatically and installs an optional PyTorch prerelease if configured in `requirements/ci/torch-pre.txt`)
84+
./scripts/build_fts_env.sh --repo-home=${PWD} --target-env-name=fts_latest --venv-dir=/path/to/.venvs
85+
86+
# To configure PyTorch prerelease used by the build scripts, edit `requirements/ci/torch-pre.txt`:
87+
# Line 1: torch version (e.g., 2.10.0 for test/RC or 2.10.0.dev20251203 for nightly)
88+
# Line 2: CUDA target (e.g., cu128) — CI uses cpu
89+
# Line 3: channel type: "test" or "nightly"
90+
91+
# Note: `manage_standalone_processes.sh` is an optional wrapper to run long-running coverage/build scripts with checks for other concurrent conflicting processes, and run options (--use-nohup etc) — you can also run `build_fts_env.sh` and `gen_fts_coverage.sh` directly.
8592

8693
# Activate (use your venv base path)
8794
export FTS_VENV_BASE=~/.venvs # or /mnt/cache/${USER}/.venvs
@@ -100,25 +107,24 @@ export UV_OVERRIDE=${PWD}/requirements/ci/overrides.txt
100107
uv pip install -e ".[all]"
101108
```
102109

103-
#### Manual installation with PyTorch nightly:
110+
## Manual installation with a PyTorch prerelease (nightly/test)
104111

105-
When `torch-nightly.txt` is configured, use a two-step installation approach:
112+
When using a PyTorch prerelease (nightly or test), use a two-step installation approach:
106113

107114
```bash
108115
git clone https://github.com/speediedan/finetuning-scheduler.git
109116
cd finetuning-scheduler
110117

111-
# Step 1: Install PyTorch nightly (adjust version and CUDA target as needed)
112-
uv pip install --prerelease=if-necessary-or-explicit torch==2.10.0.dev20251124 \
113-
--index-url https://download.pytorch.org/whl/nightly/cu128
118+
# Step 1: Install a PyTorch prerelease (adjust version and CUDA target as needed; see configuration in requirements/ci/torch-pre.txt)
119+
# Example (nightly):
120+
uv pip install --prerelease=if-necessary-or-explicit torch==2.10.0.dev20251124 --index-url https://download.pytorch.org/whl/nightly/cu128
114121

115122
# Step 2: Install FTS with Lightning commit pin (torch already installed, will be skipped)
116123
export UV_OVERRIDE=${PWD}/requirements/ci/overrides.txt
117124
uv pip install -e ".[all]"
118125
```
119126

120-
The nightly version is specified in `requirements/ci/torch-nightly.txt` and documented in
121-
`requirements/ci/torch-override.txt` for reference.
127+
The prerelease version is configured via `requirements/ci/torch-pre.txt`. The `lock_ci_requirements.sh` and `build_fts_env.sh` scripts will read this file to determine whether to pre-install a prerelease PyTorch during builds.
122128

123129
#### Install a specific FTS version from source using the standalone `pytorch-lighting` package:
124130

docs/source/install/dynamic_versioning.rst

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,13 @@ environment variable. This is handled automatically by the build scripts and CI
6767
.. code-block:: bash
6868
6969
# The build_fts_env.sh script automatically sets up Lightning commit pinning
70-
# and optionally installs PyTorch nightly (if configured in requirements/ci/torch-nightly.txt)
71-
./scripts/build_fts_env.sh --repo_home=${PWD} --target_env_name=fts_latest
70+
# and optionally installs a PyTorch prerelease (if configured in `requirements/ci/torch-pre.txt`)
71+
./scripts/build_fts_env.sh --repo-home=${PWD} --target-env-name=fts_latest
72+
73+
# To configure PyTorch prerelease used by the build scripts, edit `requirements/ci/torch-pre.txt`:
74+
# Line 1: torch version (e.g., 2.10.0 for test/RC or 2.10.0.dev20251203 for nightly)
75+
# Line 2: CUDA target (e.g., cu128) — CI uses cpu
76+
# Line 3: channel type: "test" or "nightly"
7277

7378
**Manual installation with Lightning commit pin:**
7479

@@ -81,23 +86,23 @@ environment variable. This is handled automatically by the build scripts and CI
8186
export UV_OVERRIDE=${PWD}/requirements/ci/overrides.txt
8287
uv pip install -e ".[all]"
8388
84-
**Manual installation with PyTorch nightly:**
89+
**Manual installation with a PyTorch prerelease (nightly/test):**
8590

86-
When ``torch-nightly.txt`` is configured, use a two-step installation approach:
91+
When using a PyTorch prerelease (nightly or test), use a two-step installation approach:
8792

8893
.. code-block:: bash
8994
9095
git clone https://github.com/speediedan/finetuning-scheduler.git
9196
cd finetuning-scheduler
9297
93-
# Step 1: Install PyTorch nightly (adjust version and CUDA target as needed)
94-
uv pip install --prerelease=if-necessary-or-explicit torch==2.10.0.dev20251124 \
95-
--index-url https://download.pytorch.org/whl/nightly/cu128
98+
# Step 1: Install a PyTorch prerelease (adjust version and CUDA target as needed; see configuration in requirements/ci/torch-pre.txt)
99+
# Example (nightly):
100+
uv pip install --prerelease=allow torch==2.10.0.dev20251124 --index-url https://download.pytorch.org/whl/nightly/cu128
96101
97102
# Step 2: Install FTS with Lightning commit pin (torch already installed, will be skipped)
98103
export UV_OVERRIDE=${PWD}/requirements/ci/overrides.txt
99104
uv pip install -e ".[all]"
100105
101-
The nightly version is specified in ``requirements/ci/torch-nightly.txt`` and documented in
102-
``requirements/ci/torch-override.txt`` for reference. The specific Lightning commit is defined in
103-
``requirements/ci/overrides.txt``.
106+
The prerelease version is configured via ``requirements/ci/torch-pre.txt``. The `lock_ci_requirements.sh` and
107+
`build_fts_env.sh` scripts will read that file to determine whether to pre-install a PyTorch prerelease during builds.
108+
The specific Lightning commit is defined in ``requirements/ci/overrides.txt``.

scripts/README_warnings_cleanup.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ The warnings cleanup automation replaces the manual process previously documente
9898

9999
```bash
100100
# Builds/rebuilds test environments
101-
build_fts_env.sh --repo_home=... --target_env_name=fts_latest
102-
build_fts_env.sh --repo_home=... --target_env_name=fts_oldest --oldest
101+
build_fts_env.sh --repo-home=... --target-env-name=fts_latest
102+
build_fts_env.sh --repo-home=... --target-env-name=fts_oldest --oldest
103103
```
104104

105105
### 2. Test Execution
@@ -347,8 +347,8 @@ When modifying the automation scripts:
347347

348348
```bash
349349
# Rebuild environments manually
350-
./scripts/build_fts_env.sh --repo_home=${PWD} --target_env_name=fts_latest
351-
./scripts/build_fts_env.sh --repo_home=${PWD} --target_env_name=fts_oldest --oldest
350+
./scripts/build_fts_env.sh --repo-home=${PWD} --target-env-name=fts_latest
351+
./scripts/build_fts_env.sh --repo-home=${PWD} --target-env-name=fts_oldest --oldest
352352
```
353353

354354
### "Warnings still unmatched after update"

scripts/automate_warnings_cleanup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,8 +243,8 @@ def _setup_environments(self) -> bool:
243243
logger.info(f"Building environment: {env_name}")
244244
cmd = [
245245
str(build_script),
246-
f"--repo_home={self.config.repo_home}",
247-
f"--target_env_name={env_name}",
246+
f"--repo-home={self.config.repo_home}",
247+
f"--target-env-name={env_name}",
248248
f"--venv-dir={self.config.venv_base}",
249249
*extra_args,
250250
]

scripts/build_fts_env.sh

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
# Utility script to build FTS environments using uv
44
# Usage examples:
55
# build latest (uses FTS_VENV_BASE or default ~/.venvs):
6-
# ./build_fts_env.sh --repo_home=~/repos/finetuning-scheduler --target_env_name=fts_latest
6+
# ./build_fts_env.sh --repo-home=~/repos/finetuning-scheduler --target-env-name=fts_latest
77
# build latest with explicit venv directory (recommended for hardlink performance):
8-
# ./build_fts_env.sh --repo_home=${HOME}/repos/finetuning-scheduler --target_env_name=fts_latest --venv-dir=/mnt/cache/${USER}/.venvs
8+
# ./build_fts_env.sh --repo-home=${HOME}/repos/finetuning-scheduler --target-env-name=fts_latest --venv-dir=/mnt/cache/${USER}/.venvs
99
# build oldest (CI oldest build simulation with Python 3.10 and oldest deps):
10-
# ./build_fts_env.sh --repo_home=${HOME}/repos/finetuning-scheduler --target_env_name=fts_oldest --oldest
10+
# ./build_fts_env.sh --repo-home=${HOME}/repos/finetuning-scheduler --target-env-name=fts_oldest --oldest
1111
# build release:
12-
# ./build_fts_env.sh --repo_home=${HOME}/repos/fts-release --target_env_name=fts_release
12+
# ./build_fts_env.sh --repo-home=${HOME}/repos/fts-release --target-env-name=fts_release
1313
# build latest from a package from source:
14-
# ./build_fts_env.sh --repo_home=${HOME}/repos/finetuning-scheduler --target_env_name=fts_latest --from-source="lightning:${HOME}/repos/lightning:pytorch"
14+
# ./build_fts_env.sh --repo-home=${HOME}/repos/finetuning-scheduler --target-env-name=fts_latest --from-source="lightning:${HOME}/repos/lightning:pytorch"
1515
#
1616
# To configure PyTorch version (nightly/test/stable), edit requirements/ci/torch-pre.txt
1717
set -eo pipefail
@@ -32,30 +32,30 @@ source "${SCRIPT_DIR}/infra_utils.sh"
3232
usage(){
3333
>&2 cat << EOF
3434
Usage: $0
35-
[ --repo_home input]
36-
[ --target_env_name input ]
35+
[ --repo-home input]
36+
[ --target-env-name input ]
3737
[ --oldest ] # Use oldest CI requirements (Python 3.10, requirements-oldest.txt)
38-
[ --uv_install_flags "flags" ]
39-
[ --no_commit_pin ]
38+
[ --uv-install-flags "flags" ]
39+
[ --no-commit-pin ]
4040
[ --venv-dir input ]
4141
[ --torch-backend input ] (cpu, cu128, auto; default: cu128 for CUDA 12.8)
4242
[ --from-source "package:path[:extras][:ENV_VAR=value]" ]
4343
[ --help ]
4444
Examples:
4545
# build latest (uses FTS_VENV_BASE or default ~/.venvs):
46-
# ./build_fts_env.sh --repo_home=\${HOME}/repos/finetuning-scheduler --target_env_name=fts_latest
46+
# ./build_fts_env.sh --repo-home=\${HOME}/repos/finetuning-scheduler --target-env-name=fts_latest
4747
# build latest with explicit venv directory (recommended for hardlink performance):
48-
# ./build_fts_env.sh --repo_home=\${HOME}/repos/finetuning-scheduler --target_env_name=fts_latest --venv-dir=/mnt/cache/\${USER}/.venvs
48+
# ./build_fts_env.sh --repo-home=\${HOME}/repos/finetuning-scheduler --target-env-name=fts_latest --venv-dir=/mnt/cache/\${USER}/.venvs
4949
# build oldest (CI oldest build simulation):
50-
# ./build_fts_env.sh --repo_home=\${HOME}/repos/finetuning-scheduler --target_env_name=fts_oldest --oldest --venv-dir=/mnt/cache/\${USER}/.venvs
50+
# ./build_fts_env.sh --repo-home=\${HOME}/repos/finetuning-scheduler --target-env-name=fts_oldest --oldest --venv-dir=/mnt/cache/\${USER}/.venvs
5151
# build release:
52-
# ./build_fts_env.sh --repo_home=\${HOME}/repos/fts-release --target_env_name=fts_release
52+
# ./build_fts_env.sh --repo-home=\${HOME}/repos/fts-release --target-env-name=fts_release
5353
# build latest with no cache:
54-
# ./build_fts_env.sh --repo_home=\${HOME}/repos/finetuning-scheduler --target_env_name=fts_latest --uv_install_flags="--no-cache"
54+
# ./build_fts_env.sh --repo-home=\${HOME}/repos/finetuning-scheduler --target-env-name=fts_latest --uv-install-flags="--no-cache"
5555
# build latest without using CI commit pinning:
56-
# ./build_fts_env.sh --repo_home=\${HOME}/repos/finetuning-scheduler --target_env_name=fts_latest --no_commit_pin
56+
# ./build_fts_env.sh --repo-home=\${HOME}/repos/finetuning-scheduler --target-env-name=fts_latest --no-commit-pin
5757
# build latest from Lightning source:
58-
# ./build_fts_env.sh --repo_home=\${HOME}/repos/finetuning-scheduler --target_env_name=fts_latest --from-source="lightning:\${HOME}/repos/lightning:pytorch"
58+
# ./build_fts_env.sh --repo-home=\${HOME}/repos/finetuning-scheduler --target-env-name=fts_latest --from-source="lightning:\${HOME}/repos/lightning:pytorch"
5959
6060
# To configure PyTorch version, edit requirements/ci/torch-pre.txt:
6161
# Line 1: torch version (e.g., 2.10.0 for test, 2.10.0.dev20251124 for nightly)
@@ -65,7 +65,7 @@ EOF
6565
exit 1
6666
}
6767

68-
args=$(getopt -o '' --long repo_home:,target_env_name:,oldest,uv_install_flags:,no_commit_pin,venv-dir:,torch-backend:,from-source:,help -- "$@")
68+
args=$(getopt -o '' --long repo-home:,repo_home:,target-env-name:,target_env_name:,oldest,uv-install-flags:,uv_install_flags:,no-commit-pin,no_commit_pin,venv-dir:,torch-backend:,from-source:,help -- "$@")
6969
if [[ $? -gt 0 ]]; then
7070
usage
7171
fi
@@ -74,11 +74,11 @@ eval set -- ${args}
7474
while :
7575
do
7676
case $1 in
77-
--repo_home) repo_home=$2 ; shift 2 ;;
78-
--target_env_name) target_env_name=$2 ; shift 2 ;;
77+
--repo-home|--repo_home) repo_home=$2 ; shift 2 ;;
78+
--target-env-name|--target_env_name) target_env_name=$2 ; shift 2 ;;
7979
--oldest) oldest=1 ; shift ;;
80-
--uv_install_flags) uv_install_flags=$2 ; shift 2 ;;
81-
--no_commit_pin) no_commit_pin=1 ; shift ;;
80+
--uv-install-flags|--uv_install_flags) uv_install_flags=$2 ; shift 2 ;;
81+
--no-commit-pin|--no_commit_pin) no_commit_pin=1 ; shift ;;
8282
--venv-dir) venv_dir=$2 ; shift 2 ;;
8383
--torch-backend) torch_backend=$2 ; shift 2 ;;
8484
--from-source)
@@ -167,7 +167,7 @@ fts_install(){
167167
unset PACKAGE_NAME
168168
cd ${repo_home}
169169

170-
# Set UV_OVERRIDE for Lightning commit pin, unless --no_commit_pin is specified
170+
# Set UV_OVERRIDE for Lightning commit pin, unless --no-commit-pin is specified
171171
local override_file="${repo_home}/requirements/ci/overrides.txt"
172172
if [[ -z ${no_commit_pin} ]]; then
173173
export UV_OVERRIDE="${override_file}"

scripts/gen_fts_coverage.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ all_supported_pattern="@($(join_by_pipe "${supported_fts_latest[@]}" "${supporte
126126

127127
env_rebuild(){
128128
# Build command arguments array
129-
local -a cmd_args=("${repo_home}/scripts/build_fts_env.sh" "--repo_home=${repo_home}" "--target_env_name=$1")
129+
local -a cmd_args=("${repo_home}/scripts/build_fts_env.sh" "--repo-home=${repo_home}" "--target-env-name=$1")
130130

131131
# Add oldest flag if specified
132132
if [[ $oldest -eq 1 ]]; then
@@ -135,12 +135,12 @@ env_rebuild(){
135135

136136
# Add uv_install_flags if specified
137137
if [[ -n "${uv_install_flags}" ]]; then
138-
cmd_args+=("--uv_install_flags=${uv_install_flags}")
138+
cmd_args+=("--uv-install-flags=${uv_install_flags}")
139139
fi
140140

141-
# Add no_commit_pin flag if specified
141+
# Add no-commit-pin flag if specified
142142
if [[ $no_commit_pin -eq 1 ]]; then
143-
cmd_args+=("--no_commit_pin")
143+
cmd_args+=("--no-commit-pin")
144144
fi
145145

146146
# Add venv-dir flag if specified

0 commit comments

Comments
 (0)