update lightning pin, bump latest supported lightning patch version, resolve issue #19, prepare for FTS patch release 2.5.3

Author: speediedan

.azure-pipelines/gpu-tests.yml

@@ -46,7 +46,7 @@ jobs:
     strategy:
       matrix:
         'PyTorch | latest':
-          image: "speediedan/finetuning-scheduler:py3.12-pt2.5.1-pl2.5-azpl-init"
+          image: "speediedan/finetuning-scheduler:py3.12-pt2.8.0-pl2.5-azpl-init"
           scope: ""
     # how long to run the job before automatically cancelling
     timeoutInMinutes: "100"

CHANGELOG.md

@@ -4,6 +4,17 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
+## [2.5.3] - 2025-03-27
+
+### Added
+
+- Support for Lightning ``2.5.2`` and ``2.5.3``
+
+### Fixed
+
+- Updated explicit pytorch version mapping matrix to include recent PyTorch release
+- Fixed newly failing test dependent on deprecated Lightning class attribute. Resolved [#19](https://github.com/speediedan/finetuning-scheduler/issues/19).
+
 ## [2.5.1] - 2025-03-27
 
 ### Added

CITATION.cff

@@ -6,7 +6,7 @@ date-released: 2022-02-04
 authors:
   - family-names: "Dale"
     given-names: "Dan"
-version: 2.5.1
+version: 2.5.3
 identifiers:
   - description: "Fine-Tuning Scheduler (all versions)"
     type: doi

dockers/base-cuda/Dockerfile

@@ -11,13 +11,13 @@
 # limitations under the License.
 # initially based on https://bit.ly/3pdAf1G
 
-ARG CUDA_VERSION=12.4.0
+ARG CUDA_VERSION=12.8.1
 ARG OS_VER=ubuntu22.04
 
 FROM nvidia/cuda:${CUDA_VERSION}-devel-${OS_VER}
 
 ARG PYTHON_VERSION=3.12
-ARG PYTORCH_VERSION=2.5.1
+ARG PYTORCH_VERSION=2.8.0
 ARG CUST_BUILD=0
 ARG MKL_THREADING_LAYER=GNU
 
@@ -84,7 +84,7 @@ RUN \
     else \
         # or target a specific cuda build, by specifying a particular index url w/...
         # ... default channel
-        pip install torch==2.5.1 torchvision==0.20.1 --index-url https://download.pytorch.org/whl/cu124; \
+        pip install torch==2.8.0 torchvision==0.23.0 --index-url https://download.pytorch.org/whl/cu128; \
         # ... pytorch patch version
         # pip install torch==1.11.1+cu113 torchvision==0.11.3+cu113 -f https://download.pytorch.org/whl/cu113/torch_stable.html; \
         # ... pytorch nightly dev version

dockers/docker_images_main.sh

@@ -40,7 +40,7 @@ maybe_build(){
 
 build_eval(){
 	# latest PyTorch image supported by release
-	declare -A iv=(["cuda"]="12.4.0" ["python"]="3.12" ["pytorch"]="2.5.1" ["lightning"]="2.5" ["cust_build"]="1")
+	declare -A iv=(["cuda"]="12.8.1" ["python"]="3.12" ["pytorch"]="2.8.0" ["lightning"]="2.5" ["cust_build"]="1")
 	export latest_pt="base-cu${iv["cuda"]}-py${iv["python"]}-pt${iv["pytorch"]}-pl${iv["lightning"]}"
 	export latest_azpl="py${iv["python"]}-pt${iv["pytorch"]}-pl${iv["lightning"]}-azpl-init"
 	maybe_build iv "${latest_pt}" "${latest_azpl}"

dockers/docker_images_release.sh

@@ -39,7 +39,7 @@ maybe_build(){
 
 build_eval(){
 	# latest PyTorch image supported by release
-	declare -A iv=(["cuda"]="12.4.0" ["python"]="3.12" ["pytorch"]="2.5.1" ["lightning"]="2.5" ["cust_build"]="0")
+	declare -A iv=(["cuda"]="12.8.1" ["python"]="3.12" ["pytorch"]="2.8.0" ["lightning"]="2.5" ["cust_build"]="0")
 	export latest_pt="base-cu${iv["cuda"]}-py${iv["python"]}-pt${iv["pytorch"]}-pl${iv["lightning"]}"
 	export latest_azpl="py${iv["python"]}-pt${iv["pytorch"]}-pl${iv["lightning"]}-azpl-init"
 	maybe_build iv "${latest_pt}" "${latest_azpl}"

dockers/fts-az-base/Dockerfile

@@ -11,7 +11,7 @@
 # limitations under the License.
 
 ARG PYTHON_VERSION=3.12
-ARG PYTORCH_VERSION=2.5.1
+ARG PYTORCH_VERSION=2.8.0
 ARG LIGHTNING_VERSION=2.5
 ARG CUST_BASE
 

pyproject.toml

@@ -7,11 +7,11 @@ requires = [
 [tool.ruff]
 line-length = 120
 # Enable Pyflakes `E` and `F` codes by default.
-select = [
+lint.select = [
     "E", "W",  # see: https://pypi.org/project/pycodestyle
     "F",  # see: https://pypi.org/project/pyflakes
 ]
-ignore = [
+lint.ignore = [
     "E731", # Do not assign a lambda expression, use a def
 ]
 # Exclude a variety of commonly ignored directories.
@@ -23,17 +23,17 @@ exclude = [
     "build",
     "temp",
 ]
-ignore-init-module-imports = true
+lint.ignore-init-module-imports = true
 output-format = "pylint"
 
-[tool.ruff.per-file-ignores]
+[tool.ruff.lint.per-file-ignores]
 "src/fts_examples/ipynb_src/fts_superglue_nb.py" = ["E501","F401","F821"]
 
-[tool.ruff.mccabe]
+[tool.ruff.lint.mccabe]
 # Unlike Flake8, default to a complexity level of 10.
 max-complexity = 10
 
-[tool.ruff.isort]
+[tool.ruff.lint.isort]
 known-first-party = ["docs","fts_examples","finetuning_scheduler","tests"]
 force-sort-within-sections = false
 order-by-type = false

requirements/base.txt

@@ -1,4 +1,4 @@
-lightning>=2.5.0,<2.5.2
-# the below is uncommented when master is targeting a specific pl dev master commit
+lightning>=2.5.0,<2.5.4
+# the below is uncommented when main is targeting a specific pl dev master commit
 # git+https://github.com/Lightning-AI/lightning.git@878ecf56b06d5ae3f482e146e78accabc685bfc7#egg=lightning
 torch>=2.2.0

requirements/lightning_pin.txt

@@ -0,0 +1 @@
+947f9391656198b7bd0808e59a5e1756d36cc386