Refactor tests and improve smoketest coverage

- Remove railtie_test.rb (now covered by smoketest)
- Add rake task test to smoketest to verify metrics disabled during db: tasks
- Update verify_metrics.rb to check for forbidden metrics
- Refactor high-complexity test methods:
  - PumaTest#test_collects_metrics_with_clustered_mode_stats (57.6 → 4.5)
  - SidekiqTest#test_monitors_all_queues_by_default (45.9 → 5.6)
  - SidekiqTest#test_filters_queues_when_configured (45.9 → 5.6)
- Configure flog/flay to only scan lib and test directories
- Exclude smoketest directory from standard linting

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: nateberkopec

.standard.yml

@@ -2,6 +2,9 @@
 #   https://github.com/standardrb/standard
 ruby_version: 2.7
 
+ignore:
+  - 'smoketest/**/*'
+
 require:
   - ./.rubocop/forbidden_methods.rb
 

Gemfile

@@ -13,3 +13,4 @@ gem "rack"
 gem "rake", "~> 13.0"
 gem "sidekiq"
 gem "standard", ">= 1.35.1"
+gem "rails"

Gemfile.lock

@@ -7,6 +7,85 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
+    actioncable (7.1.6)
+      actionpack (= 7.1.6)
+      activesupport (= 7.1.6)
+      nio4r (~> 2.0)
+      websocket-driver (>= 0.6.1)
+      zeitwerk (~> 2.6)
+    actionmailbox (7.1.6)
+      actionpack (= 7.1.6)
+      activejob (= 7.1.6)
+      activerecord (= 7.1.6)
+      activestorage (= 7.1.6)
+      activesupport (= 7.1.6)
+      mail (>= 2.7.1)
+      net-imap
+      net-pop
+      net-smtp
+    actionmailer (7.1.6)
+      actionpack (= 7.1.6)
+      actionview (= 7.1.6)
+      activejob (= 7.1.6)
+      activesupport (= 7.1.6)
+      mail (~> 2.5, >= 2.5.4)
+      net-imap
+      net-pop
+      net-smtp
+      rails-dom-testing (~> 2.2)
+    actionpack (7.1.6)
+      actionview (= 7.1.6)
+      activesupport (= 7.1.6)
+      cgi
+      nokogiri (>= 1.8.5)
+      racc
+      rack (>= 2.2.4)
+      rack-session (>= 1.0.1)
+      rack-test (>= 0.6.3)
+      rails-dom-testing (~> 2.2)
+      rails-html-sanitizer (~> 1.6)
+    actiontext (7.1.6)
+      actionpack (= 7.1.6)
+      activerecord (= 7.1.6)
+      activestorage (= 7.1.6)
+      activesupport (= 7.1.6)
+      globalid (>= 0.6.0)
+      nokogiri (>= 1.8.5)
+    actionview (7.1.6)
+      activesupport (= 7.1.6)
+      builder (~> 3.1)
+      cgi
+      erubi (~> 1.11)
+      rails-dom-testing (~> 2.2)
+      rails-html-sanitizer (~> 1.6)
+    activejob (7.1.6)
+      activesupport (= 7.1.6)
+      globalid (>= 0.3.6)
+    activemodel (7.1.6)
+      activesupport (= 7.1.6)
+    activerecord (7.1.6)
+      activemodel (= 7.1.6)
+      activesupport (= 7.1.6)
+      timeout (>= 0.4.0)
+    activestorage (7.1.6)
+      actionpack (= 7.1.6)
+      activejob (= 7.1.6)
+      activerecord (= 7.1.6)
+      activesupport (= 7.1.6)
+      marcel (~> 1.0)
+    activesupport (7.1.6)
+      base64
+      benchmark (>= 0.3)
+      bigdecimal
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      connection_pool (>= 2.2.5)
+      drb
+      i18n (>= 1.6, < 2)
+      logger (>= 1.4.2)
+      minitest (>= 5.1)
+      mutex_m
+      securerandom (>= 0.3)
+      tzinfo (~> 2.0)
     ast (2.4.3)
     aws-eventstream (1.4.0)
     aws-partitions (1.1179.0)
@@ -24,10 +103,15 @@ GEM
     aws-sigv4 (1.12.1)
       aws-eventstream (~> 1, >= 1.0.2)
     base64 (0.3.0)
+    benchmark (0.5.0)
     bigdecimal (3.3.1)
+    builder (3.3.0)
     cgi (0.5.0)
+    concurrent-ruby (1.3.5)
     connection_pool (2.5.4)
+    crass (1.0.6)
     date (3.5.0)
+    drb (2.2.3)
     erb (4.0.4)
       cgi (>= 0.3.3)
     erubi (1.13.1)
@@ -40,6 +124,10 @@ GEM
       path_expander (~> 1.0)
       ruby_parser (~> 3.1, > 3.1.0)
       sexp_processor (~> 4.8)
+    globalid (1.3.0)
+      activesupport (>= 6.1)
+    i18n (1.14.7)
+      concurrent-ruby (~> 1.0)
     io-console (0.8.1)
     irb (1.15.2)
       pp (>= 0.6.0)
@@ -50,8 +138,35 @@ GEM
     language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
     logger (1.7.0)
+    loofah (2.24.1)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.12.0)
+    mail (2.9.0)
+      logger
+      mini_mime (>= 0.1.1)
+      net-imap
+      net-pop
+      net-smtp
+    marcel (1.1.0)
+    mini_mime (1.1.5)
+    mini_portile2 (2.8.9)
     minitest (5.26.0)
+    mutex_m (0.3.0)
+    net-imap (0.4.22)
+      date
+      net-protocol
+    net-pop (0.1.2)
+      net-protocol
+    net-protocol (0.2.2)
+      timeout
+    net-smtp (0.5.1)
+      net-protocol
     nio4r (2.7.4)
+    nokogiri (1.15.7)
+      mini_portile2 (~> 2.8.2)
+      racc (~> 1.4)
+    nokogiri (1.15.7-arm64-darwin)
+      racc (~> 1.4)
     parallel (1.27.0)
     parser (3.3.10.0)
       ast (~> 2.4.1)
@@ -68,6 +183,44 @@ GEM
       nio4r (~> 2.0)
     racc (1.8.1)
     rack (3.2.3)
+    rack-session (2.1.1)
+      base64 (>= 0.1.0)
+      rack (>= 3.0.0)
+    rack-test (2.2.0)
+      rack (>= 1.3)
+    rackup (2.2.1)
+      rack (>= 3)
+    rails (7.1.6)
+      actioncable (= 7.1.6)
+      actionmailbox (= 7.1.6)
+      actionmailer (= 7.1.6)
+      actionpack (= 7.1.6)
+      actiontext (= 7.1.6)
+      actionview (= 7.1.6)
+      activejob (= 7.1.6)
+      activemodel (= 7.1.6)
+      activerecord (= 7.1.6)
+      activestorage (= 7.1.6)
+      activesupport (= 7.1.6)
+      bundler (>= 1.15.0)
+      railties (= 7.1.6)
+    rails-dom-testing (2.3.0)
+      activesupport (>= 5.0.0)
+      minitest
+      nokogiri (>= 1.6)
+    rails-html-sanitizer (1.6.2)
+      loofah (~> 2.21)
+      nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0)
+    railties (7.1.6)
+      actionpack (= 7.1.6)
+      activesupport (= 7.1.6)
+      cgi
+      irb
+      rackup (>= 1.0.0)
+      rake (>= 12.2)
+      thor (~> 1.0, >= 1.2.2)
+      tsort (>= 0.2)
+      zeitwerk (~> 2.6)
     rainbow (3.1.1)
     rake (13.3.1)
     rdoc (6.15.0)
@@ -101,6 +254,7 @@ GEM
     ruby_parser (3.21.1)
       racc (~> 1.5)
       sexp_processor (~> 4.16)
+    securerandom (0.3.2)
     sexp_processor (4.17.4)
     sidekiq (7.3.9)
       base64
@@ -121,8 +275,17 @@ GEM
       lint_roller (~> 1.1)
       rubocop-performance (~> 1.21.0)
     stringio (3.1.7)
+    thor (1.4.0)
+    timeout (0.4.4)
     tsort (0.2.0)
+    tzinfo (2.0.6)
+      concurrent-ruby (~> 1.0)
     unicode-display_width (2.6.0)
+    websocket-driver (0.8.0)
+      base64
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.5)
+    zeitwerk (2.6.18)
 
 PLATFORMS
   arm64-darwin-24
@@ -135,6 +298,7 @@ DEPENDENCIES
   minitest
   puma
   rack
+  rails
   rake (~> 13.0)
   sidekiq
   speedshop-cloudwatch!

README.md

@@ -38,10 +38,24 @@ This gem is for **infrastructure and queue metrics**, not application performanc
 
 ## Installation
 
-```
+```ruby
 gem `speedshop_cloudwatch`
 ```
 
+```ruby
+# config/initializers/speedshop-cloudwatch.rb
+Speedshop::Cloudwatch::Puma.register
+Speedshop::Cloudwatch::Sidekiq.register
+```
+
+```ruby
+# app/jobs/application_job.rb
+
+class ApplicationJob
+  include Speedshop::Cloudwatch::ActiveJob
+end
+```
+
 ## Configuration
 
 You can configure which integrations are enabled, which metrics are reported, and the CloudWatch namespace for each integration:
@@ -54,7 +68,7 @@ Speedshop::Cloudwatch.configure do |config|
   # Optional: Custom logger (defaults to Rails.logger if available, otherwise STDOUT)
   config.logger = Logger.new(Rails.root.join("log", "cloudwatch.log"))
 
-  # Disable an entire integration
+  # Disable an entire integration.
   config.enabled[:rack] = false
 
   # Customize which metrics to report (whitelist)
@@ -72,33 +86,6 @@ Speedshop::Cloudwatch.configure do |config|
 end
 ```
 
-### Rails
-
-By default, if you're using Rails, the gem automatically inserts the Rack middleware at the top of the middleware stack.
-
-The reporter starts automatically when the first metric is reported - no manual setup required.
-
-If you want full control over initialization, add `require: false` to your Gemfile:
-
-```ruby
-gem 'speedshop_cloudwatch', require: false
-```
-
-Then manually require the core module without the railtie:
-
-```ruby
-require 'speedshop/cloudwatch'
-
-# Insert middleware manually (if using Rack integration)
-Rails.application.config.middleware.insert_before 0, Speedshop::Cloudwatch::RackMiddleware
-
-# Register integrations
-Speedshop::Cloudwatch::Puma.register  # if using Puma
-Speedshop::Cloudwatch::Sidekiq.register  # if using Sidekiq
-
-# Reporter starts automatically when first metric is reported
-```
-
 ### Puma Integration
 
 Add to your `config/puma.rb`:
@@ -185,3 +172,28 @@ QueueLatency - Time job spent waiting in queue before execution (Seconds)
 ```
 
 This metric includes JobClass and QueueName dimensions.
+
+### Rails
+
+We do two things when we're running in a Rails app:
+
+1. Automatically insert a Rack middleware at index 0.
+2. Disable metric collection if running in Rake or a console.
+
+If you want full control over these behaviors, add `require: false` to your Gemfile:
+
+```ruby
+gem 'speedshop_cloudwatch', require: false
+```
+
+Then manually require the core module without the railtie:
+
+```ruby
+# config/initializers/speedshop-cloudwatch.rb
+require 'speedshop/cloudwatch'
+
+# Insert middleware manually (if using Rack integration)
+Rails.application.config.middleware.insert_before 0, Speedshop::Cloudwatch::RackMiddleware
+
+# At this point, the auto-disable behavior in Rake is disabled. You'll have to re-implement yourself.
+```

Rakefile

@@ -15,7 +15,7 @@ end
 
 desc "Run flog"
 task :flog do
-  flog_output = `bundle exec flog -a lib`
+  flog_output = `bundle exec flog -a lib test`
   puts flog_output
   method_scores = flog_output.lines.grep(/^\s+[0-9]+\.[0-9]+:.*#/).map { |line| line.split.first.to_f }
   max_score = method_scores.max
@@ -27,7 +27,7 @@ end
 
 desc "Run flay"
 task :flay do
-  flay_output = `bundle exec flay lib`
+  flay_output = `bundle exec flay lib test`
   puts flay_output
   flay_score = flay_output[/Total score.*?=\s*(\d+)/, 1]&.to_i
   if flay_score && flay_score > FLAY_THRESHOLD

smoketest/config/initializers/cloudwatch_stub.rb

@@ -16,9 +16,7 @@
       headers: request.headers
     }
 
-    File.open(Rails.root.join("tmp", "captured_metrics.json"), "w") do |f|
-      f.write(JSON.pretty_generate($captured_metrics))
-    end
+    File.write(Rails.root.join("tmp", "captured_metrics.json"), JSON.pretty_generate($captured_metrics))
 
     {status: 200, body: '<?xml version="1.0"?><PutMetricDataResponse xmlns="http://monitoring.amazonaws.com/doc/2010-08-01/"><ResponseMetadata><RequestId>test-request-id</RequestId></ResponseMetadata></PutMetricDataResponse>'}
   end

smoketest/lib/tasks/test_metric.rake

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+namespace :db do
+  desc "Test that metrics are disabled in db rake tasks"
+  task test_metric_report: :environment do
+    puts "Attempting to report metric from db rake task..."
+    Speedshop::Cloudwatch.reporter.report("RakeTaskMetric", 1, namespace: "Test")
+    puts "Metric report attempted (should be disabled)"
+  end
+end