Remove convert_dimensions method, dimensions must be hash

Simplifies dimension handling by requiring dimensions to always be a hash. Removes the convert_dimensions method and the unnecessary conditional logic for handling arrays or other types.

Dimensions are now always expected as a hash and converted inline.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: nateberkopec

lib/speedshop/cloudwatch/metric_reporter.rb

@@ -68,7 +68,7 @@ def report(metric:, value:, dimensions: {}, namespace: nil)
 
         return unless metric_allowed?(integration, metric_name)
 
-        dimensions_array = convert_dimensions(dimensions)
+        dimensions_array = dimensions.map { |k, v| {name: k.to_s, value: v.to_s} }
         all_dimensions = dimensions_array + custom_dimensions
 
         @mutex.synchronize do
@@ -144,17 +144,6 @@ def custom_dimensions
       def find_integration_for_metric(metric_name)
         @config.metrics.find { |int, metrics| metrics.include?(metric_name.to_sym) }&.first
       end
-
-      def convert_dimensions(dimensions)
-        case dimensions
-        when Hash
-          dimensions.map { |k, v| {name: k.to_s, value: v.to_s} }
-        when Array
-          dimensions
-        else
-          []
-        end
-      end
     end
   end
 end

test/support/doubles.rb

@@ -10,14 +10,7 @@ def initialize
     end
 
     def report(metric:, value:, dimensions: {}, namespace: nil)
-      dims = if dimensions.is_a?(Hash)
-        dimensions.map { |k, v| {name: k.to_s, value: v.to_s} }
-      elsif dimensions.is_a?(Array)
-        dimensions
-      else
-        []
-      end
-
+      dims = dimensions.map { |k, v| {name: k.to_s, value: v.to_s} }
       @metrics_collected << {name: metric.to_s, value: value, dimensions: dims, namespace: namespace}
     end