Update report.file() to include file metadata #1553
Conversation
- Extracted file metadata logic from `eldritch-libfile` into a reusable `metadata_impl` module. - Exposed `get_file_info` in `eldritch-libfile`. - Updated `eldritch-libreport` to depend on `eldritch-libfile`. - Updated `report.file()` to populate `owner`, `group`, and `permissions` in `FileMetadata` using the shared logic.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
…port - Refactor file metadata extraction into a reusable `metadata_impl` module in `eldritch-libfile`. - Implement robust Unix/BSD ownership and permission retrieval using `nix`. - Provide safe Windows fallbacks for metadata retrieval to ensure cross-platform compatibility. - Update `report.file()` in `eldritch-libreport` to utilize the new metadata logic for populating `owner`, `group`, and `permissions`.
|
jules run |
Ran |
…port - Refactored file metadata extraction into a reusable `metadata_impl` module within `eldritch-libfile`, accessible to other libraries. - Implemented robust Unix/BSD ownership and permission retrieval using `nix` and `std::os::unix`, with `as _` casting for broad platform support. - Provided safe fallbacks for Windows systems to ensure cross-platform compatibility. - Updated `report.file()` in `eldritch-libreport` to utilize the new shared logic for populating `owner`, `group`, and `permissions`. - Updated dependencies in `eldritch-libreport` to include `eldritch-libfile`.
| use anyhow::Result as AnyhowResult; | ||
| #[cfg(feature = "stdlib")] | ||
| use std::path::Path; | ||
|
|
There was a problem hiding this comment.
Since the metadata functions aren't actual eldritch impls I think this is confusing.
I'd move theses to mod.rs.
Updated
report.file()to include file metadata (owner, group, permissions) by refactoring and reusing logic fromeldritch-libfile.PR created automatically by Jules for task 12087409698623923300 started by @KCarretto