Merge pull request #10680 from spesmilo/disable_memory_hardening

config: add option to disable memory hardening

Author: SomberNight

electrum/commands.py

@@ -2462,6 +2462,10 @@ def add_global_options(parser, suppress=False):
     group.add_argument(
         "--forgetconfig", action="store_true", dest=SimpleConfig.CONFIG_FORGET_CHANGES.key(), default=None,
         help=argparse.SUPPRESS if suppress else "Forget config on exit")
+    group.add_argument(
+        # Note: default value is False and not None, so that behaviour cannot be modified by editing the config file
+        "--nohardening", action="store_true", dest=SimpleConfig.DISABLE_MEMORY_HARDENING_LINUX.key(), default=False,
+        help=argparse.SUPPRESS if suppress else "Disable memory hardening (linux)")
 
 
 def get_simple_parser():

electrum/simple_config.py

@@ -794,6 +794,8 @@ def __setattr__(self, name, value):
     RPC_SOCKET_TYPE = ConfigVar('rpcsock', default='auto', type_=str)
     RPC_SOCKET_FILEPATH = ConfigVar('rpcsockpath', default=None, type_=str)
 
+    DISABLE_MEMORY_HARDENING_LINUX = ConfigVar('nohardening', default=None, type_=bool) # default is False in add_global_options
+
     GUI_NAME = ConfigVar('gui', default='qt', type_=str)
     CURRENT_WALLET = ConfigVar('current_wallet', default=None, type_=str)
 

run_electrum

@@ -408,6 +408,7 @@ def main():
             'cmd': 'gui',
             SimpleConfig.GUI_NAME.key(): 'qml',
             SimpleConfig.WALLET_SHOULD_USE_SINGLE_PASSWORD.key(): True,
+            SimpleConfig.DISABLE_MEMORY_HARDENING_LINUX.key(): True,
         }
         SimpleConfig.set_chain_config_opt_based_on_android_packagename(config_options)
     else:
@@ -458,7 +459,7 @@ def main():
         print_stderr('unknown command:', uri)
         sys.exit(1)
 
-    if sys.platform == "linux" and not is_android:
+    if sys.platform == "linux" and not config.DISABLE_MEMORY_HARDENING_LINUX:
         import electrum.harden_memory_linux
         electrum.harden_memory_linux.set_dumpable_safe(False)