Skip to content

Commit ffc84ab

Browse files
committed
tests: fix warning in test_lntransport.py::TestLNTransport::test_loop
$ python3 -X dev -m pytest tests/test_lntransport.py ``` =============================== warnings summary =============================== tests/test_lntransport.py::TestLNTransport::test_loop /usr/local/lib/python3.11/asyncio/streams.py:414: ResourceWarning: unclosed <StreamWriter transport=<_SelectorSocketTransport closing fd=15 read=idle write=<idle, bufsize=0>> reader=<StreamReader transport=<_SelectorSocketTransport closing fd=15 read=idle write=<idle, bufsize=0>>>> warnings.warn(f"unclosed {self!r}", ResourceWarning) ```
1 parent 1201b87 commit ffc84ab

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

tests/test_lntransport.py

+7
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
import asyncio
2+
from typing import List
23

34
import electrum_ecc as ecc
45

56
from electrum import util
7+
from electrum import lntransport
68
from electrum.lntransport import LNPeerAddr, LNResponderTransport, LNTransport, extract_nodeid, split_host_port, ConnStringFormatError
79
from electrum.util import OldTaskGroup
810

@@ -71,6 +73,7 @@ async def write_messages(transport, expected_messages):
7173

7274
async def cb(reader, writer):
7375
t = LNResponderTransport(responder_key.get_secret_bytes(), reader, writer)
76+
transports.append(t)
7477
self.assertEqual(await t.handshake(), initiator_key.get_public_key_bytes())
7578
async with OldTaskGroup() as group:
7679
await group.spawn(read_messages(t, messages_sent_by_client))
@@ -79,12 +82,14 @@ async def cb(reader, writer):
7982
async def connect(port: int):
8083
peer_addr = LNPeerAddr('127.0.0.1', port, responder_key.get_public_key_bytes())
8184
t = LNTransport(initiator_key.get_secret_bytes(), peer_addr, e_proxy=None)
85+
transports.append(t)
8286
await t.handshake()
8387
async with OldTaskGroup() as group:
8488
await group.spawn(read_messages(t, messages_sent_by_server))
8589
await group.spawn(write_messages(t, messages_sent_by_client))
8690
server_shaked.set()
8791

92+
transports = [] # type: List[lntransport.LNTransportBase]
8893
async def f():
8994
server = await asyncio.start_server(cb, '127.0.0.1', port=None)
9095
server_port = server.sockets[0].getsockname()[1]
@@ -94,6 +99,8 @@ async def f():
9499
await group.spawn(responder_shaked.wait())
95100
await group.spawn(server_shaked.wait())
96101
finally:
102+
for t in transports:
103+
t.close()
97104
server.close()
98105

99106
await f()

0 commit comments

Comments
 (0)