viper.ReadInConfig is not using the correct file type set with viper.SetConfigType

[ssi-anik]

Viper version: v1.18.1
Golang Version: go1.21.4 darwin/arm64

Okay, I have read #1408 and it solves the problem.

But going through the code I can see

Viper prepares the filename and checks the file type to see if the type is supported or not.

viper/viper.go

Lines 1623 to 1630 in 0b0a110

	filename, err := v.getConfigFile()
	if err != nil {
	return err
	}
	if !stringInSlice(v.getConfigType(), SupportedExts) {
	return UnsupportedConfigError(v.getConfigType())
	}

When preparing the filename, it checks in the order the SupportedExts is defined.

viper/file.go

Lines 27 to 44 in 0b0a110

	func (v *Viper) searchInPath(in string) (filename string) {
	v.logger.Debug("searching for config in path", "path", in)
	for _, ext := range SupportedExts {
	v.logger.Debug("checking if file exists", "file", filepath.Join(in, v.configName+"."+ext))
	if b, _ := exists(v.fs, filepath.Join(in, v.configName+"."+ext)); b {
	v.logger.Debug("found file", "file", filepath.Join(in, v.configName+"."+ext))
	return filepath.Join(in, v.configName+"."+ext)
	}
	}
	if v.configType != "" {
	if b, _ := exists(v.fs, filepath.Join(in, v.configName)); b {
	return filepath.Join(in, v.configName)
	}
	}
	return ""
	}

So, if I have a .json file and .yaml file in the same directory, it will read the json as it comes first in the supported extensions list.

Even though it checks whether the extension is supported or not, it just ignores that file with the specified file type.
So, it will use configuration.json over configuration.yml for the following scenario.

v.SetConfigName(fileName) // "configuration"
v.SetConfigType(fileType) // "yaml"
v.AddConfigPath(filePath) // "."

Files:

• configuration.yaml
• configuration.json

Maybe this check is done for SetConfigFile.

viper/viper.go

Lines 1628 to 1630 in 0b0a110

	if !stringInSlice(v.getConfigType(), SupportedExts) {
	return UnsupportedConfigError(v.getConfigType())
	}

Maybe you can suggest viper.SupportedExts = []string{"yaml", "yml"} or maybe I am wrong!

But can't it be done to use the specified type without this tweak?

TIA.

[AuZhoomLee]

#1840