Merge pull request #10502 from AA-Turner/ifconfig-fix

`ifconfig`: Add a meta node to fix iteration

Author: tk0miya

sphinx/ext/ifconfig.py

@@ -51,7 +51,7 @@ def process_ifconfig_nodes(app: Sphinx, doctree: nodes.document, docname: str) -
     ns = {confval.name: confval.value for confval in app.config}
     ns.update(app.config.__dict__.copy())
     ns['builder'] = app.builder.name
-    for node in doctree.findall(ifconfig):
+    for node in list(doctree.findall(ifconfig)):
         try:
             res = eval(node['expr'], ns)
         except Exception as err:

tests/roots/test-ext-ifconfig/conf.py

@@ -7,3 +7,4 @@
 def setup(app):
     app.add_config_value('confval1', False, None)
     app.add_config_value('confval2', False, None)
+    app.add_config_value('false_config', False, None)

tests/roots/test-ext-ifconfig/index.rst

@@ -9,3 +9,13 @@ ifconfig
 
    egg
 
+Issue 10496 regression test
+===========================
+
+.. ifconfig:: false_config
+
+   `Link 1 <https://link1.example>`__
+
+.. ifconfig:: false_config
+
+   `Link 2 <https://link2.example>`__