Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline_all_toctrees() contains a non-specific except block that masks other issues. #5138

Open
liffiton opened this issue Jul 1, 2018 · 1 comment
Labels
api type:proposal a feature suggestion

Comments

@liffiton
Copy link

liffiton commented Jul 1, 2018

Problem

I'm using an extension that fails when using singlehtml, raising an exception during util/nodes.py:inline_all_toctrees(). The extension's node class doesn't play nice with _new_copy(), apparently. The exception is caught by the bare except Exception: line in util/nodes.py:inline_all_toctrees(), emitting a warning that a referenced document does not exist, even though the document does exist and the error is something else entirely.

Expected results

I think ideally this except block would only trigger on Exceptions that actually result from nonexistent files, letting all other exceptions bubble up.

@tk0miya
Copy link
Member

tk0miya commented Aug 26, 2018

+0; I don't think this is a bug. But it is reasonable.

@tk0miya tk0miya added type:proposal a feature suggestion api prio:low labels Aug 26, 2018
@AA-Turner AA-Turner added this to the some future version milestone Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api type:proposal a feature suggestion
Projects
None yet
Development

No branches or pull requests

3 participants