Commit 452076e
Fix github recipe: document required token scopes and cap comments at 75
Two datasets in this recipe cannot load with the token the README describes,
and one param is silently clamped by the runtime.
1. spiceai.stargazers and apache.members select the user 'email' field
(connector-github stargazers.rs / members.rs), which GitHub only returns
for tokens carrying 'read:user' or 'user:email'. A token with just 'repo'
— all the prerequisite implies — fails both datasets at load. Spell out
the scopes the recipe actually needs.
2. github_max_comments_fetched was set to 100, above the connector's hard cap
of 75 (MAX_COMMENTS_FETCHED in connector-github/src/lib.rs). The runtime
clamps it and logs a warning, so the configured value never took effect.
Set it to the real maximum.
Also corrects a 'Setp 2.' typo.1 parent 06b0086 commit 452076e
2 files changed
Lines changed: 10 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
12 | 20 | | |
13 | 21 | | |
14 | 22 | | |
| |||
24 | 32 | | |
25 | 33 | | |
26 | 34 | | |
27 | | - | |
| 35 | + | |
28 | 36 | | |
29 | 37 | | |
30 | 38 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
0 commit comments