Skip to content

Commit 8b97e57

Browse files
Claudelukekim
authored andcommitted
Fix duckdb/connector recipe: correct the startup log the reader is told to confirm
Step 4 tells the reader to confirm the dataset loaded by looking for 'INFO runtime: Loaded dataset: tpch_customer'. That log message no longer exists anywhere in the runtime, so the check can never succeed. The runtime now prints 'Dataset tpch_customer registered (duckdb:customer), results cache enabled.' from runtime::init::dataset. The same block also pasted two lines the runtime no longer emits: the 'spiced: Metrics listening' line (the metrics server is off by default on v2) and 'runtime::opentelemetry: Spice Runtime OpenTelemetry listening on 127.0.0.1:50052' (that listener was removed). Step 5's result table also predates the column type row the v2 SQL REPL prints. The data itself is unchanged and still matches TPC-H sf=1.
1 parent f759b16 commit 8b97e57

1 file changed

Lines changed: 24 additions & 22 deletions

File tree

duckdb/connector/README.md

Lines changed: 24 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -89,15 +89,16 @@ datasets:
8989
spice run
9090
```
9191

92-
Confirm in the terminal output the `tpch_customer` dataset has been loaded:
92+
Confirm in the terminal output the `tpch_customer` dataset has been registered:
9393

9494
```bash
9595
Spice.ai runtime starting...
96-
2024-04-29T18:23:18.055782Z INFO spiced: Metrics listening on 127.0.0.1:9090
97-
2024-04-29T18:23:18.059972Z INFO runtime: Loaded dataset: tpch_customer
98-
2024-04-29T18:23:18.060005Z INFO runtime::opentelemetry: Spice Runtime OpenTelemetry listening on 127.0.0.1:50052
99-
2024-04-29T18:23:18.062230Z INFO runtime::http: Spice Runtime HTTP listening on 127.0.0.1:8090
100-
2024-04-29T18:23:18.062249Z INFO runtime::flight: Spice Runtime Flight listening on 127.0.0.1:50051
96+
2026-08-12T12:08:20.649413Z INFO spiced: Starting runtime v2.1.4+models.metal
97+
2026-08-12T12:08:20.651520Z INFO runtime::init::dataset: Dataset tpch_customer initializing...
98+
2026-08-12T12:08:20.660420Z INFO runtime::init::dataset: Dataset tpch_customer registered (duckdb:customer), results cache enabled. duration_ms=0
99+
2026-08-12T12:08:20.764115Z INFO runtime: All components are loaded. Spice runtime is ready!
100+
2026-08-12T12:08:20.851410Z INFO runtime::flight: Spice Runtime Flight listening on 127.0.0.1:50051
101+
2026-08-12T12:08:20.851788Z INFO runtime::http: Spice Runtime HTTP listening on 127.0.0.1:8090
101102
```
102103

103104
**Step 5.** Run queries against the dataset using the Spice SQL REPL.
@@ -115,22 +116,23 @@ select c_name, c_address, c_acctbal, c_mktsegment from tpch_customer limit 10;
115116
```
116117

117118
```sql
118-
+--------------------+---------------------------------------+-----------+--------------+
119-
| c_name | c_address | c_acctbal | c_mktsegment |
120-
+--------------------+---------------------------------------+-----------+--------------+
121-
| Customer#000000001 | j5JsirBM9PsCy0O1m | 711.56 | BUILDING |
122-
| Customer#000000002 | 487LW1dovn6Q4dMVymKwwLE9OKf3QG | 121.65 | AUTOMOBILE |
123-
| Customer#000000003 | fkRGN8nY4pkE | 7498.12 | AUTOMOBILE |
124-
| Customer#000000004 | 4u58h fqkyE | 2866.83 | MACHINERY |
125-
| Customer#000000005 | hwBtxkoBF qSW4KrIk5U 2B1AU7H | 794.47 | HOUSEHOLD |
126-
| Customer#000000006 | g1s,pzDenUEBW3O,2 pxu0f9n2g64rJrt5E | 7638.57 | AUTOMOBILE |
127-
| Customer#000000007 | 8OkMVLQ1dK6Mbu6WG9 w4pLGQ n7MQ | 9561.95 | AUTOMOBILE |
128-
| Customer#000000008 | j,pZ,Qp,qtFEo0r0c 92qobZtlhSuOqbE4JGV | 6819.74 | BUILDING |
129-
| Customer#000000009 | vgIql8H6zoyuLMFNdAMLyE7 H9 | 8324.07 | FURNITURE |
130-
| Customer#000000010 | Vf mQ6Ug9Ucf5OKGYq fsaX AtfsO7,rwY | 2753.54 | HOUSEHOLD |
131-
+--------------------+---------------------------------------+-----------+--------------+
132-
133-
Time: 0.003510375 seconds. 10 rows.
119+
+--------------------+---------------------------------------+---------------+--------------+
120+
| c_name | c_address | c_acctbal | c_mktsegment |
121+
| varchar | varchar | decimal(15,2) | varchar |
122+
+--------------------+---------------------------------------+---------------+--------------+
123+
| Customer#000000001 | j5JsirBM9PsCy0O1m | 711.56 | BUILDING |
124+
| Customer#000000002 | 487LW1dovn6Q4dMVymKwwLE9OKf3QG | 121.65 | AUTOMOBILE |
125+
| Customer#000000003 | fkRGN8nY4pkE | 7498.12 | AUTOMOBILE |
126+
| Customer#000000004 | 4u58h fqkyE | 2866.83 | MACHINERY |
127+
| Customer#000000005 | hwBtxkoBF qSW4KrIk5U 2B1AU7H | 794.47 | HOUSEHOLD |
128+
| Customer#000000006 | g1s,pzDenUEBW3O,2 pxu0f9n2g64rJrt5E | 7638.57 | AUTOMOBILE |
129+
| Customer#000000007 | 8OkMVLQ1dK6Mbu6WG9 w4pLGQ n7MQ | 9561.95 | AUTOMOBILE |
130+
| Customer#000000008 | j,pZ,Qp,qtFEo0r0c 92qobZtlhSuOqbE4JGV | 6819.74 | BUILDING |
131+
| Customer#000000009 | vgIql8H6zoyuLMFNdAMLyE7 H9 | 8324.07 | FURNITURE |
132+
| Customer#000000010 | Vf mQ6Ug9Ucf5OKGYq fsaX AtfsO7,rwY | 2753.54 | HOUSEHOLD |
133+
+--------------------+---------------------------------------+---------------+--------------+
134+
135+
Time: 0.004229833 seconds. 10 rows.
134136
```
135137

136138
## Learn more

0 commit comments

Comments
 (0)