clippy

Author: phillipleblanc

ballista/core/src/extension.rs

@@ -38,6 +38,10 @@ use tonic::service::Interceptor;
 use tonic::transport::Endpoint;
 use tonic::{Request, Status};
 
+/// Type alias for the endpoint override function used in gRPC client configuration
+pub type EndpointOverrideFn =
+    Arc<dyn Fn(Endpoint) -> Result<Endpoint, Box<dyn Error + Send + Sync>> + Send + Sync>;
+
 /// Provides methods which adapt [SessionState]
 /// for Ballista usage
 pub trait SessionStateExt {
@@ -156,11 +160,7 @@ pub trait SessionConfigExt {
 
     fn with_ballista_override_create_grpc_client_endpoint(
         self,
-        override_f: Arc<
-            dyn Fn(Endpoint) -> Result<Endpoint, Box<dyn Error + Send + Sync>>
-                + Send
-                + Sync,
-        >,
+        override_f: EndpointOverrideFn,
     ) -> Self;
 
     fn ballista_override_create_grpc_client_endpoint(
@@ -635,19 +635,11 @@ impl Interceptor for BallistaGrpcMetadataInterceptor {
 
 #[derive(Clone)]
 pub struct BallistaConfigGrpcEndpoint {
-    override_f: Arc<
-        dyn Fn(Endpoint) -> Result<Endpoint, Box<dyn Error + Send + Sync>> + Send + Sync,
-    >,
+    override_f: EndpointOverrideFn,
 }
 
 impl BallistaConfigGrpcEndpoint {
-    pub fn new(
-        override_f: Arc<
-            dyn Fn(Endpoint) -> Result<Endpoint, Box<dyn Error + Send + Sync>>
-                + Send
-                + Sync,
-        >,
-    ) -> Self {
+    pub fn new(override_f: EndpointOverrideFn) -> Self {
         Self { override_f }
     }
 

ballista/executor/src/executor_process.rs

@@ -58,6 +58,10 @@ use ballista_core::utils::{
 use ballista_core::{ConfigProducer, RuntimeProducer, BALLISTA_VERSION};
 use tonic::transport::{Endpoint, Error as TonicTransportError};
 
+/// Type alias for the endpoint override function used in gRPC client configuration
+pub type EndpointOverrideFn =
+    Arc<dyn Fn(Endpoint) -> Result<Endpoint, TonicTransportError> + Send + Sync>;
+
 use crate::execution_engine::ExecutionEngine;
 use crate::executor::{Executor, TasksDrainedFuture};
 use crate::executor_server::TERMINATING;
@@ -106,9 +110,7 @@ pub struct ExecutorProcessConfig {
     /// [ArrowFlightServerProvider] implementation override option
     pub override_arrow_flight_service: Option<Arc<ArrowFlightServerProvider>>,
     /// Override function for customizing gRPC client endpoints before they are used
-    pub override_create_grpc_client_endpoint: Option<
-        Arc<dyn Fn(Endpoint) -> Result<Endpoint, TonicTransportError> + Send + Sync>,
-    >,
+    pub override_create_grpc_client_endpoint: Option<EndpointOverrideFn>,
 }
 
 impl ExecutorProcessConfig {

ballista/executor/src/executor_server.rs

@@ -27,6 +27,10 @@ use log::{debug, error, info, warn};
 use tonic::transport::{Channel, Endpoint, Error as TonicTransportError};
 use tonic::{Request, Response, Status};
 
+/// Type alias for the endpoint override function used in gRPC client configuration
+pub type EndpointOverrideFn =
+    Arc<dyn Fn(Endpoint) -> Result<Endpoint, TonicTransportError> + Send + Sync>;
+
 use ballista_core::error::BallistaError;
 use ballista_core::serde::protobuf::{
     executor_grpc_server::{ExecutorGrpc, ExecutorGrpcServer},
@@ -184,9 +188,7 @@ pub struct ExecutorServer<T: 'static + AsLogicalPlan, U: 'static + AsExecutionPl
     schedulers: SchedulerClients,
     grpc_max_encoding_message_size: usize,
     grpc_max_decoding_message_size: usize,
-    override_create_grpc_client_endpoint: Option<
-        Arc<dyn Fn(Endpoint) -> Result<Endpoint, TonicTransportError> + Send + Sync>,
-    >,
+    override_create_grpc_client_endpoint: Option<EndpointOverrideFn>,
 }
 
 #[derive(Clone)]
@@ -213,9 +215,7 @@ impl<T: 'static + AsLogicalPlan, U: 'static + AsExecutionPlan> ExecutorServer<T,
         codec: BallistaCodec<T, U>,
         grpc_max_encoding_message_size: usize,
         grpc_max_decoding_message_size: usize,
-        override_create_grpc_client_endpoint: Option<
-            Arc<dyn Fn(Endpoint) -> Result<Endpoint, TonicTransportError> + Send + Sync>,
-        >,
+        override_create_grpc_client_endpoint: Option<EndpointOverrideFn>,
     ) -> Self {
         Self {
             _start_time: SystemTime::now()

ballista/scheduler/src/config.rs

@@ -34,6 +34,10 @@ use std::fmt::Display;
 use std::sync::Arc;
 use tonic::transport::{Endpoint, Error as TonicTransportError};
 
+/// Type alias for the endpoint override function used in gRPC client configuration
+pub type EndpointOverrideFn =
+    Arc<dyn Fn(Endpoint) -> Result<Endpoint, TonicTransportError> + Send + Sync>;
+
 /// Configuration of the application
 #[cfg(feature = "build-binary")]
 #[derive(clap::Parser, Debug)]
@@ -217,9 +221,7 @@ pub struct SchedulerConfig {
     /// [PhysicalExtensionCodec] override option
     pub override_physical_codec: Option<Arc<dyn PhysicalExtensionCodec>>,
     /// Override function for customizing gRPC client endpoints before they are used
-    pub override_create_grpc_client_endpoint: Option<
-        Arc<dyn Fn(Endpoint) -> Result<Endpoint, TonicTransportError> + Send + Sync>,
-    >,
+    pub override_create_grpc_client_endpoint: Option<EndpointOverrideFn>,
 }
 
 impl Default for SchedulerConfig {

python/src/lib.rs

@@ -47,6 +47,12 @@ pub struct PyBallistaBuilder {
     session_config: SessionConfig,
 }
 
+impl Default for PyBallistaBuilder {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 #[pymethods]
 impl PyBallistaBuilder {
     #[new]