Fix Clippy and lint

Author: lukekim

Cargo.lock

@@ -41,10 +41,10 @@ arrow = { workspace = true }
 arrow-flight = { workspace = true }
 async-trait = { workspace = true }
 
-ballista-core = { path = "../core", version = "51.0.0" }
-
 backoff = { workspace = true }
 
+ballista-core = { path = "../core", version = "51.0.0" }
+
 clap = { workspace = true, optional = true }
 dashmap = { workspace = true }
 datafusion = { workspace = true }

ballista/executor/Cargo.toml

@@ -69,11 +69,15 @@ serde = { workspace = true, features = ["derive"] }
 tokio = { workspace = true, features = ["full"] }
 tokio-stream = { workspace = true, features = ["net"] }
 tonic = { workspace = true, features = ["router"] }
+tonic-prost = { workspace = true }
 tracing = { workspace = true, optional = true }
 tracing-appender = { workspace = true, optional = true }
 tracing-subscriber = { workspace = true, optional = true }
 uuid = { workspace = true }
 
+[build-dependencies]
+tonic-prost-build = { workspace = true }
+
 [dev-dependencies]
 rstest = { workspace = true }
 

ballista/scheduler/Cargo.toml

@@ -20,7 +20,7 @@ fn main() -> Result<(), String> {
     println!("cargo:rerun-if-changed=proto/keda.proto");
 
     #[cfg(feature = "keda-scaler")]
-    tonic_build::configure()
+    tonic_prost_build::configure()
         .compile_protos(&["proto/keda.proto"], &["proto"])
         .map_err(|e| format!("protobuf compilation failed: {e}"))?;
 

ballista/scheduler/build.rs

@@ -20,7 +20,6 @@ use std::time::Duration;
 use ballista_core::error::BallistaError;
 use ballista_core::error::Result;
 use ballista_core::serde::protobuf;
-use ballista_core::utils::GrpcClientConfig;
 use log::trace;
 
 use crate::cluster::{BoundTask, ClusterState, ExecutorSlot};
@@ -37,8 +36,7 @@ use ballista_core::serde::protobuf::{
 use ballista_core::serde::scheduler::{ExecutorData, ExecutorMetadata};
 
 use ballista_core::utils::{
-    GrpcClientConfig, create_grpc_client_connection, create_grpc_client_endpoint,
-    get_time_before,
+    GrpcClientConfig, create_grpc_client_endpoint, get_time_before,
 };
 
 use dashmap::DashMap;
@@ -465,7 +463,7 @@ impl ExecutorManager {
     async fn get_client(
         &self,
         executor_id: &str,
-        grpc_client_config: &GrpcClientConfig,
+        _grpc_client_config: &GrpcClientConfig,
     ) -> Result<ExecutorGrpcClient<Channel>> {
         let client = self.clients.get(executor_id).map(|value| value.clone());
 

ballista/scheduler/src/state/executor_manager.rs

@@ -62,7 +62,7 @@ use std::{
 use structopt::StructOpt;
 use tokio::task::JoinHandle;
 
-#[cfg(feature = "snmalloc")]
+#[cfg(all(feature = "snmalloc", not(feature = "mimalloc")))]
 #[global_allocator]
 static ALLOC: snmalloc_rs::SnMalloc = snmalloc_rs::SnMalloc;