Fix lint

Author: lukekim

ballista/core/src/execution_plans/shuffle_writer.rs

@@ -350,6 +350,7 @@ impl ShuffleWriterExec {
     }
 
     /// Executes shuffle write to disk (original behavior).
+    #[allow(clippy::too_many_arguments)]
     async fn execute_shuffle_write_disk(
         mut path: PathBuf,
         input_partition: usize,
@@ -471,7 +472,7 @@ impl ShuffleWriterExec {
                 let mut part_locs = vec![];
 
                 for (i, w) in writers.into_iter().enumerate() {
-                    if let Some(mut w) = w {
+                    if let Some(w) = w {
                         let num_bytes = fs::metadata(&w.path)?.len();
                         w.writer.finish()?;
                         debug!(

ballista/scheduler/src/api/mod.rs

@@ -19,6 +19,7 @@ use datafusion_proto::logical_plan::AsLogicalPlan;
 use datafusion_proto::physical_plan::AsExecutionPlan;
 use std::sync::Arc;
 
+/// Creates the API routes for the scheduler REST API.
 pub fn get_routes<
     T: AsLogicalPlan + Clone + Send + Sync + 'static,
     U: AsExecutionPlan + Send + Sync + 'static,

ballista/scheduler/src/metrics/mod.rs

@@ -15,6 +15,7 @@
 // specific language governing permissions and limitations
 // under the License.
 
+/// Prometheus metrics collector implementation.
 #[cfg(feature = "prometheus")]
 pub mod prometheus;
 

ballista/scheduler/src/metrics/prometheus.rs

@@ -49,6 +49,7 @@ pub struct PrometheusMetricsCollector {
 }
 
 impl PrometheusMetricsCollector {
+    /// Creates a new PrometheusMetricsCollector with the given registry.
     pub fn new(registry: &Registry) -> Result<Self> {
         let execution_time = register_histogram_with_registry!(
             "job_exec_time_seconds",
@@ -126,14 +127,15 @@ impl PrometheusMetricsCollector {
         })
     }
 
+    /// Returns the current global PrometheusMetricsCollector instance.
     pub fn current() -> Result<Arc<dyn SchedulerMetricsCollector>> {
         COLLECTOR
             .get_or_try_init(|| {
                 let collector = Self::new(::prometheus::default_registry())?;
 
                 Ok(Arc::new(collector) as Arc<dyn SchedulerMetricsCollector>)
             })
-            .map(|arc| arc.clone())
+            .cloned()
     }
 }
 
@@ -206,6 +208,22 @@ impl SchedulerMetricsCollector for PrometheusMetricsCollector {
     }
     fn record_task_retry(&self, _job_id: &str, _stage_id: usize) {}
 
+    // Shuffle affinity - not tracked by default Prometheus collector
+    fn record_task_shuffle_affinity_hit(
+        &self,
+        _job_id: &str,
+        _stage_id: usize,
+        _executor_id: &str,
+    ) {
+    }
+    fn record_task_shuffle_affinity_miss(
+        &self,
+        _job_id: &str,
+        _stage_id: usize,
+        _executor_id: &str,
+    ) {
+    }
+
     // Executor management - not tracked by default Prometheus collector
     fn set_active_executor_count(&self, _count: usize) {}
     fn record_executor_registered(&self, _executor_id: &str) {}

ballista/scheduler/src/scheduler_server/mod.rs

@@ -46,6 +46,7 @@ use crate::state::task_manager::TaskLauncher;
 // include the generated protobuf source as a submodule
 #[cfg(feature = "keda-scaler")]
 #[allow(clippy::all)]
+#[allow(missing_docs)]
 pub mod externalscaler {
     include!(concat!(env!("OUT_DIR"), "/externalscaler.rs"));
 }