You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: Remove non-functional rate control params from GitHub connector docs
The GitHub connector does not consume requests_per_second_limit,
requests_per_minute_limit, rate_control_jitter_min, or
rate_control_jitter_max — they are not in the connector's ParameterSpec
array. The GitHub connector uses its own rate limiter based on GitHub
API X-RateLimit-* response headers, not the generic HTTP rate control
mechanism. Users setting these params have them silently ignored.
Keep max_concurrent_requests which IS wired into the connector.
|`max_concurrent_requests`| Maximum number of concurrent HTTP requests to the same upstream origin. Overrides `runtime.params.http_max_concurrent_requests`. If both are unset, concurrency limiting is disabled. |
116
-
|`requests_per_second_limit`| Maximum number of HTTP requests per second to the same upstream origin. Overrides `runtime.params.http_requests_per_second_limit`. If both are unset, no per-second rate limit is applied. |
117
-
|`requests_per_minute_limit`| Maximum number of HTTP requests per minute to the same upstream origin. Overrides `runtime.params.http_requests_per_minute_limit`. If both are unset, no per-minute rate limit is applied. |
118
-
|`rate_control_jitter_min`| Minimum random delay added before HTTP requests when rate control is active. Defaults to `5ms` when a request-rate limit is configured. |
119
-
|`rate_control_jitter_max`| Maximum random delay added before HTTP requests when rate control is active. Defaults to `10ms` when a request-rate limit is configured. |
120
116
121
-
Multiple datasets targeting the same GitHub endpoint share the same rate controller.
117
+
The GitHub connector uses its own rate limiter based on GitHub API `X-RateLimit-*` response headers. Multiple datasets targeting the same GitHub endpoint share this rate limiter.
0 commit comments