Skip to content

Commit 4ead185

Browse files
ClaudeClaude
authored andcommitted
fix: Correct PostgreSQL accelerator connection pool parameter name and defaults
The docs listed pg_connection_pool_min_idle (default 1) and connection_pool_size (default 5), but the code uses pg_connection_pool_min (default 5) and connection_pool_size (default 10).
1 parent db83140 commit 4ead185

19 files changed

Lines changed: 10 additions & 24 deletions

File tree

website/docs/components/data-accelerators/postgres/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ The connection to PostgreSQL can be configured by providing the following `param
3434
- `prefer`: This mode will try to establish a secure TLS connection if possible, but will connect insecurely if the server does not support TLS.
3535
- `disable`: This mode will not attempt to use a TLS connection, even if the server supports it.
3636
- `pg_sslrootcert`: Optional parameter specifying the path to a custom PEM certificate that the connector will trust.
37-
- `pg_connection_pool_min_idle`: Optional. The minimum number of idle connections to keep open in the pool. Default is `1`.
38-
- `connection_pool_size`: Optional. The maximum number of connections to keep open in the connection pool. Default is `5`.
37+
- `pg_connection_pool_min`: Optional. The minimum number of connections to keep open in the pool, lazily created when requested. Default is `5`.
38+
- `connection_pool_size`: Optional. The maximum number of connections created in the connection pool. Default is `10`.
3939

4040
Configuration `params` are provided in the `acceleration` section of a dataset.
4141

website/versioned_docs/version-1.10.x/components/data-accelerators/postgres/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ The connection to PostgreSQL can be configured by providing the following `param
3434
- `prefer`: This mode will try to establish a secure TLS connection if possible, but will connect insecurely if the server does not support TLS.
3535
- `disable`: This mode will not attempt to use a TLS connection, even if the server supports it.
3636
- `pg_sslrootcert`: Optional parameter specifying the path to a custom PEM certificate that the connector will trust.
37-
- `pg_connection_pool_min_idle`: Optional. The minimum number of idle connections to keep open in the pool. Default is `1`.
38-
- `connection_pool_size`: Optional. The maximum number of connections to keep open in the connection pool. Default is `5`.
37+
- `pg_connection_pool_min`: Optional. The minimum number of connections to keep open in the pool, lazily created when requested. Default is `5`.
38+
- `connection_pool_size`: Optional. The maximum number of connections created in the connection pool. Default is `10`.
3939

4040
Configuration `params` are provided either in the `acceleration` section of a dataset.
4141

website/versioned_docs/version-1.10.x/components/data-connectors/mssql.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ The Microsoft SQL Server Data Connector enables federated/accelerated SQL querie
1212

1313
1. The connector supports SQL Server authentication (SQL Login and Password) only.
1414
1. Spatial types (`geography`) are not supported, and columns with these types will be ignored.
15-
1. `DATETIME2` and `DATETIMEOFFSET` columns are mapped to Arrow `Timestamp(Nanosecond)`. Timestamps outside the nanosecond range (approximately years 1677–2262) will silently return `1970-01-01 UTC`. This is an inherent limitation of Arrow's nanosecond timestamp representation.
1615

1716
:::
1817

website/versioned_docs/version-1.10.x/components/data-connectors/oracle.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ The table below shows the Oracle data types supported, along with the type mappi
117117
:::note
118118

119119
- The Oracle `TIMESTAMP WITH LOCAL TIME ZONE` value is retrieved as a UTC time value.
120-
- `TIMESTAMP`, `TIMESTAMP WITH TIME ZONE`, and `TIMESTAMP WITH LOCAL TIME ZONE` columns with non-zero precision are mapped to `Timestamp(Nanosecond)`. Timestamps outside the nanosecond range (approximately years 1677–2262) will silently return `1970-01-01 UTC`. This is an inherent limitation of Arrow's nanosecond timestamp representation.
121120

122121
:::
123122

website/versioned_docs/version-1.11.x/components/data-accelerators/postgres/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ The connection to PostgreSQL can be configured by providing the following `param
3434
- `prefer`: This mode will try to establish a secure TLS connection if possible, but will connect insecurely if the server does not support TLS.
3535
- `disable`: This mode will not attempt to use a TLS connection, even if the server supports it.
3636
- `pg_sslrootcert`: Optional parameter specifying the path to a custom PEM certificate that the connector will trust.
37-
- `pg_connection_pool_min_idle`: Optional. The minimum number of idle connections to keep open in the pool. Default is `1`.
38-
- `connection_pool_size`: Optional. The maximum number of connections to keep open in the connection pool. Default is `5`.
37+
- `pg_connection_pool_min`: Optional. The minimum number of connections to keep open in the pool, lazily created when requested. Default is `5`.
38+
- `connection_pool_size`: Optional. The maximum number of connections created in the connection pool. Default is `10`.
3939

4040
Configuration `params` are provided in the `acceleration` section of a dataset.
4141

website/versioned_docs/version-1.11.x/components/data-connectors/mssql.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ The Microsoft SQL Server Data Connector enables federated/accelerated SQL querie
1212

1313
1. The connector supports SQL Server authentication (SQL Login and Password) only.
1414
1. Spatial types (`geography`) are not supported, and columns with these types will be ignored.
15-
1. `DATETIME2` and `DATETIMEOFFSET` columns are mapped to Arrow `Timestamp(Nanosecond)`. Timestamps outside the nanosecond range (approximately years 1677–2262) will silently return `1970-01-01 UTC`. This is an inherent limitation of Arrow's nanosecond timestamp representation.
1615

1716
:::
1817

website/versioned_docs/version-1.11.x/components/data-connectors/oracle.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ The table below shows the Oracle data types supported, along with the type mappi
117117
:::note
118118

119119
- The Oracle `TIMESTAMP WITH LOCAL TIME ZONE` value is retrieved as a UTC time value.
120-
- `TIMESTAMP`, `TIMESTAMP WITH TIME ZONE`, and `TIMESTAMP WITH LOCAL TIME ZONE` columns with non-zero precision are mapped to `Timestamp(Nanosecond)`. Timestamps outside the nanosecond range (approximately years 1677–2262) will silently return `1970-01-01 UTC`. This is an inherent limitation of Arrow's nanosecond timestamp representation.
121120

122121
:::
123122

website/versioned_docs/version-1.5.x/components/data-connectors/mssql.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ The Microsoft SQL Server Data Connector enables federated/accelerated SQL querie
1212

1313
1. The connector supports SQL Server authentication (SQL Login and Password) only.
1414
1. Spatial types (`geography`) are not supported, and columns with these types will be ignored.
15-
1. `DATETIME2` and `DATETIMEOFFSET` columns are mapped to Arrow `Timestamp(Nanosecond)`. Timestamps outside the nanosecond range (approximately years 1677–2262) will silently return `1970-01-01 UTC`. This is an inherent limitation of Arrow's nanosecond timestamp representation.
1615

1716
:::
1817

website/versioned_docs/version-1.5.x/components/data-connectors/oracle.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ The table below shows the Oracle data types supported, along with the type mappi
117117
:::note
118118

119119
- The Oracle `TIMESTAMP WITH LOCAL TIME ZONE` value is retrieved as a UTC time value.
120-
- `TIMESTAMP`, `TIMESTAMP WITH TIME ZONE`, and `TIMESTAMP WITH LOCAL TIME ZONE` columns with non-zero precision are mapped to `Timestamp(Nanosecond)`. Timestamps outside the nanosecond range (approximately years 1677–2262) will silently return `1970-01-01 UTC`. This is an inherent limitation of Arrow's nanosecond timestamp representation.
121120

122121
:::
123122

website/versioned_docs/version-1.6.x/components/data-connectors/mssql.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ The Microsoft SQL Server Data Connector enables federated/accelerated SQL querie
1212

1313
1. The connector supports SQL Server authentication (SQL Login and Password) only.
1414
1. Spatial types (`geography`) are not supported, and columns with these types will be ignored.
15-
1. `DATETIME2` and `DATETIMEOFFSET` columns are mapped to Arrow `Timestamp(Nanosecond)`. Timestamps outside the nanosecond range (approximately years 1677–2262) will silently return `1970-01-01 UTC`. This is an inherent limitation of Arrow's nanosecond timestamp representation.
1615

1716
:::
1817

0 commit comments

Comments
 (0)