Skip to content

Commit 8e60476

Browse files
claudespicelukekim
authored andcommitted
fix: Correct Redshift pg_port default and add missing sslmode values
The Redshift docs incorrectly claimed pg_port defaults to 5439. The Postgres connector code has no .default() call on the port parameter, so the underlying tokio-postgres default of 5432 applies. Port 5439 is Redshift's standard port but not a Spice-level default. Updated the description across all doc versions to clarify that users should set this value explicitly. Also added the missing `disable` and `allow` values to the pg_sslmode parameter description in the vNext docs, matching the code's one_of constraint.
1 parent 451621b commit 8e60476

7 files changed

Lines changed: 8 additions & 8 deletions

File tree

website/docs/components/data-connectors/redshift.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,11 +123,11 @@ datasets:
123123
| --------------------------- | ----------------------------------------------------------------------------------------------------------------- |
124124
| `pg_connection_string` | Optional. A [PostgreSQL connection string](https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNSTRING). Overrides individual connection parameters when provided. |
125125
| `pg_host` | Hostname or IP address of the Redshift cluster |
126-
| `pg_port` | Port for Redshift (default: 5439) |
126+
| `pg_port` | The PostgreSQL TCP port. Redshift uses port `5439` by default — set this explicitly. |
127127
| `pg_db` | Database name |
128128
| `pg_user` | Username for authentication |
129129
| `pg_pass` | Password for authentication (use secret reference) |
130-
| `pg_sslmode` | SSL mode (e.g., `prefer`, `require`, `verify-ca`, `verify-full`) |
130+
| `pg_sslmode` | SSL mode (`disable`, `allow`, `prefer`, `require`, `verify-ca`, `verify-full`) |
131131
| `pg_sslrootcert` | Optional. Path to a custom root certificate for SSL verification |
132132
| `pg_connection_pool_min_idle` | Optional. The minimum number of idle connections to keep open in the pool. Default is `1`. |
133133
| `connection_pool_size` | Optional. The maximum number of connections in the connection pool. Default is `5`. |

website/versioned_docs/version-1.10.x/components/data-connectors/redshift.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ datasets:
122122
| Parameter Name | Description |
123123
| -------------- | -------------------------------------------------- |
124124
| `pg_host` | Hostname or IP address of the Redshift cluster |
125-
| `pg_port` | Port for Redshift (default: 5439) |
125+
| `pg_port` | The PostgreSQL TCP port. Redshift uses port `5439` by default — set this explicitly. |
126126
| `pg_sslmode` | SSL mode (e.g., `prefer`) |
127127
| `pg_db` | Database name |
128128
| `pg_user` | Username for authentication |

website/versioned_docs/version-1.11.x/components/data-connectors/redshift.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ datasets:
122122
| Parameter Name | Description |
123123
| -------------- | -------------------------------------------------- |
124124
| `pg_host` | Hostname or IP address of the Redshift cluster |
125-
| `pg_port` | Port for Redshift (default: 5439) |
125+
| `pg_port` | The PostgreSQL TCP port. Redshift uses port `5439` by default — set this explicitly. |
126126
| `pg_sslmode` | SSL mode (e.g., `prefer`) |
127127
| `pg_db` | Database name |
128128
| `pg_user` | Username for authentication |

website/versioned_docs/version-1.6.x/components/data-connectors/redshift.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ datasets:
122122
| Parameter Name | Description |
123123
| -------------- | -------------------------------------------------- |
124124
| `pg_host` | Hostname or IP address of the Redshift cluster |
125-
| `pg_port` | Port for Redshift (default: 5439) |
125+
| `pg_port` | The PostgreSQL TCP port. Redshift uses port `5439` by default — set this explicitly. |
126126
| `pg_sslmode` | SSL mode (e.g., `prefer`) |
127127
| `pg_db` | Database name |
128128
| `pg_user` | Username for authentication |

website/versioned_docs/version-1.7.x/components/data-connectors/redshift.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ datasets:
122122
| Parameter Name | Description |
123123
| -------------- | -------------------------------------------------- |
124124
| `pg_host` | Hostname or IP address of the Redshift cluster |
125-
| `pg_port` | Port for Redshift (default: 5439) |
125+
| `pg_port` | The PostgreSQL TCP port. Redshift uses port `5439` by default — set this explicitly. |
126126
| `pg_sslmode` | SSL mode (e.g., `prefer`) |
127127
| `pg_db` | Database name |
128128
| `pg_user` | Username for authentication |

website/versioned_docs/version-1.8.x/components/data-connectors/redshift.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ datasets:
122122
| Parameter Name | Description |
123123
| -------------- | -------------------------------------------------- |
124124
| `pg_host` | Hostname or IP address of the Redshift cluster |
125-
| `pg_port` | Port for Redshift (default: 5439) |
125+
| `pg_port` | The PostgreSQL TCP port. Redshift uses port `5439` by default — set this explicitly. |
126126
| `pg_sslmode` | SSL mode (e.g., `prefer`) |
127127
| `pg_db` | Database name |
128128
| `pg_user` | Username for authentication |

website/versioned_docs/version-1.9.x/components/data-connectors/redshift.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ datasets:
122122
| Parameter Name | Description |
123123
| -------------- | -------------------------------------------------- |
124124
| `pg_host` | Hostname or IP address of the Redshift cluster |
125-
| `pg_port` | Port for Redshift (default: 5439) |
125+
| `pg_port` | The PostgreSQL TCP port. Redshift uses port `5439` by default — set this explicitly. |
126126
| `pg_sslmode` | SSL mode (e.g., `prefer`) |
127127
| `pg_db` | Database name |
128128
| `pg_user` | Username for authentication |

0 commit comments

Comments
 (0)