fix: Correct Elasticsearch deployment guide pagination claim#1737
Merged
Conversation
The deployment guide stated the connector issues a single `_search` request per query returning at most 10,000 hits and advised users to accelerate for larger result sets. In reality, the connector automatically paginates using PIT + `search_after` for queries without LIMIT or with LIMIT > 10,000 — matching what the connector index.md already documents (corrected in PR #1712) and what the code implements at query_table.rs:231.
✅ Pull with Spice PassedPassing checks:
|
|
🚀 deployed to https://730f0e68.spiceai-org-website.pages.dev |
lukekim
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_searchrequest per query, returning at most 10,000 hits, and advised accelerating for larger result setssearch_afterpagination for queries withoutLIMITor withLIMIT > 10,000, fetching all matching documents in 10,000-hit batchesChanges
website/docs/components/data-connectors/elasticsearch/deployment.mdto match the index.md description and actual code behaviorReference
Verified against spiceai/spiceai at trunk — query_table.rs:231:
use_point_in_time: limit.is_none_or(|limit| limit > ELASTICSEARCH_PAGE_SIZE)