Skip to content

Commit 614eb4a

Browse files
lukekimkrinart
andauthored
ci: define the test dataset inline instead of fetching it from the registry (#78)
`spice add spiceai/quickstart` makes every run depend on the Spicepod registry. That service is currently returning a body the CLI cannot unpack, so every job fails at: Invalid argument: Failed to extract Spicepod archive: invalid Zip archive: Could not find EOCD The runtime and the SDK are fine; only the fetch is broken. Declaring the same dataset spiceai/quickstart provides removes the dependency. Applies to both the Unix and WSL setup steps. Verified locally: taxi_trips loads and is queryable within seconds (2,964,624 rows). Mirrors spicepy#176. Co-authored-by: Viktor Yershov <viktor@spice.ai>
1 parent 922e893 commit 614eb4a

1 file changed

Lines changed: 32 additions & 2 deletions

File tree

.github/workflows/go.yml

Lines changed: 32 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,22 @@ jobs:
7777
}
7878
spice init spice_qs
7979
cd spice_qs
80-
retry spice add spiceai/quickstart
80+
# Define the dataset inline instead of `spice add spiceai/quickstart`.
81+
# Fetching it from the Spicepod registry makes every PR depend on a
82+
# remote service; when that service began returning a non-zip body,
83+
# every run failed at "Failed to extract Spicepod archive: Could not
84+
# find EOCD". This is the dataset spiceai/quickstart defines.
85+
cat >> spicepod.yaml <<'YAML'
86+
87+
datasets:
88+
- from: s3://spiceai-demo-datasets/taxi_trips/2024/
89+
name: taxi_trips
90+
description: taxi trips in s3
91+
params:
92+
file_format: parquet
93+
acceleration:
94+
enabled: true
95+
YAML
8196
spice run &> spice.log &
8297
# Wait for Spice to be ready
8398
echo "Waiting for Spice to be ready..."
@@ -150,7 +165,22 @@ jobs:
150165
# Start a quickstart runtime.
151166
spice init spice_qs
152167
cd spice_qs
153-
retry spice add spiceai/quickstart
168+
# Define the dataset inline instead of `spice add spiceai/quickstart`.
169+
# Fetching it from the Spicepod registry makes every PR depend on a
170+
# remote service; when that service began returning a non-zip body,
171+
# every run failed at "Failed to extract Spicepod archive: Could not
172+
# find EOCD". This is the dataset spiceai/quickstart defines.
173+
cat >> spicepod.yaml <<'YAML'
174+
175+
datasets:
176+
- from: s3://spiceai-demo-datasets/taxi_trips/2024/
177+
name: taxi_trips
178+
description: taxi trips in s3
179+
params:
180+
file_format: parquet
181+
acceleration:
182+
enabled: true
183+
YAML
154184
nohup spice run > spice.log 2>&1 &
155185
cd ..
156186

0 commit comments

Comments
 (0)