Skip to content

Commit 1c6e534

Browse files
committed
fix: CI check failures for spiceai-0.9.0 merge
- Remove unused direct aws-sdk-sts dependency from iceberg-catalog-rest (transitively provided by aws-config), fixing cargo-machete check - Only display limit in IcebergTableScan when set, fixing sqllogictest mismatches in binary and boolean predicate pushdown tests
1 parent 73f50f7 commit 1c6e534

3 files changed

Lines changed: 7 additions & 6 deletions

File tree

Cargo.lock

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/catalog/rest/Cargo.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ async-trait = { workspace = true }
3434
aws-config = { workspace = true, optional = true }
3535
aws-sigv4 = { workspace = true, optional = true }
3636
aws-credential-types = { workspace = true, optional = true }
37-
aws-sdk-sts = { workspace = true, optional = true }
3837
chrono = { workspace = true }
3938
http = { workspace = true }
4039
iceberg = { workspace = true }
@@ -56,4 +55,4 @@ tokio = { workspace = true }
5655
wiremock = "=0.6.4"
5756
[features]
5857
default = ["sigv4"]
59-
sigv4 = ["aws-config", "aws-sigv4", "aws-credential-types", "aws-sdk-sts"]
58+
sigv4 = ["aws-config", "aws-sigv4", "aws-credential-types"]

crates/integrations/datafusion/src/physical_plan/scan.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -190,15 +190,18 @@ impl DisplayAs for IcebergTableScan {
190190
) -> std::fmt::Result {
191191
write!(
192192
f,
193-
"IcebergTableScan projection:[{}] predicate:[{}] limit:[{}]",
193+
"IcebergTableScan projection:[{}] predicate:[{}]",
194194
self.projection
195195
.clone()
196196
.map_or(String::new(), |v| v.join(",")),
197197
self.predicates
198198
.clone()
199199
.map_or(String::from(""), |p| format!("{p}")),
200-
self.limit.map_or(String::from(""), |p| format!("{p}")),
201-
)
200+
)?;
201+
if let Some(limit) = self.limit {
202+
write!(f, " limit:[{limit}]")?;
203+
}
204+
Ok(())
202205
}
203206
}
204207

0 commit comments

Comments
 (0)