Skip to content

Commit 05c3356

Browse files
committed
Update system adapter examples with latest SpiceBench changes
1 parent edf29a0 commit 05c3356

17 files changed

Lines changed: 2184 additions & 199 deletions

File tree

.claude/skills/system-adapter-builder/SKILL.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ A JSON-RPC 2.0 adapter that supports both transports:
1616

1717
Required methods:
1818

19-
- `setup(run_id, metadata)`
20-
- `create_tables(run_id, datasets)`
19+
- `setup(run_id, metadata, datasets, etl_sink_type)`
2120
- `teardown(run_id)`
2221
- `metrics(run_id)`
2322
- `rpc.methods`
@@ -38,7 +37,7 @@ Required methods:
3837
4. Implement `setup` to return:
3938
- `driver`: typically `flightsql` or `databricks`
4039
- `db_kwargs`: real endpoint + auth kwargs for the SUT
41-
5. Implement `create_tables` so the adapter creates/registers benchmark destination tables.
40+
5. Implement `setup` to create/register benchmark destination tables from `datasets`.
4241
6. Implement `teardown` with run-scoped cleanup keyed by `run_id`.
4342
7. Implement `metrics` to return both objects:
4443
- `resource`: CPU, memory, disk bytes, disk IOPS
@@ -72,7 +71,7 @@ If any metric is unavailable, return `0`/`0.0` and document why.
7271

7372
- Adapter responds to all required methods over stdio and HTTP.
7473
- `rpc.methods` includes every exposed method.
75-
- `create_tables` creates/registers benchmark tables for each dataset.
74+
- `setup` creates/registers benchmark tables for each dataset.
7675
- `setup` returns a valid `driver` and complete `db_kwargs`.
7776
- `metrics` returns both `resource` and `ingestion` objects.
7877
- Language build/syntax checks pass:

0 commit comments

Comments
 (0)