Skip to content

Commit 1574b6f

Browse files
peaseeJeadie
authored andcommitted
feat: Connect ETL to spicebench (#49)
* feat: Connect ETL pipeline in spicebench * fix: Update run spicebench args * fix * fix * chore: fmt, move pipeline start to load run * fix log * formatting --------- Co-authored-by: jeadie <jack@spice.ai>
1 parent 16833cf commit 1574b6f

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

.github/workflows/run_spicebench.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,6 @@ jobs:
219219
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
220220
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
221221
RUST_LOG: 'info'
222-
RUST_LOG: 'info'
223222
run: |
224223
ETL_ARGS="--etl-bucket ${ETL_BUCKET} --etl-num-steps ${ETL_NUM_STEPS}"
225224
if [ -n "${ETL_SOURCE_PREFIX}" ]; then

src/main.rs

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -84,17 +84,18 @@ async fn main() -> anyhow::Result<()> {
8484
executor_instance_type: cli.common.executor_instance_type.clone(),
8585
};
8686

87-
let run_suffix = Uuid::new_v4().to_string();
88-
let target_prefix = if cli.common.etl_target_base_prefix.is_empty() {
89-
run_suffix.clone()
90-
} else {
91-
format!("{}/{run_suffix}", cli.common.etl_target_base_prefix)
92-
};
93-
tracing::info!(target_prefix = %target_prefix, "Generated unique ETL target prefix");
94-
9587
let target_config = TargetConfig {
9688
bucket: cli.common.etl_bucket.clone(),
97-
prefix: target_prefix,
89+
prefix: {
90+
let run_suffix = Uuid::new_v4().to_string();
91+
let target_prefix = if cli.common.etl_target_base_prefix.is_empty() {
92+
run_suffix.clone()
93+
} else {
94+
format!("{}/{run_suffix}", cli.common.etl_target_base_prefix)
95+
};
96+
tracing::info!(target_prefix = %target_prefix, "Generated unique ETL target prefix");
97+
target_prefix
98+
},
9899
region: cli.common.etl_region.clone(),
99100
endpoint: cli.common.etl_endpoint.clone(),
100101
table_format: cli.common.table_format.clone(),

0 commit comments

Comments
 (0)