revert debug script

Author: Jeadie

.github/workflows/run_spicebench_debug_spice_cloud.yml

@@ -5,86 +5,86 @@ on:
   workflow_dispatch:
     inputs:
       system_under_test:
-        description: "System under test"
+        description: 'System under test'
         required: true
         default: spice_cloud
         type: choice
         options:
           - spice_cloud
       environment:
-        description: "Target Spice Cloud Environment"
+        description: 'Target Spice Cloud Environment'
         required: true
-        default: "dev"
+        default: 'dev'
         type: choice
         options:
           - dev
           - prod
       scenario:
-        description: "Scenario/query set to run (e.g. tpch)"
+        description: 'Scenario/query set to run (e.g. tpch)'
         required: true
-        default: "tpch"
+        default: 'tpch'
         type: string
       etl_type:
-        description: "ETL type"
+        description: 'ETL type'
         required: true
-        default: "events"
+        default: 'events'
         type: choice
         options:
           - events
           - changes
       scale_factor:
-        description: "Scale Factor"
+        description: 'Scale Factor'
         required: true
-        default: "1"
+        default: '1'
         type: choice
         options:
-          - "0.1"
-          - "1"
-          - "10"
+          - '0.1'
+          - '1'
+          - '10'
       spidapter_version:
-        description: "Spidapter image version tag (e.g. latest, v1.0.0)"
+        description: 'Spidapter image version tag (e.g. latest, v1.0.0)'
         required: false
-        default: "latest"
+        default: 'latest'
         type: string
       num_query_clients:
-        description: "Number of concurrent query clients"
+        description: 'Number of concurrent query clients'
         required: false
-        default: "2"
+        default: '2'
         type: string
       enable_module_debug_logging:
-        description: "Enable debug logs"
+        description: 'Enable debug logs'
         required: false
         default: false
         type: boolean
       disable_teardown:
-        description: "Skip the teardown RPC call to the system adapter"
+        description: 'Skip the teardown RPC call to the system adapter'
         required: false
         default: false
         type: boolean
       enable_pvc:
-        description: "Enable PVC block storage for scheduler and executor pods (sizes are derived from scale_factor)"
+        description: 'Enable PVC block storage for scheduler and executor pods (sizes are derived from scale_factor)'
         required: false
         default: false
         type: boolean
       executor_replicas:
-        description: "Number of executor replicas"
+        description: 'Number of executor replicas'
         required: false
-        default: "4"
+        default: '4'
         type: string
       app_memory_limit:
-        description: "Memory limit for the scheduler (app) pod (e.g. 16Gi, 20Gi)"
+        description: 'Memory limit for the scheduler (app) pod (e.g. 16Gi, 20Gi)'
         required: false
-        default: "16Gi"
+        default: '16Gi'
         type: string
       executor_memory_limit:
-        description: "Memory limit for the executor pod (e.g. 16Gi, 62Gi)"
+        description: 'Memory limit for the executor pod (e.g. 16Gi, 62Gi)'
         required: false
-        default: "16Gi"
+        default: '16Gi'
         type: string
       custom_image:
-        description: "Custom runtime container image (e.g. ghcr.io/spiceai/spiceai-dev:spicebench-sf10). Overrides the default channel image. Requires the internal update channel on the target SCP environment."
+        description: 'Custom runtime container image (e.g. ghcr.io/spiceai/spiceai-dev:spicebench-sf10). Overrides the default channel image. Requires the internal update channel on the target SCP environment.'
         required: false
-        default: ""
+        default: ''
         type: string
 jobs:
   run-spicebench:
@@ -155,15 +155,15 @@ jobs:
           SYSTEM_UNDER_TEST: ${{ github.event.inputs.system_under_test || 'spice_cloud' }}
           SYSTEM_ADAPTER: ${{ github.event.inputs.system_under_test || 'spice_cloud' }}
           NUM_QUERY_CLIENTS: ${{ github.event.inputs.num_query_clients || '2' }}
-          ETL_BUCKET: "spicebench"
+          ETL_BUCKET: 'spicebench'
           ETL_PREFIX: ${{ github.event.inputs.etl_type == 'changes' && 'data-gen-mutable' || 'data-gen' }}
           SCALE_FACTOR: ${{ github.event.inputs.scale_factor || '1' }}
-          ETL_REGION: "us-east-1"
-          ETL_SINK: "adbc"
-          SCHEDULER_STATE_LOCATION: "s3://spiceai-testing-cluster-state/spicebench-scheduler-state-${{ github.run_id }}/"
-          VALIDATE_CHECKPOINT_RESULTS: "true"
+          ETL_REGION: 'us-east-1'
+          ETL_SINK: 'adbc'
+          SCHEDULER_STATE_LOCATION: 's3://spiceai-testing-cluster-state/spicebench-scheduler-state-${{ github.run_id }}/'
+          VALIDATE_CHECKPOINT_RESULTS: 'true'
           ENABLE_MODULE_DEBUG_LOGGING: ${{ github.event.inputs.enable_module_debug_logging || 'false' }}
-          SCRAPE_SUT_METRICS: "true"
+          SCRAPE_SUT_METRICS: 'true'
           SPICEAI_BENCHMARK_METRICS_KEY: ${{ secrets.SPICEAI_BENCHMARK_METRICS_KEY }}
           MINIO_ENDPOINT: ${{ secrets.MINIO_ENDPOINT }}
           AWS_ACCESS_KEY_ID: ${{ secrets.MINIO_ACCESS_KEY_ID }}
@@ -177,7 +177,7 @@ jobs:
           EXECUTOR_REPLICAS: ${{ github.event.inputs.executor_replicas || '4' }}
           SPIDAPTER_APP_MEMORY_LIMIT: ${{ github.event.inputs.app_memory_limit || '16Gi' }}
           SPIDAPTER_EXECUTOR_MEMORY_LIMIT: ${{ github.event.inputs.executor_memory_limit || '16Gi' }}
-          SPIDAPTER_ORGANIZATION_TAG: "spicehq"
+          SPIDAPTER_ORGANIZATION_TAG: 'spicehq'
           CUSTOM_IMAGE: ${{ github.event.inputs.custom_image || '' }}
         run: |
           set -euo pipefail
@@ -221,7 +221,6 @@ jobs:
           export SPICEBENCH_ADBC_UPDATE_STRATEGY=bulk_ingest_upsert
           export SPICEBENCH_ADBC_FLUSH_STREAM_BEFORE_UPSERT=true
           export SPICEBENCH_ADBC_DELETE_BATCH_SIZE=50000
-          export SPICEBENCH_ADBC_SINK_POOL_SIZE=1
           ADAPTER_CMD="docker"
           ADAPTER_DOCKER_OPTS="run -i -e SPIDAPTER_EXECUTOR_REPLICAS=${EXECUTOR_REPLICAS} -e SPICEAI_API_KEY -e SPICE_CLOUD_API_URL -e AWS_ACCESS_KEY_ID=${S3_AWS_ACCESS_KEY_ID} -e AWS_SECRET_ACCESS_KEY=${S3_AWS_SECRET_ACCESS_KEY} -e SPIDAPTER_ICEBERG_REGION -e SPIDAPTER_ICEBERG_CATALOG_FROM -e SCHEDULER_STATE_LOCATION"
 
@@ -246,7 +245,7 @@ jobs:
             SPIDAPTER_IMAGE_NAME="${IMAGE_WITHOUT_TAG#*/}"
 
             echo "Custom image: registry=${SPIDAPTER_IMAGE_REGISTRY}, name=${SPIDAPTER_IMAGE_NAME}, tag=${SPIDAPTER_IMAGE_TAG}"
-            ADAPTER_DOCKER_OPTS="${ADAPTER_DOCKER_OPTS} -e SPIDAPTER_IMAGE_REGISTRY=${SPIDAPTER_IMAGE_REGISTRY} -e SPIDAPTER_IMAGE_NAME=${SPIDAPTER_IMAGE_NAME} -e SPIDAPTER_QUERY_MEMORY_LIMIT=500Gi"
+            ADAPTER_DOCKER_OPTS="${ADAPTER_DOCKER_OPTS} -e SPIDAPTER_IMAGE_REGISTRY=${SPIDAPTER_IMAGE_REGISTRY} -e SPIDAPTER_IMAGE_NAME=${SPIDAPTER_IMAGE_NAME}"
             if [ -n "${SPIDAPTER_IMAGE_TAG}" ]; then
               ADAPTER_DOCKER_OPTS="${ADAPTER_DOCKER_OPTS} -e SPIDAPTER_IMAGE_TAG=${SPIDAPTER_IMAGE_TAG}"
             fi