Fix HEAD / returning 405 and add port auto-increment test (#15)

* Fix HEAD / returning 405 and add port auto-increment test (#15)

The CI setup action health check uses `curl -sf -I` (HEAD request) to
verify spiceio is ready. HEAD on the root path returned 405
MethodNotAllowed, and curl's -f flag suppresses output on 4xx errors,
causing the Server header grep to find nothing and the 30s timeout loop
to expire.

- Handle HEAD at root path alongside GET (ListBuckets)
- Add port auto-increment integration test: starts a second instance
  on the same bind address, verifies it auto-increments, and confirms
  both instances serve S3 requests

* Fix action health check: remove curl -f flag from HEAD requests

The -f flag makes curl suppress output on 4xx responses. Since HEAD /
returns 405 on existing releases, the Server header grep finds nothing
and the startup loop times out after 30s. Removing -f lets curl output
headers regardless of status code.

* Use simple connectivity check for startup health probe

Older spiceio binaries may not set the Server header at all. The startup
health check only needs to confirm the process we just started is
responding — drop the Server header requirement and use a plain GET.

* Bump version to v0.4.2

* Address review feedback on port test and health check

- Port assertion: accept any port in auto-increment range, not just +1
- Summary label: fix misleading per-section counter display
- Health check: add -f back now that HEAD / returns 200

Author: lukekim

.github/actions/setup/action.yml

@@ -82,7 +82,7 @@ runs:
 
         # Check if spiceio is already listening on the requested address
         WANT_VERSION=$(spiceio --version | awk '{print $2}')
-        RUNNING_HEADER=$(curl -sf -I "http://${SPICEIO_BIND}/" 2>/dev/null | grep -i '^server:.*spiceio' | tr -d '\r' || true)
+        RUNNING_HEADER=$(curl -s -I "http://${SPICEIO_BIND}/" 2>/dev/null | grep -i '^server:.*spiceio' | tr -d '\r' || true)
         if [[ -n "$RUNNING_HEADER" ]]; then
           # Extract version from "Server: spiceio/X.Y.Z"; bare "Server: spiceio"
           # (no slash) means a pre-versioned build — treat as outdated.
@@ -160,7 +160,7 @@ runs:
             exit 1
           fi
           ENDPOINT=$(grep 'listening on' "$SPICEIO_LOG" 2>/dev/null | grep -o 'http://[^ ]*' | tail -1 || true)
-          if [[ -n "$ENDPOINT" ]] && curl -sf -I "$ENDPOINT/" 2>/dev/null | grep -qi "server: spiceio"; then
+          if [[ -n "$ENDPOINT" ]] && curl -fsS -o /dev/null "$ENDPOINT/" 2>/dev/null; then
             echo "spiceio ready at $ENDPOINT (PID $PID)"
             echo "endpoint=$ENDPOINT" >> "$GITHUB_OUTPUT"
             exit 0

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "spiceio"
-version = "0.4.1"
+version = "0.4.2"
 edition = "2024"
 description = "S3-compatible API proxy to SMB file shares"
 license = "Apache-2.0"

Cargo.toml

@@ -25,12 +25,17 @@ FAIL=0
 # ── Cleanup on exit ─────────────────────────────────────────────────────────
 
 SPICEIO_PID=""
+SPICEIO_PID2=""
 cleanup() {
     echo ""
     echo "[test] cleaning up..."
     sccache --stop-server 2>/dev/null || true
     # Remove test objects
     $AWS s3 rm "s3://${BUCKET}/${TEST_PREFIX}/" --recursive 2>/dev/null || true
+    if [[ -n "$SPICEIO_PID2" ]]; then
+        kill "$SPICEIO_PID2" 2>/dev/null || true
+        wait "$SPICEIO_PID2" 2>/dev/null || true
+    fi
     if [[ -n "$SPICEIO_PID" ]]; then
         kill "$SPICEIO_PID" 2>/dev/null || true
         wait "$SPICEIO_PID" 2>/dev/null || true
@@ -237,6 +242,96 @@ if [[ "$FAIL" -gt 0 ]]; then
     exit 1
 fi
 
+# ════════════════════════════════════════════════════════════════════════════
+# Port auto-increment test
+# ════════════════════════════════════════════════════════════════════════════
+
+echo ""
+echo "======================================="
+echo "[test] port auto-increment test"
+echo "======================================="
+
+# Start a second instance requesting the same bind address.
+# It should auto-increment to the next port.
+SPICEIO_LOG2=$(mktemp /tmp/spiceio-test-log2.XXXXXX)
+
+SPICEIO_BIND="$BIND" \
+SPICEIO_SMB_SERVER="$SMB_SERVER" \
+SPICEIO_SMB_PORT="$SMB_PORT" \
+SPICEIO_SMB_USER="$SPICEIO_SMB_USER" \
+SPICEIO_SMB_PASS="$SPICEIO_SMB_PASS" \
+SPICEIO_SMB_DOMAIN="$SMB_DOMAIN" \
+SPICEIO_SMB_SHARE="$SMB_SHARE" \
+SPICEIO_BUCKET="$BUCKET" \
+SPICEIO_REGION="$REGION" \
+SPICEIO_LOG_FILE="$SPICEIO_LOG2" \
+"$SPICEIO_BIN" &
+SPICEIO_PID2=$!
+
+echo "[test] waiting for second spiceio instance..."
+ENDPOINT2=""
+for i in $(seq 1 30); do
+    ENDPOINT2=$(grep 'listening on' "$SPICEIO_LOG2" 2>/dev/null | grep -o 'http://[^ ]*' | tail -1 || true)
+    if [[ -n "$ENDPOINT2" ]] && curl -sf -o /dev/null "${ENDPOINT2}/" 2>/dev/null; then
+        break
+    fi
+    if ! kill -0 "$SPICEIO_PID2" 2>/dev/null; then
+        echo "  FAIL: second spiceio exited unexpectedly"
+        FAIL=$((FAIL + 1))
+        SPICEIO_PID2=""
+        break
+    fi
+    sleep 0.5
+done
+
+if [[ -n "$ENDPOINT2" ]]; then
+    echo "[test] second instance at $ENDPOINT2"
+
+    PORT1="${BIND##*:}"
+    PORT2="${ENDPOINT2##*:}"
+    if [[ "$PORT2" =~ ^[0-9]+$ ]] && (( PORT2 > PORT1 && PORT2 <= PORT1 + 100 )); then
+        echo "  PASS: port auto-incremented ($PORT1 -> $PORT2)"
+        PASS=$((PASS + 1))
+    else
+        echo "  FAIL: port should differ from $PORT1 and be within auto-increment range (got $PORT2)"
+        FAIL=$((FAIL + 1))
+    fi
+
+    # Both instances should serve requests
+    assert_ok "first instance health check" curl -sf -o /dev/null "${ENDPOINT}/"
+    assert_ok "second instance health check" curl -sf -o /dev/null "${ENDPOINT2}/"
+
+    # Both should serve S3 operations (same SMB share)
+    GOT1=$($AWS s3 cp "s3://${BUCKET}/${TEST_PREFIX}/small.txt" - 2>/dev/null || echo "FAIL")
+    assert_eq "first instance S3 read" "version2" "$GOT1"
+
+    AWS2="aws --endpoint-url $ENDPOINT2 --no-sign-request"
+    GOT2=$($AWS2 s3 cp "s3://${BUCKET}/${TEST_PREFIX}/small.txt" - 2>/dev/null || echo "FAIL")
+    assert_eq "second instance S3 read" "version2" "$GOT2"
+else
+    echo "  FAIL: second instance did not start"
+    FAIL=$((FAIL + 1))
+fi
+
+# Stop the second instance
+if [[ -n "$SPICEIO_PID2" ]]; then
+    kill "$SPICEIO_PID2" 2>/dev/null || true
+    wait "$SPICEIO_PID2" 2>/dev/null || true
+    SPICEIO_PID2=""
+fi
+rm -f "$SPICEIO_LOG2"
+
+echo ""
+echo "======================================="
+echo "[test] port auto-increment complete"
+echo "[test] cumulative assertions: $PASS passed, $FAIL failed"
+echo "======================================="
+
+if [[ "$FAIL" -gt 0 ]]; then
+    echo "[test] ABORTING — port auto-increment test failed"
+    exit 1
+fi
+
 # ════════════════════════════════════════════════════════════════════════════
 # sccache integration test
 # ════════════════════════════════════════════════════════════════════════════

scripts/test-sccache.sh

@@ -55,7 +55,7 @@ pub async fn handle_request(req: Request<Incoming>, state: &AppState) -> Respons
     // Service-level operations (no bucket)
     if req_bucket.is_empty() {
         match method {
-            Method::GET => {
+            Method::GET | Method::HEAD => {
                 return with_common_headers(
                     list_buckets_response(&state.bucket),
                     &request_id,