Add criterion benchmarks and live throughput bench script (#3)

* Add criterion benchmarks and live throughput bench script

- Add lib.rs to expose modules for external benchmarking
- Criterion benchmarks for crypto (md4, sha256, hmac_md5, hmac_sha256,
  hex_encode) and protocol (header encode/decode, frame_packet,
  build_request, decode responses, parse_directory_entries, NtStatus)
- Live throughput script (scripts/bench-live.sh): single-file write/read
  at 1MB-1GB, multi-file writes, ~10GB total data volume
- Makefile targets: make bench, make bench-live

* Add pre-PR checklist to CLAUDE.md, fix clippy warnings

- Document fmt/clippy/rustdoc/test checks to run before creating PRs
- Add Default impls for MultipartStore and XmlWriter (clippy::new_without_default)

* Address PR #3 review comments

- Add --locked to bench and bench-live build commands
- Use /dev/zero instead of /dev/urandom to avoid RNG bottleneck
- Remove unused human_size function
- Fix aggregate totals and use MiB units consistently
- Update script header with actual dependencies
- Pre-allocate buffers outside b.iter in protocol benchmarks
- Use typed enums (DesiredAccess, ShareAccess, etc.) instead of raw constants

* Run criterion benchmarks in CI

* Address PR #3 review comments (round 2)

- Wrap all benchmark return values in black_box to prevent elision
- CI: compile-check benchmarks (--no-run) instead of running them

Author: lukekim

.github/workflows/ci.yml

@@ -80,6 +80,9 @@ jobs:
           SPICEIO_REGION: ${{ vars.SPICEIO_REGION || 'us-west-1' }}
         run: ./scripts/test-sccache.sh
 
+      - name: Compile benchmarks
+        run: cargo bench --locked --no-run
+
       - name: Build release artifact
         run: cargo build --release --locked --bin spiceio
 

CLAUDE.md

@@ -21,9 +21,27 @@ make release                   # optimized release build
 make lint                      # fmt-check + check + strict clippy + rustdoc warnings
 make test                      # sccache integration test (requires SPICEIO_SMB_USER/PASS)
 make fmt                       # auto-format
+make bench                     # criterion benchmarks (crypto + protocol)
+make bench-live                # live throughput benchmarks against NAS
 make clean                     # cargo clean
 ```
 
+## Pre-PR checklist
+
+Always run these before creating a PR — they mirror what CI checks:
+
+```bash
+cargo fmt --all                # auto-format first
+cargo fmt --all --check        # verify no formatting diff remains
+cargo clippy --locked --all-targets --all-features -- -D warnings -D clippy::all -D clippy::cargo -A clippy::cargo-common-metadata
+RUSTDOCFLAGS="-D warnings" cargo doc --locked --workspace --no-deps --document-private-items
+cargo test --locked            # unit tests must pass
+```
+
+Or simply: `make lint && cargo test --locked`
+
+The CI also runs `./scripts/test-sccache.sh` (sccache integration test) when SMB credentials are available.
+
 The binary requires these environment variables:
 - `SPICEIO_SMB_SERVER` (required) — SMB server hostname or IP
 - `SPICEIO_SMB_USER` (required) — SMB username