fix: Add optional-dependencies to pyproject.toml for CI, update type annotations for Python 3.9+

- Add [project.optional-dependencies] for test and params extras in pyproject.toml
- Update type annotations to use modern syntax (list[X] instead of List[X])
- Update setup.py python_requires to >=3.9, add Python 3.12 classifier
- Update ruff target-version to py39
- Remove deprecated ANN101/ANN102 rules from ignore list
- Add mypy exclude for .venv, build, dist directories

Author: lukekim

pyproject.toml

@@ -31,6 +31,26 @@ Documentation = "https://docs.spice.ai/sdks/python-sdk"
 Repository = "https://github.com/spiceai/spicepy"
 Issues = "https://github.com/spiceai/spicepy/issues"
 
+[project.optional-dependencies]
+test = [
+    "pylint>=3.3.1",
+    "flake8>=7.1.1",
+    "ruff>=0.4.0",
+    "mypy>=1.10.0",
+    "pytest>=8.3.3",
+    "pytest-cov>=5.0.0",
+    "pytest-xdist>=3.5.0",
+    "pytest-timeout>=2.3.1",
+    "pytest_httpserver==1.1.3",
+    "types-requests>=2.31.0",
+    "pandas-stubs>=2.0.0",
+    "bandit>=1.7.8",
+]
+params = [
+    "adbc-driver-flightsql>=1.0.0",
+    "adbc-driver-manager>=1.0.0",
+]
+
 # ============== Tool Configuration ==============
 
 [tool.mypy]
@@ -49,6 +69,11 @@ warn_unreachable = false
 show_error_codes = true
 show_column_numbers = true
 pretty = true
+exclude = [
+    "^\\.venv/",
+    "^build/",
+    "^dist/",
+]
 
 [[tool.mypy.overrides]]
 module = [
@@ -57,11 +82,13 @@ module = [
     "adbc_driver_manager.*",
     "certifi",
     "pandas",
+    "_pytest.*",
+    "pytest.*",
 ]
 ignore_missing_imports = true
 
 [tool.ruff]
-target-version = "py38"
+target-version = "py39"
 line-length = 120
 exclude = [
     ".git",
@@ -105,8 +132,6 @@ ignore = [
     "D107",   # Missing docstring in __init__
     "D203",   # 1 blank line required before class docstring (conflicts with D211)
     "D213",   # Multi-line docstring summary should start at the second line (conflicts with D212)
-    "ANN101", # Missing type annotation for self
-    "ANN102", # Missing type annotation for cls
     "ANN401", # Dynamically typed expressions (Any) are disallowed
     "ANN001", # Missing type annotation for function argument (too strict for legacy code)
     "ANN002", # Missing type annotation for *args

setup.py

@@ -39,10 +39,10 @@ def setup_package():
             "Development Status :: 4 - Beta",
             "Intended Audience :: Developers",
             "License :: OSI Approved :: Apache Software License",
-            "Programming Language :: Python :: 3.8",
             "Programming Language :: Python :: 3.9",
             "Programming Language :: Python :: 3.10",
             "Programming Language :: Python :: 3.11",
+            "Programming Language :: Python :: 3.12",
             "Topic :: Software Development :: Libraries",
         ],
         keywords="spice, AI, web3, data, ML",
@@ -57,7 +57,7 @@ def setup_package():
                 "adbc-driver-manager>=1.0.0",
             ],
         },
-        python_requires=">=3.8",
+        python_requires=">=3.9",
         platforms=["Any"],
     )
 

spicepy/_client.py

@@ -3,7 +3,7 @@
 import platform
 import threading
 from pathlib import Path
-from typing import Any, Dict, List, Optional, Union
+from typing import Any, Optional, Union
 
 import certifi
 import pyarrow as pa
@@ -93,7 +93,7 @@ def _init_connection(self):
 
     def _create_param_batch(
         self,
-        params: List[Any],
+        params: list[Any],
     ) -> pa.RecordBatch:
         """Create a parameter record batch for binding to a prepared statement.
 
@@ -131,7 +131,7 @@ def _create_param_batch(
     def query_with_params(
         self,
         sql: str,
-        params: List[Any],
+        params: list[Any],
     ) -> pa.RecordBatchReader:
         """Execute a parameterized SQL query using prepared statements.
 
@@ -271,7 +271,7 @@ def __init__(
         self._adbc_client: Optional[_ADBCClient] = None
         self.http = HttpRequests(http_url, self._headers(user_agent))
 
-    def _headers(self, user_agent=None) -> Dict[str, str]:
+    def _headers(self, user_agent=None) -> dict[str, str]:
         headers = {
             "X-API-Key": self._api_key(),
             "Accept": "application/json",
@@ -324,7 +324,7 @@ def query(self, query: str, **kwargs) -> flight.FlightStreamReader:
     def query_with_params(
         self,
         sql: str,
-        params: List[Any],
+        params: list[Any],
     ) -> pa.RecordBatchReader:
         """Execute a parameterized SQL query using ADBC.
 

spicepy/_http.py

@@ -1,6 +1,6 @@
 import datetime
 from dataclasses import dataclass
-from typing import Any, Callable, Dict, Literal, Optional
+from typing import Any, Callable, Literal, Optional
 
 from requests import Response, Session
 from requests.adapters import HTTPAdapter, Retry
@@ -15,7 +15,7 @@ class RefreshOpts:
     refresh_mode: Optional[str] = None
     refresh_jitter_max: Optional[str] = None
 
-    def to_dict(self) -> Dict[str, Any]:
+    def to_dict(self) -> dict[str, Any]:
         return {
             "refresh_sql": self.refresh_sql,
             "refresh_mode": self.refresh_mode,
@@ -27,7 +27,7 @@ def to_dict(self) -> Dict[str, Any]:
 
 
 class HttpRequests:
-    def __init__(self, base_url: str, headers: Dict[str, str]) -> None:
+    def __init__(self, base_url: str, headers: dict[str, str]) -> None:
         self.session = self._create_session(headers)
 
         # set the user-agent header
@@ -42,8 +42,8 @@ def send_request(
         self,
         method: HttpMethod,
         path: str,
-        param: Optional[Dict[str, Any]] = None,
-        headers: Optional[Dict[str, Any]] = None,
+        param: Optional[dict[str, Any]] = None,
+        headers: Optional[dict[str, Any]] = None,
         body: Optional[str] = None,
     ) -> Any:
         if headers is None:
@@ -61,7 +61,7 @@ def send_request(
         response.raise_for_status()
         return response.json()
 
-    def prepare_param(self, params: Dict[str, Any]) -> Dict[str, Any]:
+    def prepare_param(self, params: dict[str, Any]) -> dict[str, Any]:
         for k, val in params.items():
             if isinstance(val, datetime.timedelta):
                 params[k] = timedelta_to_duration_str(val)
@@ -84,7 +84,7 @@ def _operation(self, method: HttpMethod) -> Callable[..., Response]:
             raise SpiceAIError(f"{method} is not a valid HTTP operation")
         return _call
 
-    def _create_session(self, headers: Dict[str, str]) -> Session:
+    def _create_session(self, headers: dict[str, str]) -> Session:
         sess = Session()
         sess.headers = headers  # type: ignore[assignment]
         sess.mount(

tests/conftest.py

@@ -3,7 +3,7 @@
 from __future__ import annotations
 
 import os
-from typing import Generator
+from collections.abc import Generator
 from unittest.mock import MagicMock, patch
 
 import pytest