Skip to content

Commit 29f82c0

Browse files
committed
Disable child metric registration under parent to prevent OOM
1 parent 96950b8 commit 29f82c0

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

vortex-metrics/src/lib.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,9 @@ impl VortexMetrics {
8282
/// child registry will be included in this registry's snapshots.
8383
pub fn child_with_tags(&self, additional_tags: impl Into<DefaultTags>) -> Self {
8484
let child = Self::new_with_tags(self.inner.default_tags.merge(&additional_tags.into()));
85-
self.inner.children.write().push(child.clone());
85+
// TODO: Temporarily disabled due to memory growth: children accumulate indefinitely
86+
// https://github.com/vortex-data/vortex/discussions/5946
87+
// self.inner.children.write().push(child.clone());
8688
child
8789
}
8890

0 commit comments

Comments
 (0)