Skip to content

Commit 71ffc98

Browse files
gatesngatesn
authored
Remove compute vtable (vortex-data#6328)
In our ongoing effort to simplify array vtables, this removes the compute vtable. It was only implemented by ChunkedArray, which now pushed down compute via reduce rules. Signed-off-by: Nicholas Gates <nick@nickgates.com>
1 parent 99857ce commit 71ffc98

60 files changed

Lines changed: 0 additions & 398 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎encodings/alp/src/alp/array.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ use vortex_array::stats::StatsSetRef;
2525
use vortex_array::vtable;
2626
use vortex_array::vtable::ArrayId;
2727
use vortex_array::vtable::BaseArrayVTable;
28-
use vortex_array::vtable::NotSupported;
2928
use vortex_array::vtable::VTable;
3029
use vortex_array::vtable::ValidityChild;
3130
use vortex_array::vtable::ValidityVTableFromChild;
@@ -54,7 +53,6 @@ impl VTable for ALPVTable {
5453
type OperationsVTable = Self;
5554
type ValidityVTable = ValidityVTableFromChild;
5655
type VisitorVTable = Self;
57-
type ComputeVTable = NotSupported;
5856

5957
fn id(_array: &Self::Array) -> ArrayId {
6058
Self::ID

‎encodings/alp/src/alp_rd/array.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ use vortex_array::validity::Validity;
2828
use vortex_array::vtable;
2929
use vortex_array::vtable::ArrayId;
3030
use vortex_array::vtable::BaseArrayVTable;
31-
use vortex_array::vtable::NotSupported;
3231
use vortex_array::vtable::VTable;
3332
use vortex_array::vtable::ValidityChild;
3433
use vortex_array::vtable::ValidityVTableFromChild;
@@ -72,7 +71,6 @@ impl VTable for ALPRDVTable {
7271
type OperationsVTable = Self;
7372
type ValidityVTable = ValidityVTableFromChild;
7473
type VisitorVTable = Self;
75-
type ComputeVTable = NotSupported;
7674

7775
fn id(_array: &Self::Array) -> ArrayId {
7876
Self::ID

‎encodings/bytebool/src/array.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ use vortex_array::validity::Validity;
2222
use vortex_array::vtable;
2323
use vortex_array::vtable::ArrayId;
2424
use vortex_array::vtable::BaseArrayVTable;
25-
use vortex_array::vtable::NotSupported;
2625
use vortex_array::vtable::OperationsVTable;
2726
use vortex_array::vtable::VTable;
2827
use vortex_array::vtable::ValidityHelper;
@@ -49,7 +48,6 @@ impl VTable for ByteBoolVTable {
4948
type OperationsVTable = Self;
5049
type ValidityVTable = ValidityVTableFromValidityHelper;
5150
type VisitorVTable = Self;
52-
type ComputeVTable = NotSupported;
5351

5452
fn id(_array: &Self::Array) -> ArrayId {
5553
Self::ID

‎encodings/datetime-parts/src/array.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ use vortex_array::stats::StatsSetRef;
2323
use vortex_array::vtable;
2424
use vortex_array::vtable::ArrayId;
2525
use vortex_array::vtable::BaseArrayVTable;
26-
use vortex_array::vtable::NotSupported;
2726
use vortex_array::vtable::VTable;
2827
use vortex_array::vtable::ValidityChild;
2928
use vortex_array::vtable::ValidityVTableFromChild;
@@ -81,7 +80,6 @@ impl VTable for DateTimePartsVTable {
8180
type OperationsVTable = Self;
8281
type ValidityVTable = ValidityVTableFromChild;
8382
type VisitorVTable = Self;
84-
type ComputeVTable = NotSupported;
8583

8684
fn id(_array: &Self::Array) -> ArrayId {
8785
Self::ID

‎encodings/decimal-byte-parts/src/decimal_byte_parts/mod.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ use vortex_array::stats::StatsSetRef;
2828
use vortex_array::vtable;
2929
use vortex_array::vtable::ArrayId;
3030
use vortex_array::vtable::BaseArrayVTable;
31-
use vortex_array::vtable::NotSupported;
3231
use vortex_array::vtable::OperationsVTable;
3332
use vortex_array::vtable::VTable;
3433
use vortex_array::vtable::ValidityChild;
@@ -67,7 +66,6 @@ impl VTable for DecimalBytePartsVTable {
6766
type OperationsVTable = Self;
6867
type ValidityVTable = ValidityVTableFromChild;
6968
type VisitorVTable = Self;
70-
type ComputeVTable = NotSupported;
7169

7270
fn id(_array: &Self::Array) -> ArrayId {
7371
Self::ID

‎encodings/fastlanes/src/bitpacking/vtable/mod.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ use vortex_array::serde::ArrayChildren;
1515
use vortex_array::validity::Validity;
1616
use vortex_array::vtable;
1717
use vortex_array::vtable::ArrayId;
18-
use vortex_array::vtable::NotSupported;
1918
use vortex_array::vtable::VTable;
2019
use vortex_array::vtable::ValidityVTableFromValidityHelper;
2120
use vortex_dtype::DType;
@@ -58,7 +57,6 @@ impl VTable for BitPackedVTable {
5857
type OperationsVTable = Self;
5958
type ValidityVTable = ValidityVTableFromValidityHelper;
6059
type VisitorVTable = Self;
61-
type ComputeVTable = NotSupported;
6260

6361
fn id(_array: &Self::Array) -> ArrayId {
6462
Self::ID

‎encodings/fastlanes/src/delta/vtable/mod.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ use vortex_array::buffer::BufferHandle;
1111
use vortex_array::serde::ArrayChildren;
1212
use vortex_array::vtable;
1313
use vortex_array::vtable::ArrayId;
14-
use vortex_array::vtable::NotSupported;
1514
use vortex_array::vtable::VTable;
1615
use vortex_array::vtable::ValidityVTableFromChildSliceHelper;
1716
use vortex_dtype::DType;
@@ -51,7 +50,6 @@ impl VTable for DeltaVTable {
5150
type OperationsVTable = Self;
5251
type ValidityVTable = ValidityVTableFromChildSliceHelper;
5352
type VisitorVTable = Self;
54-
type ComputeVTable = NotSupported;
5553

5654
fn id(_array: &Self::Array) -> ArrayId {
5755
Self::ID

‎encodings/fastlanes/src/for/vtable/mod.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ use vortex_array::buffer::BufferHandle;
1313
use vortex_array::serde::ArrayChildren;
1414
use vortex_array::vtable;
1515
use vortex_array::vtable::ArrayId;
16-
use vortex_array::vtable::NotSupported;
1716
use vortex_array::vtable::VTable;
1817
use vortex_array::vtable::ValidityVTableFromChild;
1918
use vortex_dtype::DType;
@@ -45,7 +44,6 @@ impl VTable for FoRVTable {
4544
type OperationsVTable = Self;
4645
type ValidityVTable = ValidityVTableFromChild;
4746
type VisitorVTable = Self;
48-
type ComputeVTable = NotSupported;
4947

5048
fn id(_array: &Self::Array) -> ArrayId {
5149
Self::ID

‎encodings/fastlanes/src/rle/vtable/mod.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ use vortex_array::buffer::BufferHandle;
1010
use vortex_array::serde::ArrayChildren;
1111
use vortex_array::vtable;
1212
use vortex_array::vtable::ArrayId;
13-
use vortex_array::vtable::NotSupported;
1413
use vortex_array::vtable::VTable;
1514
use vortex_array::vtable::ValidityVTableFromChildSliceHelper;
1615
use vortex_dtype::DType;
@@ -55,7 +54,6 @@ impl VTable for RLEVTable {
5554
type OperationsVTable = Self;
5655
type ValidityVTable = ValidityVTableFromChildSliceHelper;
5756
type VisitorVTable = Self;
58-
type ComputeVTable = NotSupported;
5957

6058
fn id(_array: &Self::Array) -> ArrayId {
6159
Self::ID

‎encodings/fsst/src/array.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ use vortex_array::validity::Validity;
3535
use vortex_array::vtable;
3636
use vortex_array::vtable::ArrayId;
3737
use vortex_array::vtable::BaseArrayVTable;
38-
use vortex_array::vtable::NotSupported;
3938
use vortex_array::vtable::VTable;
4039
use vortex_array::vtable::ValidityChild;
4140
use vortex_array::vtable::ValidityHelper;
@@ -83,7 +82,6 @@ impl VTable for FSSTVTable {
8382
type OperationsVTable = Self;
8483
type ValidityVTable = ValidityVTableFromChild;
8584
type VisitorVTable = Self;
86-
type ComputeVTable = NotSupported;
8785

8886
fn id(_array: &Self::Array) -> ArrayId {
8987
Self::ID

0 commit comments

Comments
 (0)