fix[operator]: fixed test that fail when using operators (vortex-data#5880)

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Author: joseph-isaacs

vortex-array/src/arrays/scalar_fn/vtable/validity.rs

@@ -14,12 +14,36 @@ use crate::LEGACY_SESSION;
 use crate::arrays::scalar_fn::array::ScalarFnArray;
 use crate::arrays::scalar_fn::vtable::ScalarFnVTable;
 use crate::executor::VectorExecutor;
+use crate::expr::ExecutionArgs;
 use crate::validity::Validity;
 use crate::vtable::ValidityVTable;
 
 impl ValidityVTable<ScalarFnVTable> for ScalarFnVTable {
     fn is_valid(array: &ScalarFnArray, index: usize) -> bool {
-        array.scalar_at(index).is_valid()
+        // inlined to remove a cycle `is_valid()` and `scalar_at()`
+        assert!(index < array.len(), "index {index} out of bounds");
+        let input_datums: Vec<_> = array
+            .children()
+            .iter()
+            .map(|c| c.scalar_at(index))
+            .map(|scalar| Datum::from(scalar.to_vector_scalar()))
+            .collect();
+
+        let ctx = ExecutionArgs {
+            datums: input_datums,
+            dtypes: array.children().iter().map(|c| c.dtype().clone()).collect(),
+            row_count: 1,
+            return_dtype: array.dtype.clone(),
+        };
+
+        let result = array
+            .scalar_fn
+            .execute(ctx)
+            .vortex_expect("Scalar function execution should be fallible")
+            .into_scalar()
+            .vortex_expect("Scalar function execution should return scalar");
+
+        result.is_valid()
     }
 
     fn all_valid(array: &ScalarFnArray) -> bool {

vortex-layout/src/layouts/dict/reader.rs

@@ -519,7 +519,7 @@ mod tests {
                 .await
                 .unwrap();
             let expected = array.validity_mask().into_array();
-            assert_arrays_eq!(actual, expected);
+            assert_arrays_eq!(actual.to_canonical().into_array(), expected);
         })
     }
 }