Skip to content

Commit f258e7b

Browse files
authored
Disable child metric registration under parent to prevent OOM (#10)
1 parent 96950b8 commit f258e7b

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

vortex-metrics/src/lib.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,9 @@ impl VortexMetrics {
8181
/// Create a new metrics registry with additional tags. Metrics created in the
8282
/// child registry will be included in this registry's snapshots.
8383
pub fn child_with_tags(&self, additional_tags: impl Into<DefaultTags>) -> Self {
84-
let child = Self::new_with_tags(self.inner.default_tags.merge(&additional_tags.into()));
85-
self.inner.children.write().push(child.clone());
86-
child
84+
// TODO: Child metric registration under parent is temporarily disabled due to memory growth - children accumulate indefinitely.
85+
// https://github.com/vortex-data/vortex/discussions/5946
86+
Self::new_with_tags(self.inner.default_tags.merge(&additional_tags.into()))
8787
}
8888

8989
/// Returns the counter with the specified ID, creating a default instance if absent.

0 commit comments

Comments
 (0)