Skip to content

Commit ac5a8ad

Browse files
committed
Fix CI: migrate biome.json to v2 schema, pin @actions/core to v1
Two regressions came in via Dependabot bumps on trunk: - @biomejs/biome 1.x → 2.x renamed config keys (`files.ignore` → `files.includes` with negation patterns, `overrides[*].include` → `overrides[*].includes`, top-level `organizeImports` moved into `assist.actions.source.organizeImports`). Update biome.json to the v2 schema and reorder a stale import that the v2 organizer flagged. - @actions/core 1.x → 3.x is ESM-only and broke the CJS TypeScript build (TS1479). Pin it back to ^1.11.1 and ignore future major bumps in Dependabot until we migrate the project to ESM.
1 parent ed5f96d commit ac5a8ad

7 files changed

Lines changed: 38 additions & 27 deletions

File tree

.github/dependabot.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ updates:
55
schedule:
66
interval: weekly
77
open-pull-requests-limit: 10
8+
ignore:
9+
# Pin to v1.x — v2+ is ESM-only and breaks the current CJS bundle. Track
10+
# the ESM migration before lifting this.
11+
- dependency-name: "@actions/core"
12+
update-types: ["version-update:semver-major"]
813
groups:
914
production:
1015
dependency-type: production

biome.json

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
2-
"$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
2+
"$schema": "https://biomejs.dev/schemas/2.4.14/schema.json",
33
"files": {
4-
"ignore": ["dist", "lib", "node_modules", "coverage"]
4+
"includes": ["**", "!dist", "!lib", "!node_modules", "!coverage"]
55
},
66
"formatter": {
77
"enabled": true,
@@ -24,7 +24,7 @@
2424
},
2525
"overrides": [
2626
{
27-
"include": ["__tests__/**"],
27+
"includes": ["__tests__/**"],
2828
"linter": {
2929
"rules": {
3030
"style": {
@@ -41,5 +41,11 @@
4141
"trailingCommas": "all"
4242
}
4343
},
44-
"organizeImports": { "enabled": true }
44+
"assist": {
45+
"actions": {
46+
"source": {
47+
"organizeImports": "on"
48+
}
49+
}
50+
}
4551
}

dist/index.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock.json

Lines changed: 17 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"all": "npm run lint && npm run typecheck && npm run test && npm run build"
2424
},
2525
"dependencies": {
26-
"@actions/core": "^3.0.1",
26+
"@actions/core": "^1.11.1",
2727
"@spiceai/spice": "^3.1.0"
2828
},
2929
"overrides": {

src/deploy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import { DeploymentFailedError, DeploymentTimeoutError, InputValidationError } f
44
import type { ActionInputs } from "./inputs.js";
55
import { deriveRuntimeUrl, deriveRuntimeUrlFromCname } from "./inputs.js";
66
import { buildProbePlans } from "./probes.js";
7-
import { RuntimeClient } from "./runtime.js";
87
import type { ProbeResult } from "./runtime.js";
8+
import { RuntimeClient } from "./runtime.js";
99
import { parseSecrets } from "./secrets.js";
1010
import { readSpicepod } from "./spicepod.js";
1111
import { parseTags } from "./tags.js";

0 commit comments

Comments
 (0)