Skip to content

Double check whether changes to "UNKNOWN" file type category mesh with manual-correction repo #14

@joshuacwnewton

Description

@joshuacwnewton

In normal QC reports, when a file type is unknown (i.e. we haven't entered a mapping between SCT script and file type), the output will look like this:

FILES_GENERATED_BY_sct_fmri_compute_tsnr_FILE_KIND_UNKNOWN:
    - /home/joshua/Downloads/data_processing-fmri-data/single_subject/data/fmri/fmri_tsnr.nii.gz

In other words, the convention is to simply insert the script name into FILES_GENERATED_BY_{%}_FILE_KIND_UNKNOWN.

However, for the new QC report (circa commit f57719d), the convention is:

FILE_KIND_UNKNOWN:
    - /path/to/datasets/t2_seg.nii.gz # generated by sct_get_centerline -i t2_seg.nii.gz -method fitseg -qc /path/to/spinalcordtoolbox/qc_example_data
    - /path/to/datasets/t2_seg.nii.gz # generated by sct_get_centerline -i t2_seg.nii.gz -method fitseg -centerline-soft 1 -o t2_seg_centerline_soft.nii.gz -qc /path/to/spinalcordtoolbox/qc_example_data

Personally, I like the look of this a lot! But, I'm unsure if the old category syntax was semantically important for the manual-correction repo (where these exported yaml files are used).

I'm mostly sure that this change will be OK, but I'm opening this issue just to confirm.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions